Received: by 2002:a05:6358:a55:b0:ec:fcf4:3ecf with SMTP id 21csp656087rwb; Thu, 12 Jan 2023 10:31:27 -0800 (PST) X-Google-Smtp-Source: AMrXdXsOApTwRAwUiMjNmTlleVLg2APLIZ/DRscWOMAgFCV8kp4FJypJWDGyNq5AU889kF2VvuO1 X-Received: by 2002:a05:6a20:1455:b0:ad:e06f:9540 with SMTP id a21-20020a056a20145500b000ade06f9540mr47321862pzi.4.1673548287484; Thu, 12 Jan 2023 10:31:27 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1673548287; cv=none; d=google.com; s=arc-20160816; b=C0vFUUyabfWgQmENQmt6/feIBw4TxM8dS/rPflIPZWmZYBoel+/kg3FnT/1+4wPqn+ C19Bz4oLuYje/woKUQAfCIlHOCXw6aph8seo3lFxlTQ1CAlrGk9rh+VTIr06nRPtQli3 nrt2MDiIhtnGq0Azeo2/jkKWh5xdOevzzgH8txUj3IvyAsbnEs9kntkq5q1nGZgr+Ofj 5dRw0YmU9J1uFnmK3x6ON+k4O7W/0HkAlsm5hXMUocPmjaroBCtx56LNLP8T/IWZdLDC zFh3Dy5EzwFY8qY+K+xFtdyK37goM5bxvubIAjjbEoqOv0a1WbBV1LP2GLVLP3NJUvuc 45Gw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:mime-version :references:in-reply-to:message-id:date:subject:cc:to:from; bh=bQLSQngImh+JAaTIwv/oiTsE5mTVvyIYWAlaGC+Oirg=; b=q2XbYMZY+loVoE/DGduchj+PJuAmdqE87qzPuqbpzxU2faYNQin2Fjo4RMwAccD+TJ rwvdDGmKdIGR9Ea1/ha/i7Hh4gN1BhyqdPGoww+XnqILgyTgf8g3jbJPmUsRTSNJEcXU w9fVq9wsS+Zmuh9f0YshoFcFcG7Kz5lmkSroILyGiT9K3ANwal6y0u1Rv1BK/BXLD98I t5Fa6JZ1tMO3DhJWVWE+V2f3x7VPP53Ci/QYT/2c8iD94YJbEkEZkvSQVqOOFHA+Lg0x k+/YuklGcVP47JnHtz1HIJYGC6axdbn4xBfLp8T13uaj3Tf4zTQT0z9qVWrvFjSnhAtW EXZA== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=arm.com Return-Path: Received: from out1.vger.email (out1.vger.email. [2620:137:e000::1:20]) by mx.google.com with ESMTP id t8-20020a655548000000b0047699804989si18173681pgr.64.2023.01.12.10.31.20; Thu, 12 Jan 2023 10:31:27 -0800 (PST) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20; Authentication-Results: mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=arm.com Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S240093AbjALSTn (ORCPT + 50 others); Thu, 12 Jan 2023 13:19:43 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:32970 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S240518AbjALSSW (ORCPT ); Thu, 12 Jan 2023 13:18:22 -0500 Received: from ams.source.kernel.org (ams.source.kernel.org [145.40.68.75]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 20EA9DEF for ; Thu, 12 Jan 2023 09:49:57 -0800 (PST) Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by ams.source.kernel.org (Postfix) with ESMTPS id CC35CB81F08 for ; Thu, 12 Jan 2023 17:49:55 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 40D14C43398; Thu, 12 Jan 2023 17:49:53 +0000 (UTC) From: Catalin Marinas To: Will Deacon , Mark Brown Cc: Marc Zyngier , Suzuki K Poulose , linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH] arm64/cpufeature: Remove 4 bit assumption in ARM64_FEATURE_MASK() Date: Thu, 12 Jan 2023 17:49:50 +0000 Message-Id: <167354578784.3644325.17415348273046160452.b4-ty@arm.com> X-Mailer: git-send-email 2.34.1 In-Reply-To: <20221222-arm64-arm64-feature-mask-v1-1-c34c1e177f90@kernel.org> References: <20221222-arm64-arm64-feature-mask-v1-1-c34c1e177f90@kernel.org> MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 8bit X-Spam-Status: No, score=-6.7 required=5.0 tests=BAYES_00, HEADER_FROM_DIFFERENT_DOMAINS,RCVD_IN_DNSWL_HI,SPF_HELO_NONE,SPF_PASS autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Tue, 27 Dec 2022 13:00:39 +0000, Mark Brown wrote: > The ARM64_FEATURE_MASK(), used extensively by KVM, assumes that all ID > register fields are 4 bits wide but this is not the case any more, for > example there are several 1 bit fields in ID_AA64SMFR0_EL1. Fortunately > we now have generated constants for all the ID mask registers which can > be used instead. Rather than create churn from updating existing users > update the macro to reference the generated constants and replace the > comment with a note advising against adding new users. > > [...] Applied to arm64 (for-next/sysreg), thanks! [1/1] arm64/cpufeature: Remove 4 bit assumption in ARM64_FEATURE_MASK() https://git.kernel.org/arm64/c/e978eaca4bee -- Catalin