Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Message-ID: <d62e3b08-c3c9-1ebe-42be-4307d3b3e29e@amd.com>
Date:   Thu, 12 Jan 2023 13:06:52 -0600
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101
 Thunderbird/102.4.2
Reply-To: babu.moger@amd.com
Subject: Re: [PATCH v11 13/13] Documentation/x86: Update resctrl.rst for new
 features
Content-Language: en-US
To:     Reinette Chatre <reinette.chatre@intel.com>,
        "corbet@lwn.net" <corbet@lwn.net>,
        "tglx@linutronix.de" <tglx@linutronix.de>,
        "mingo@redhat.com" <mingo@redhat.com>,
        "bp@alien8.de" <bp@alien8.de>
Cc:     "fenghua.yu@intel.com" <fenghua.yu@intel.com>,
        "dave.hansen@linux.intel.com" <dave.hansen@linux.intel.com>,
        "x86@kernel.org" <x86@kernel.org>, "hpa@zytor.com" <hpa@zytor.com>,
        "paulmck@kernel.org" <paulmck@kernel.org>,
        "akpm@linux-foundation.org" <akpm@linux-foundation.org>,
        "quic_neeraju@quicinc.com" <quic_neeraju@quicinc.com>,
        "rdunlap@infradead.org" <rdunlap@infradead.org>,
        "damien.lemoal@opensource.wdc.com" <damien.lemoal@opensource.wdc.com>,
        "songmuchun@bytedance.com" <songmuchun@bytedance.com>,
        "peterz@infradead.org" <peterz@infradead.org>,
        "jpoimboe@kernel.org" <jpoimboe@kernel.org>,
        "pbonzini@redhat.com" <pbonzini@redhat.com>,
        "chang.seok.bae@intel.com" <chang.seok.bae@intel.com>,
        "pawan.kumar.gupta@linux.intel.com" 
        <pawan.kumar.gupta@linux.intel.com>,
        "jmattson@google.com" <jmattson@google.com>,
        "daniel.sneddon@linux.intel.com" <daniel.sneddon@linux.intel.com>,
        "Das1, Sandipan" <Sandipan.Das@amd.com>,
        "tony.luck@intel.com" <tony.luck@intel.com>,
        "james.morse@arm.com" <james.morse@arm.com>,
        "linux-doc@vger.kernel.org" <linux-doc@vger.kernel.org>,
        "linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
        "bagasdotme@gmail.com" <bagasdotme@gmail.com>,
        "eranian@google.com" <eranian@google.com>,
        "christophe.leroy@csgroup.eu" <christophe.leroy@csgroup.eu>,
        "jarkko@kernel.org" <jarkko@kernel.org>,
        "adrian.hunter@intel.com" <adrian.hunter@intel.com>,
        "quic_jiles@quicinc.com" <quic_jiles@quicinc.com>,
        "peternewman@google.com" <peternewman@google.com>
References: <20230109164405.569714-1-babu.moger@amd.com>
 <20230109164405.569714-14-babu.moger@amd.com>
 <c7d563ce-13d9-ca6b-a5c9-7e08a3cdc3a9@intel.com>
 <MW3PR12MB45538E045D655C1D6B3BD02C95FC9@MW3PR12MB4553.namprd12.prod.outlook.com>
 <812a0d4d-dfb9-d351-9c9d-01d6943cd72b@intel.com>
 <MW3PR12MB45534504C044EBAEABA9E9E295FD9@MW3PR12MB4553.namprd12.prod.outlook.com>
 <65927b26-9f0e-7a82-a150-6459b5477a92@intel.com>
From:   "Moger, Babu" <babu.moger@amd.com>
In-Reply-To: <65927b26-9f0e-7a82-a150-6459b5477a92@intel.com>
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 7bit
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?K25KYVlOdEhWZk9SaDk1blROUEJvN2ZabUVld2ZPQm9vbjl6Y0JsRlFna2Z4?=
 =?utf-8?B?TFM5RE1nRjVWWExranpjZnltdm4vOEVMcStZbFU2NG9vWW5aZFFjMkU1cm1S?=
 =?utf-8?B?Zldic3p6aGIwV3c3U3dEQ2NOR0RodjlDVzdjR0dUTTlaK29qazhxdEJaZEd0?=
 =?utf-8?B?alFoRkpDVDU1ekFLdE5ZRklTY243dEtjdWhGbnZHN043QnlTa1U3cVVDNkl2?=
 =?utf-8?B?RzhVbmd4T1Vqb2xoaFJySEtWK2tCdmtNYkpxSmZDT28yVTZsZHBnVjBpdEU3?=
 =?utf-8?B?ZFR2dUo5SUpWaTJSdWNCZEFmQ1UzSnVYNUZqeXpuUXFtZnduRFlzWGhoYi80?=
 =?utf-8?B?RXZoeEJjZHNub0FsTTgvMWh2SjVSeGhIaWdZbFBSWHc4MFE0QzNROHBUSHdq?=
 =?utf-8?B?L21Ob09MVjBSZ0o2Wi8wWXpEUTMvQzVkMnY3d2FIbVpnbXp4b3dYZUlUWEt6?=
 =?utf-8?B?Q0pocHhhYkJuanA2U3kxT0wvek1NbllxbEI2SW1pSC96QTBrTU1LYmhFZXZZ?=
 =?utf-8?B?eXluT1RNclAyODFRaW81RVVTOWtJZEZsSkVLSFBoL3drQUhWQVpvMlhnQmFM?=
 =?utf-8?B?YzB4Wks4a3JHWFFoNUJDYjd2K1ZlbUNRclhIUFlIVExvM1FiOFJWT3pVWHF2?=
 =?utf-8?B?b1crMitDYTFwN1Uvc3lsb25BVnJLY0pyTUNGbm9sT2REa0RzRFBoWDJXZncv?=
 =?utf-8?B?VDNYUGZNY092dG8wNUZEYWZ3MW1ITUx1Nmc2VkFaN0oxRFhtcFh2dFQ2cFFa?=
 =?utf-8?B?ek1nWU1aMUc2UldkbVFUeWpwSk9obnBVQmJ0dWlVSUZhV3NLbHBwMVB3bStT?=
 =?utf-8?B?UTh6WjQxcnJmSGVUc0grUThJYU90d1RkeSt0bXc4ZmwrYzdGRHYyR0N1WERo?=
 =?utf-8?B?YW5xUUFzUFlYVVJCNXZHR2ZFVkpIK1dsSlhsd1FnSlljYVhXb3ZDVmd1STMy?=
 =?utf-8?B?c0NKS2oxUGJaOWc0bmI4Q1RrUExGcDNHSjljNFhBSVZjOVE1Ymx4MFIxeURq?=
 =?utf-8?B?MHA3by9sRmNxNDhFaEFUMVRYNU1taCt5NjhrdHQ2VFcwRWY1MjZsdGpWNzkr?=
 =?utf-8?B?KzhrUXV5YWk0RU9DUmxnUk1DbGtrSXZCTitPM05GVUJic2cxaUJaVld1SS9l?=
 =?utf-8?B?L3lWeEhMdUk5anAzK294a0ExOGF3Ylp1eTk0dHo4QUlTR2xzSk9iOFhsd2lN?=
 =?utf-8?B?N0h5cGpUNlV3RWZtYmdvQXg1a3FxQm5zYkkyUnFXeU9ITXdoYW02TndveVFU?=
 =?utf-8?B?YVhzWGZGSHRMSTRSOWlvZGFSOEJzZ1FHVzk1RlNjdzNMbHRoYW1sa3dTU2VH?=
 =?utf-8?B?ajMrdjQxS09NRGRVZmpLVGl3K3MyVEw2K01vNWpFVVh3VnpqWFFhYXZTQmJ2?=
 =?utf-8?B?bXAyWml3UmlLWGU0NndYOVhyOTEwZlE4OFVGUEpKMXhQV01KZE9FVjdBR1Q5?=
 =?utf-8?B?UTQyb1ZYMXJTMXFWZmN5T1RRNTVUVGkzVDhTZVJYb3h5VERqQ05jTEI1aDQ0?=
 =?utf-8?B?bU13ZlRBRmhZQXpodlFzbzR0TU9Obm9KeERsN0QyRHVHZUtwa0lVT1FQQzQx?=
 =?utf-8?B?SmZFMFJlUjhVdEtUN2tYNkdBd3E5dnpuMEE3NUg0OWt1bTk3MDFTaEFkZ0xX?=
 =?utf-8?B?SEhTVVRqUWtPQTNGeFg4Rk1zc1hFMkxkQ1FuUmFoN1A3cFJTRnZFb0NzTTVq?=
 =?utf-8?B?UXZqYjYwVnVRRzhuM3dOQnZPb0VyWmowTXREcXhNRXdYQzBZQkRYbGtLRmdi?=
 =?utf-8?B?RnM4UEV6S3kyUDkrcjdtY2liUzFDd2xFemxVMEZsNG1ZcGZKTlplQlJPOVV4?=
 =?utf-8?B?QTVFN2c2L3ZKd3N6RnVUTDRBU2xOeGVIenVURmNuNkp6NDJETGo2bm50ZlVi?=
 =?utf-8?B?anVsaEtCWldOSFlBbmNNNVAyd0J4ZFhsUnVDQVBGL0h1STI4QkFQWDI2Umls?=
 =?utf-8?B?MzRuZHNkZzIrMzl2QmVNZ2xiVHBFczJXVFhrVWo3Qy9HR0tyTHJRUHNYaExX?=
 =?utf-8?B?ZWYzMGdLRFVmWDlYMzNNVDFaamRyS0Z2UzQrNW54RlRhY3NyUzVQUXBLYmlW?=
 =?utf-8?B?Z2NmSVpjZTIrU3lLeVRjTDhMMXQ1a0RNRElpOWwweFk5a1hkTzVweWlOZFoz?=
 =?utf-8?Q?ag2c=3D?=
X-OriginatorOrg: amd.com
X-MS-Exchange-CrossTenant-Network-Message-Id: e1795ac8-7402-41bb-b610-08daf4d02e6f
X-MS-Exchange-CrossTenant-AuthSource: MW3PR12MB4553.namprd12.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 12 Jan 2023 19:06:59.8450
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 3dd8961f-e488-4e60-8e11-a82d994e183d
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: nuuoEI/Xga8SqnwollULbuu1oRfZNWDta4QdP7Anmhyf0f4BtFSAX21YyJuKqwmo
X-MS-Exchange-Transport-CrossTenantHeadersStamped: BN9PR12MB5113
X-Spam-Status: No, score=-2.1 required=5.0 tests=BAYES_00,DKIM_SIGNED,
        DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,NICE_REPLY_A,RCVD_IN_DNSWL_NONE,
        RCVD_IN_MSPIKE_H2,SPF_HELO_PASS,SPF_PASS autolearn=ham
        autolearn_force=no version=3.4.6
X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on
        lindbergh.monkeyblade.net
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org


On 1/12/23 11:30, Reinette Chatre wrote:
> Hi Babu,
>
> On 1/11/2023 4:47 PM, Moger, Babu wrote:
>  
>> diff --git a/Documentation/x86/resctrl.rst b/Documentation/x86/resctrl.rst
>> index 2860856f4463..7df5889237f4 100644
>> --- a/Documentation/x86/resctrl.rst
>> +++ b/Documentation/x86/resctrl.rst
>> @@ -24,10 +24,15 @@ CDP (Code and Data Prioritization)          "cdp_l3", "cdp_l2"
>>  CQM (Cache QoS Monitoring)                     "cqm_llc", "cqm_occup_llc"
>>  MBM (Memory Bandwidth Monitoring)              "cqm_mbm_total", "cqm_mbm_local"
>>  MBA (Memory Bandwidth Allocation)              "mba"
>> -SMBA (Slow Memory Bandwidth Allocation)         "smba"
>> -BMEC (Bandwidth Monitoring Event Configuration) "bmec"
>> +SMBA (Slow Memory Bandwidth Allocation)         ""
>> +BMEC (Bandwidth Monitoring Event Configuration) ""
>>  ===============================================        ================================
>>
>> +Historically, new features were made visible by default in /proc/cpuinfo. This
>> +resulted in the feature flags becoming hard to parse by the humans. Adding a new
>> +flag to /proc/cpuinfo should be avoided if user space can obtain information
>> +about the feature from resctrl's info directory.
>> +
> Could you please replace "parse by the humans" with "parse by humans"?
Sure.
>
> The rest looks good to me.
>
> Could you please do a sanity check by building the documentation to ensure
> that the usage of the empty quotes looks as expected and is not parsed out by a
> tool when, for example, creating the html docs?

Yes. Will do.

Thanks

Babu

>
>>  To use the feature mount the file system::
>>
>>   # mount -t resctrl resctrl [-o cdp[,cdpl2][,mba_MBps]] /sys/fs/resctrl
> Thank you very much
>
> Reinette

-- 
Thanks
Babu Moger