Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Message-ID: <9e0a8b20-cb76-b06d-67fb-f8942df5a2f7@intel.com>
Date:   Thu, 12 Jan 2023 10:36:39 -0800
User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:102.0) Gecko/20100101
 Firefox/102.0 Thunderbird/102.6.1
Subject: Re: [PATCH 3/7] x86/cpu: Disable kernel LASS when patching kernel
 alternatives
Content-Language: en-US
To:     Dave Hansen <dave.hansen@intel.com>,
        Sohil Mehta <sohil.mehta@intel.com>,
        <linux-kernel@vger.kernel.org>, <x86@kernel.org>,
        Andy Lutomirski <luto@kernel.org>,
        Dave Hansen <dave.hansen@linux.intel.com>,
        Ravi Shankar <ravi.v.shankar@intel.com>,
        Tony Luck <tony.luck@intel.com>,
        Paul Lai <paul.c.lai@intel.com>
References: <20230110055204.3227669-1-yian.chen@intel.com>
 <20230110055204.3227669-4-yian.chen@intel.com>
 <693d8332-3b86-3dcf-fc87-5c3a08a752db@intel.com>
 <ad2da884-c8c8-bc57-e21f-452a08cb10cc@intel.com>
 <b9e73d06-bd95-7c54-3ff1-f9e43c9967a4@intel.com>
From:   "Chen, Yian" <yian.chen@intel.com>
In-Reply-To: <b9e73d06-bd95-7c54-3ff1-f9e43c9967a4@intel.com>
Content-Type: text/plain; charset="UTF-8"; format=flowed
Content-Transfer-Encoding: 7bit
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?K1NRNWZEVDJnMUFRaTZUWEw5ZnpGVnhWdHR3MVhDanVhNkZiaTVDUFBLMTFa?=
 =?utf-8?B?NWVXUTVCUDE2cDJtdzkzc1k0TkQxMGtkZUNYS2ZYdGNCK0RLN2tTNDRHWDZi?=
 =?utf-8?B?VEo4Nys2elBubTAxZFA2VStVN0U3ZjBzRGhxTWVSZGNyelVEK0JGN2ZiNXJR?=
 =?utf-8?B?c3NWbkExZUxqZEI5cUV2eFQrN1pCeXgySllSNGpMRkFCQW9qWXhIWmNEbzl4?=
 =?utf-8?B?d05wdU1mQlQyUFNqOWdwQ0ZyNVdRckNyS2M3aWx2MVE5S0JCbUFmSGtNcWJO?=
 =?utf-8?B?OEhnVC84YXIyblZmMHBIcW1jbVdiZHNxbCtFSTk0d3hXekdDSlBZK1R0cThE?=
 =?utf-8?B?dzBOa1VUQnpYOGZKd2RYd2xwL2NYSDkvdFdoS1A5dWZYZzA0SXQ3SllLYWo1?=
 =?utf-8?B?VitIbGNRd1FhZy8zbThkcG5ybmVzV0E2TVlmS1VpOG5MMXJNWHRWd2hBVzk3?=
 =?utf-8?B?enZ3Mzd5M1JVaFd0UllhMGc3amg3eGhhaDc5YW5qeTNYMEs3dHc4Y2hRcDBJ?=
 =?utf-8?B?MUx6SUtuYlhZN0Rwc2c5ZVFGS0RBemhON0MxWmdkMnJhQ1cxenVwQlhoS0c4?=
 =?utf-8?B?TG1yYmxVbU4rblFlbXVMemV1UHFHUGVhZUwzZjZZazROYUtTcVBQaHVjRjU2?=
 =?utf-8?B?TzVkSkYzT2ljTndtNGVoVElId0ZVMUw5OFFlSHkyV0tmZEl5eXM3eXJLZnN2?=
 =?utf-8?B?NENPRlp1YVdwampSbjFOajFsTEQ0bHRScitCZ0RrYjZvNVpLTFE5WEwwWlho?=
 =?utf-8?B?Nm13aUZrMlZka0xRaDhKZU8rRmEvNkpaSDV0eGdUSklYU3g0enF2TFZENVAv?=
 =?utf-8?B?bnhleW9ZK3I0dWVJMU9jTnZTZFlNK2l6Z0VRdkZyOTNtVHltSWF0YVlvUm1P?=
 =?utf-8?B?ZWhlSkJmZEtJdGY3YndoVy9iM1UxcEhHSnZNTGl1QmNCMnpmRWhSODBQR0FK?=
 =?utf-8?B?N3NwTVc3Q0ZqOTZES3hlNkdQNjR1aXFNRTFNVUNMTHJvR08wQmpkcU9iMVAv?=
 =?utf-8?B?dWxINmVnNkRPck84QkJlby9CWklPOVBvY3hzdUNjekVsMEQxN3RBdjB5KzN2?=
 =?utf-8?B?T0FBa3Bad2FYSmhLeERKRlJCQ2pWdTQ4TkRqTGcrM0E0R2RKVjV5Q1REL1BJ?=
 =?utf-8?B?ZTBibEt0eTRjSWVaMm0rS1NJVXpFMC9IS3IyVmRQZ0VwNm9QdVM0WDhNSjlG?=
 =?utf-8?B?K3E5dnBmdzBvMjJyeHZscjY3WjRsS2M0WTNFeW0za21QSi9TVVRSWWljd1cy?=
 =?utf-8?B?UGp4T3lqU1ZCYmpaMGovQjJnOXgzRzVuS2NVZVBFL0xac09TNWhNZU52NnRZ?=
 =?utf-8?B?M041MEpsMm1vYmtmOXNDUEhBVmdiblVpSE9iemxJUVVoQUhkM0I1R2U5VSt2?=
 =?utf-8?B?Z3BWRmNSejVUalFYdFBmWG1KVTZjWDhINHNGM0grYmlyVUJkVkFwcE5wNXZH?=
 =?utf-8?B?R1pIL3FBSjZ5R1lIR0pDOU9QcVFsL2QxOEh5VWdabVZIU2tXWTZLQTF1QnhX?=
 =?utf-8?B?MW5lSW1HTWZ5dlJXWFNxMDNzZ2EyYW1iRjZhSWpZMUxYYnFTakJIN2JYeGtp?=
 =?utf-8?B?S1JZVDhDS3FRQkFVRGVmUjUveVgyYldqOS9NWnJMN29GT3E1WE9Lb3dtVHBr?=
 =?utf-8?B?RjZQSFhZR0RVNXQxOGIvVUVQSmtnbWV1U3o1dm1kbkwyR1oyYUpoVHJzU3Y5?=
 =?utf-8?B?VXdxQy9za0RSc2dQOFpiaXF5dFFRZEg3ck8veTgvUzkzejJmeVlBNlNLSUxn?=
 =?utf-8?B?SlhKcFY3NmFHUEV5MG1OVnQ2aUhBZmFwNk50cHNGS1JOaEZkVDRXYTB6RDdC?=
 =?utf-8?B?bDhtUU9SdVYxR2haS3hyU0dEczZNWWIrN2Z6T0xuaDhqZENFa0JnZHk1bkZh?=
 =?utf-8?B?TkVzOHlFWHFIcEl4MWhmYjcyVVV5WjBkcEcwbS9sS3c1ck1uRml5Umpxa08y?=
 =?utf-8?B?aFZxaFdFN0ZHSkhLY0pIcEtBWWZGSjZLbTlnOUU2cFpJK1d4bk9JWGtCVkVF?=
 =?utf-8?B?QWVjTFMwcXRpZzZvdm5UQ1BSa3hvN2R3ZVZmYTlPdVU0VXE5SHdPejBhaklC?=
 =?utf-8?B?SmI2b3hpWU1meldOTnZmelJGOHNOVFhnNUVhbUc3TndyZTErZnpDZG9FanE4?=
 =?utf-8?Q?kc3Cs0mnRW1cXPFh2RM5M7JuY?=
X-MS-Exchange-CrossTenant-Network-Message-Id: eba17556-7a44-4366-1343-08daf4cbf361
X-MS-Exchange-CrossTenant-AuthSource: DM4PR11MB5262.namprd11.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 12 Jan 2023 18:36:42.7766
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 46c98d88-e344-4ed4-8496-4ed7712e255d
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: YjUnxWHGZ52CtrzRVwWtEanL4yGTrXVxtfhgEooE4HyWrxqeJC106gxpsmWMLldpF2H//+DDzy4TMk2qvxtpTg==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: SA0PR11MB4767
X-OriginatorOrg: intel.com
X-Spam-Status: No, score=-4.4 required=5.0 tests=BAYES_00,DKIMWL_WL_HIGH,
        DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,NICE_REPLY_A,
        RCVD_IN_DNSWL_MED,SPF_HELO_PASS,SPF_NONE autolearn=ham
        autolearn_force=no version=3.4.6
X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on
        lindbergh.monkeyblade.net
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org


On 1/11/2023 4:37 PM, Dave Hansen wrote:
> On 1/11/23 16:27, Chen, Yian wrote:
>>> It seems we are implicitly relying on the on stac() and clac()
>>> calls that are added for SMAP. Have you tried running with SMAP
>>> disabled i.e "clearcpuid=smap"?
>>>
>> Yes, I tested with clearcpuid=smap.
> It works by accident, then.
> 
> clearcpuid=smap means that the kernel should be running as if
> CPUID.(EAX=07H,ECX=0H):EBX.SMAP[bit 20]==0.  STAC/CLAC should #UD in
> that case.
> 
It could be something wrong in my Simics simulation environment.

> The only reason that it happens to work is that STAC/CLAC apparently
> actually continue to work even if CR4.SMAP==0.
> 
> I'm actually a _bit_ surprised by this, but I bet there's a good reason
> for it.
> 
> In any case, please just make LASS dependent on SMAP.  It's the right
> thing to do on several levels.
Sure, I will add the dependency.