Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Date:   Thu, 12 Jan 2023 20:03:10 +0100
From:   Greg KH <gregkh@linuxfoundation.org>
To:     Jakub Kicinski <kuba@kernel.org>
Cc:     linux-kernel@vger.kernel.org, pabeni@redhat.com,
        slipper.alive@gmail.com, stable-commits@vger.kernel.org
Subject: Re: Patch "net/ulp: prevent ULP without clone op from entering the
 LISTEN status" has been added to the 5.4-stable tree
Message-ID: <Y8BZboDOQ1I+VTAC@kroah.com>
References: <16735310493146@kroah.com>
 <Y8AP6Lqo9sfX9Bb8@kroah.com>
 <20230112105731.0da81d58@kernel.org>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <20230112105731.0da81d58@kernel.org>
Precedence: bulk

On Thu, Jan 12, 2023 at 10:57:31AM -0800, Jakub Kicinski wrote:
> On Thu, 12 Jan 2023 14:49:28 +0100 Greg KH wrote:
> > On Thu, Jan 12, 2023 at 02:44:09PM +0100, gregkh@linuxfoundation.org wrote:
> > > 
> > > This is a note to let you know that I've just added the patch titled
> > > 
> > >     net/ulp: prevent ULP without clone op from entering the LISTEN status
> > > 
> > > to the 5.4-stable tree which can be found at:
> > >     http://www.kernel.org/git/?p=linux/kernel/git/stable/stable-queue.git;a=summary  
> > 
> > Oops, nope, this broke the build for 5.4 and older kernels, now
> > dropping.
> 
> There's no clone op, right?

Correct.

> If you're willing to futz with it I think
> you just need to remove the "and the ops don't have ->clone" part of
> the conditions. Any presence of ops on older kernels should make us
> bail.

Ok, that should not be hard, I'll try messing with that tomorrow on the
train...

thanks,

greg k-h