Received: by 2002:a05:6358:a55:b0:ec:fcf4:3ecf with SMTP id 21csp755985rwb; Thu, 12 Jan 2023 11:54:47 -0800 (PST) X-Google-Smtp-Source: AMrXdXvuuufRHaGh5ZEBJg6z3O8uQioIs3SfiL8Et/hl2KRXi5GYmZqPKmygRzTLJz2A8/6mLqfW X-Received: by 2002:a17:90a:b296:b0:225:d9e7:2728 with SMTP id c22-20020a17090ab29600b00225d9e72728mr67740381pjr.33.1673553287383; Thu, 12 Jan 2023 11:54:47 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1673553287; cv=none; d=google.com; s=arc-20160816; b=QRm+hQY+u1E+SxD8KjOwLiLdM1q3rtg0FEc1jepb5PGjs7QLM2+z4i+PMErBVMIQE6 tEQXZTT0mk62gHayGm4koNaEv03MOBuErmLPmv4S4R40N2Kwf17U3wrCI0xcUBsQPyFt wUY3Bg+S5c9PsoOtbueEW9uYpmFKM5v1O08peFjKhhgG41VbcoxrnIIlYBn8dRH1OGIG 06Plkj1LhmofQOjNFm3rRh65XX0b3YwgSjeunZP3EVGhmp2Ct317IkSbrvuLOwUIptqm UfCm9zW35oxCguTl2e1srBtLgWXZhMg1kKJFhxynylotlZOCYPS9EpTzDN/nKIR98y7T JQcw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:in-reply-to:from :references:cc:to:content-language:subject:user-agent:mime-version :date:message-id:dkim-signature; bh=1JIYsMoXBydeWSn636wmG/Lb0+3KtaflCFgpsVqKASE=; b=Cg2Ztn+lSfg3yl7IWJjBSwc5CM4LbIafe+JZHu49D0DJOPDkBaQz9RrjFVrS/niQv8 i2916hYXv+ESQevCL79CPzIUqosxwXSjbycA20bQUBp08Ae1hbCdRjw7W7R0fcV5eat/ cR7dXAtdl3l7bapTNBAZTxtWWt8YVY1RQf0VDQVk2oMXyzufCsIZHF1jiUuIf/sqHmCO hd40cZFvwd8MHHn+lRpipxhNXGnhctl0y8/lb3pU8neGb7wOOkc6X5XQgLJm4XkcGvhd C1KU43n9a6vH4ee1uBB3iH3L9wo+OFUnR+Yhz/oInbj4saASx+80hA7lVxVdrIfj2y2I TW6Q== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@linaro.org header.s=google header.b="qbrF/2Qj"; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linaro.org Return-Path: Received: from out1.vger.email (out1.vger.email. [2620:137:e000::1:20]) by mx.google.com with ESMTP id li16-20020a17090b48d000b002199a16366csi17600652pjb.173.2023.01.12.11.54.39; Thu, 12 Jan 2023 11:54:47 -0800 (PST) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20; Authentication-Results: mx.google.com; dkim=pass header.i=@linaro.org header.s=google header.b="qbrF/2Qj"; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linaro.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S229867AbjALToL (ORCPT + 50 others); Thu, 12 Jan 2023 14:44:11 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:34542 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S231793AbjALTnv (ORCPT ); Thu, 12 Jan 2023 14:43:51 -0500 Received: from mail-lj1-x233.google.com (mail-lj1-x233.google.com [IPv6:2a00:1450:4864:20::233]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 027696422 for ; Thu, 12 Jan 2023 11:33:54 -0800 (PST) Received: by mail-lj1-x233.google.com with SMTP id e13so20475813ljn.0 for ; Thu, 12 Jan 2023 11:33:53 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=content-transfer-encoding:in-reply-to:from:references:cc:to :content-language:subject:user-agent:mime-version:date:message-id :from:to:cc:subject:date:message-id:reply-to; bh=1JIYsMoXBydeWSn636wmG/Lb0+3KtaflCFgpsVqKASE=; b=qbrF/2QjIGACx037/GJu0XQQcZ1Y3hPaMwOzChvkOLdToaTqaiN4h2QOJc9QgTq2i/ WDSgTjY9P/FNpiuJoM5wPVLAz9GT0a945L5MAGu42sDfYya0i7UbcDgXwt4flH7UPLfh 8xIk7FFcJLUy5HS1asOTzx6v1zrirnNfs8IJAZ9Sk65shK24W+/ucRe0EbRKntUhWULc v2P+3CoYAuOVzE+CI+Zks73+sD6up7ltZtXiAM+73xNuLMFlfBSfnNxW3MK2EIQO5vG7 c71f8rgNmCGMhusBMu6InU+O3AFVX7t+S8NzsIKAlgOBKKf5HDHzainln9Y0vcsEmU1q FCBw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=content-transfer-encoding:in-reply-to:from:references:cc:to :content-language:subject:user-agent:mime-version:date:message-id :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=1JIYsMoXBydeWSn636wmG/Lb0+3KtaflCFgpsVqKASE=; b=4ZCzibJYb/bU0wcZWUf5GsZi6cY647BjB5r6hDn19IrvomnSF5NHNs/fJK0v0c1KWB Tex+Cw/pW0iuzUDVbQqxlLT8RINsEhzpTTI+d7ZXGUJdW+YKyrkNtAWPO++70drK51b2 ypjYw2HRnTIRDaI05Yd/ErVbUHSjxxsNpp+gMlaXo7ipnhCPboYaZbGo+QeVdTxbg4bC 4BZahsvXrS3zbak/cCXZxpknSnM+NAn6civZqkkpQCyNTJ1shOzPGBwcXrdO2aiNdN1h DR3oJg4gm/akbCyUgrsoz9bNbTxQfe1CY1FVRHnGeQrrIpT6i/KecUqySRRaZs6g+h1p W/8A== X-Gm-Message-State: AFqh2koUueclCc0sHvRHeiintdofN4JblVgAkB79eduPZaSD1cY4uB33 fvIvT86F0AoPug0Y0Im6WUXm8g== X-Received: by 2002:a2e:80c9:0:b0:287:d8ce:6c9d with SMTP id r9-20020a2e80c9000000b00287d8ce6c9dmr2860076ljg.4.1673552032393; Thu, 12 Jan 2023 11:33:52 -0800 (PST) Received: from ?IPV6:2001:14ba:a085:4d00::8a5? (dzccz6yyyyyyyyyyybcwt-3.rev.dnainternet.fi. [2001:14ba:a085:4d00::8a5]) by smtp.gmail.com with ESMTPSA id v25-20020a2e87d9000000b00288470f3145sm906564ljj.36.2023.01.12.11.33.51 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Thu, 12 Jan 2023 11:33:52 -0800 (PST) Message-ID: Date: Thu, 12 Jan 2023 21:33:51 +0200 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.6.0 Subject: Re: [PATCH v3 2/3] phy: qcom-qmp-combo: Add config for SM6350 Content-Language: en-GB To: Vinod Koul , Johan Hovold Cc: Luca Weiss , linux-arm-msm@vger.kernel.org, ~postmarketos/upstreaming@lists.sr.ht, phone-devel@vger.kernel.org, Andy Gross , Bjorn Andersson , Konrad Dybcio , Kishon Vijay Abraham I , linux-phy@lists.infradead.org, linux-kernel@vger.kernel.org References: <20221130081430.67831-1-luca.weiss@fairphone.com> <20221130081430.67831-2-luca.weiss@fairphone.com> From: Dmitry Baryshkov In-Reply-To: Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit X-Spam-Status: No, score=-2.1 required=5.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,NICE_REPLY_A,RCVD_IN_DNSWL_NONE, SPF_HELO_NONE,SPF_PASS autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 12/01/2023 19:50, Vinod Koul wrote: > On 28-12-22, 15:17, Johan Hovold wrote: >> Luca, Vinod, >> >> On Wed, Nov 30, 2022 at 09:14:28AM +0100, Luca Weiss wrote: >>> Add the tables and config for the combo phy found on SM6350. >>> >>> Signed-off-by: Luca Weiss >>> --- >>> Changes since v2: >>> * Drop dp_txa/dp_txb changes, not required >>> * Fix dp_dp_phy offset >>> >>> drivers/phy/qualcomm/phy-qcom-qmp-combo.c | 126 ++++++++++++++++++++++ >>> 1 file changed, 126 insertions(+) >>> >>> diff --git a/drivers/phy/qualcomm/phy-qcom-qmp-combo.c b/drivers/phy/qualcomm/phy-qcom-qmp-combo.c >>> index 77052c66cf70..6ac0c68269dc 100644 >>> --- a/drivers/phy/qualcomm/phy-qcom-qmp-combo.c >>> +++ b/drivers/phy/qualcomm/phy-qcom-qmp-combo.c >> >>> @@ -975,6 +1039,19 @@ static const char * const sc7180_usb3phy_reset_l[] = { >>> "phy", >>> }; >>> >>> +static const struct qmp_combo_offsets qmp_combo_offsets_v3 = { >>> + .com = 0x0000, >>> + .txa = 0x1200, >>> + .rxa = 0x1400, >>> + .txb = 0x1600, >>> + .rxb = 0x1800, >>> + .usb3_serdes = 0x1000, >>> + .usb3_pcs_misc = 0x1a00, >>> + .usb3_pcs = 0x1c00, >>> + .dp_serdes = 0x1000, >> >> I would have expected this to be 0x2000 as that's what the older >> platforms have been using for the dp serdes table so far. Without access >> to any documentation it's hard to tell whether everyone's just been >> cargo-culting all along or if there's actually something there at offset >> 0x2000. usb3_serdes is 0x1000, so dp_serdes equal to 0x1000 is definitely an typo. Judging from the downstream dtsi, the DP PHY starts at offset 0x2000. So dp_serdes is equal to 0x2000, dp_phy = 0x2a00, ln_tx1 = 0x2200, ln_tx2 = 0x2600. >> >> Vinod, could you shed some light on this as presumably you have access >> to some documentation? >> >>> + .dp_dp_phy = 0x2a00, > > No sorry, I dont have access to this version... > -- With best wishes Dmitry