Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
References: <20230112184823.80349-1-andriy.shevchenko@linux.intel.com>
 <20230112184823.80349-2-andriy.shevchenko@linux.intel.com>
User-agent: mu4e 1.8.10; emacs 28.2
From:   Baruch Siach <baruch@tkos.co.il>
To:     Andy Shevchenko <andriy.shevchenko@linux.intel.com>
Cc:     Linus Walleij <linus.walleij@linaro.org>,
        Jianlong Huang <jianlong.huang@starfivetech.com>,
        linux-gpio@vger.kernel.org, linux-kernel@vger.kernel.org,
        linux-arm-kernel@lists.infradead.org
Subject: Re: [PATCH v1 2/2] pinctrl: digicolor: Use proper headers and drop
 OF dependency
Date:   Thu, 12 Jan 2023 21:30:46 +0200
In-reply-to: <20230112184823.80349-2-andriy.shevchenko@linux.intel.com>
Message-ID: <87v8lbpn24.fsf@tarshish>
MIME-Version: 1.0
Content-Type: text/plain
Precedence: bulk

Hi Andy,

On Thu, Jan 12 2023, Andy Shevchenko wrote:

> The driver doesn't depend on the OF to be complied. Hence
> the proper header to use is mod_devicetable.h. Replace of*.h with
> the above mentioned and drop redundant dependency.
>
> Signed-off-by: Andy Shevchenko <andriy.shevchenko@linux.intel.com>

Acked-by: Baruch Siach <baruch@tkos.co.il>

baruch

> ---
>  drivers/pinctrl/Kconfig             | 2 +-
>  drivers/pinctrl/pinctrl-digicolor.c | 9 +++++----
>  2 files changed, 6 insertions(+), 5 deletions(-)
>
> diff --git a/drivers/pinctrl/Kconfig b/drivers/pinctrl/Kconfig
> index 476f3cbbdce0..1e44708201ad 100644
> --- a/drivers/pinctrl/Kconfig
> +++ b/drivers/pinctrl/Kconfig
> @@ -170,7 +170,7 @@ config PINCTRL_DA9062
>  
>  config PINCTRL_DIGICOLOR
>  	bool
> -	depends on OF && (ARCH_DIGICOLOR || COMPILE_TEST)
> +	depends on ARCH_DIGICOLOR || COMPILE_TEST
>  	select PINMUX
>  	select GENERIC_PINCONF
>  
> diff --git a/drivers/pinctrl/pinctrl-digicolor.c b/drivers/pinctrl/pinctrl-digicolor.c
> index 05213261b8a4..a0423172bdd6 100644
> --- a/drivers/pinctrl/pinctrl-digicolor.c
> +++ b/drivers/pinctrl/pinctrl-digicolor.c
> @@ -11,18 +11,19 @@
>   * - Pin pad configuration (pull up/down, strength)
>   */
>  
> +#include <linux/gpio/driver.h>
>  #include <linux/init.h>
> -#include <linux/platform_device.h>
> -#include <linux/of.h>
> -#include <linux/of_device.h>
>  #include <linux/io.h>
> -#include <linux/gpio/driver.h>
> +#include <linux/mod_devicetable.h>
> +#include <linux/platform_device.h>
>  #include <linux/spinlock.h>
> +
>  #include <linux/pinctrl/machine.h>
>  #include <linux/pinctrl/pinconf.h>
>  #include <linux/pinctrl/pinconf-generic.h>
>  #include <linux/pinctrl/pinctrl.h>
>  #include <linux/pinctrl/pinmux.h>
> +
>  #include "pinctrl-utils.h"
>  
>  #define DRIVER_NAME	"pinctrl-digicolor"


-- 
                                                     ~. .~   Tk Open Systems
=}------------------------------------------------ooO--U--Ooo------------{=
   - baruch@tkos.co.il - tel: +972.52.368.4656, http://www.tkos.co.il -