Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
MIME-Version: 1.0
References: <20230106005951.100479-1-yang.lee@linux.alibaba.com> <057bd9fa05f1bfdf10858f23506856f6376c9f8f.camel@intel.com>
In-Reply-To: <057bd9fa05f1bfdf10858f23506856f6376c9f8f.camel@intel.com>
From:   "Rafael J. Wysocki" <rafael@kernel.org>
Date:   Thu, 12 Jan 2023 20:23:15 +0100
Message-ID: <CAJZ5v0hjACvmP8fytYWMEa-p4F8aix4O3PZ_jxrEedz3etwKZA@mail.gmail.com>
Subject: Re: [PATCH -next] thermal: Fix unsigned comparison with less than zero
To:     "Zhang, Rui" <rui.zhang@intel.com>,
        "yang.lee@linux.alibaba.com" <yang.lee@linux.alibaba.com>
Cc:     "rafael@kernel.org" <rafael@kernel.org>,
        "linux-pm@vger.kernel.org" <linux-pm@vger.kernel.org>,
        "daniel.lezcano@linaro.org" <daniel.lezcano@linaro.org>,
        "linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
        "amitk@kernel.org" <amitk@kernel.org>,
        "abaci@linux.alibaba.com" <abaci@linux.alibaba.com>
Content-Type: text/plain; charset="UTF-8"
Precedence: bulk

On Fri, Jan 6, 2023 at 8:03 AM Zhang, Rui <rui.zhang@intel.com> wrote:
>
> On Fri, 2023-01-06 at 08:59 +0800, Yang Li wrote:
> > The return value from the call to intel_tcc_get_tjmax() is int, which
> > can
> > be a negative error code. However, the return value is being assigned
> > to
> > an u32 variable 'tj_max', so making 'tj_max' an int.
> >
> > Eliminate the following warning:
> > ./drivers/thermal/intel/intel_soc_dts_iosf.c:394:5-11: WARNING:
> > Unsigned expression compared with zero: tj_max < 0
> >
> > Link: https://bugzilla.openanolis.cn/show_bug.cgi?id=3637
> > Reported-by: Abaci Robot <abaci@linux.alibaba.com>
> > Signed-off-by: Yang Li <yang.lee@linux.alibaba.com>
>
> Thanks for catching this issue.
>
> Acked-by: Zhang Rui <rui.zhang@intel.com>

Applied, thanks!

> > ---
> >  drivers/thermal/intel/intel_soc_dts_iosf.c | 2 +-
> >  1 file changed, 1 insertion(+), 1 deletion(-)
> >
> > diff --git a/drivers/thermal/intel/intel_soc_dts_iosf.c
> > b/drivers/thermal/intel/intel_soc_dts_iosf.c
> > index 2138693d8afd..8c26f7b2316b 100644
> > --- a/drivers/thermal/intel/intel_soc_dts_iosf.c
> > +++ b/drivers/thermal/intel/intel_soc_dts_iosf.c
> > @@ -380,7 +380,7 @@ struct intel_soc_dts_sensors
> > *intel_soc_dts_iosf_init(
> >  {
> >       struct intel_soc_dts_sensors *sensors;
> >       bool notification;
> > -     u32 tj_max;
> > +     int tj_max;
> >       int ret;
> >       int i;
> >