Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
References: <20230112184823.80349-1-andriy.shevchenko@linux.intel.com>
User-agent: mu4e 1.8.10; emacs 28.2
From:   Baruch Siach <baruch@tkos.co.il>
To:     Andy Shevchenko <andriy.shevchenko@linux.intel.com>
Cc:     Linus Walleij <linus.walleij@linaro.org>,
        Jianlong Huang <jianlong.huang@starfivetech.com>,
        linux-gpio@vger.kernel.org, linux-kernel@vger.kernel.org,
        linux-arm-kernel@lists.infradead.org
Subject: Re: [PATCH v1 1/2] pinctrl: digicolor: Remove duplicate assignment
 of of_gpio_n_cells
Date:   Thu, 12 Jan 2023 21:28:16 +0200
In-reply-to: <20230112184823.80349-1-andriy.shevchenko@linux.intel.com>
Message-ID: <87zganpn69.fsf@tarshish>
MIME-Version: 1.0
Content-Type: text/plain
Precedence: bulk

Hi Andy,

On Thu, Jan 12 2023, Andy Shevchenko wrote:

> The of_gpio_n_cells default is 2 when ->of_xlate() callback is
> not defined. No need to assign it explicitly in the driver.
>
> Signed-off-by: Andy Shevchenko <andriy.shevchenko@linux.intel.com>

Acked-by: Baruch Siach <baruch@tkos.co.il>

baruch

> ---
>  drivers/pinctrl/pinctrl-digicolor.c | 1 -
>  1 file changed, 1 deletion(-)
>
> diff --git a/drivers/pinctrl/pinctrl-digicolor.c b/drivers/pinctrl/pinctrl-digicolor.c
> index cc3546fc4610..05213261b8a4 100644
> --- a/drivers/pinctrl/pinctrl-digicolor.c
> +++ b/drivers/pinctrl/pinctrl-digicolor.c
> @@ -248,7 +248,6 @@ static int dc_gpiochip_add(struct dc_pinmap *pmap)
>  	chip->set		= dc_gpio_set;
>  	chip->base		= -1;
>  	chip->ngpio		= PINS_COUNT;
> -	chip->of_gpio_n_cells	= 2;
>  
>  	spin_lock_init(&pmap->lock);


-- 
                                                     ~. .~   Tk Open Systems
=}------------------------------------------------ooO--U--Ooo------------{=
   - baruch@tkos.co.il - tel: +972.52.368.4656, http://www.tkos.co.il -