Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S932770AbXHVUFe (ORCPT ); Wed, 22 Aug 2007 16:05:34 -0400 Received: (majordomo@vger.kernel.org) by vger.kernel.org id S932670AbXHVUFP (ORCPT ); Wed, 22 Aug 2007 16:05:15 -0400 Received: from mu-out-0910.google.com ([209.85.134.185]:65237 "EHLO mu-out-0910.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S932237AbXHVUFM (ORCPT ); Wed, 22 Aug 2007 16:05:12 -0400 DomainKey-Signature: a=rsa-sha1; c=nofws; d=gmail.com; s=beta; h=received:to:subject:date:user-agent:cc:references:in-reply-to:mime-version:content-type:content-transfer-encoding:content-disposition:message-id:from; b=jfuraMYXnJVJVIarHBFIuOdsm4OXro3mVoItPmvfQTt3yiUyrrKBTHMlhYS/QXMYxl30Y6lOE1FyF1mTF3Bio1gH5YvToCFuNaMF2VOyPctgUU4Fsqpj91IZnehrs+d+vHFXH6KQ/tTA10C9FNhV+EPqZ58k6+cbnAcQ82+3tf4= To: Mariusz Kozlowski Subject: Re: 2.6.23-rc3-mm1: net/wireless/rt2x00mac.c build failure Date: Wed, 22 Aug 2007 22:12:52 +0200 User-Agent: KMail/1.9.7 Cc: John Linville , Andrew Morton , linux-kernel@vger.kernel.org, linux-wireless@vger.kernel.org References: <20070822020648.5ea3a612.akpm@linux-foundation.org> <200708222131.24882.IvDoorn@gmail.com> <200708222154.03663.m.kozlowski@tuxland.pl> In-Reply-To: <200708222154.03663.m.kozlowski@tuxland.pl> MIME-Version: 1.0 Content-Type: text/plain; charset="iso-8859-15" Content-Transfer-Encoding: 7bit Content-Disposition: inline Message-Id: <200708222212.52805.IvDoorn@gmail.com> From: Ivo van Doorn Sender: linux-kernel-owner@vger.kernel.org X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 2179 Lines: 39 Hi, > CC [M] drivers/net/wireless/zd1211rw-mac80211/zd_mac.o > drivers/net/wireless/zd1211rw-mac80211/zd_mac.c: In function `zd_op_erp_ie_changed': > drivers/net/wireless/zd1211rw-mac80211/zd_mac.c:822: error: `IEEE80211_ERP_CHANGE_PREAMBLE' undeclared (first use in this function) > drivers/net/wireless/zd1211rw-mac80211/zd_mac.c:822: error: (Each undeclared identifier is reported only once > drivers/net/wireless/zd1211rw-mac80211/zd_mac.c:822: error: for each function it appears in.) > drivers/net/wireless/zd1211rw-mac80211/zd_mac.c: At top level: > drivers/net/wireless/zd1211rw-mac80211/zd_mac.c:844: error: unknown field `erp_ie_changed' specified in initializer > drivers/net/wireless/zd1211rw-mac80211/zd_mac.c:844: warning: initialization from incompatible pointer type > make[4]: *** [drivers/net/wireless/zd1211rw-mac80211/zd_mac.o] Error 1 > make[3]: *** [drivers/net/wireless/zd1211rw-mac80211] Error 2 > make[2]: *** [drivers/net/wireless] Error 2 > make[1]: *** [drivers/net] Error 2 > make: *** [drivers] Error 2 I'm not a zd1211rw developer, but a quick look into the patch series it seems that the mac80211 version in -mm1 does not contain the patch [PATCH 4/4] mac80211: implement ERP info change notifications But it does contain the zd1211rw patch: [PATCH] zd1211rw-mac80211: use correct preambles for RTS/CTS frames Which depended on the above mentioned mac80211 patch. Just had a second thought about those rt2x00 compilation errors you reported, the error is not caused by rt2x00 lagging behind mac80211 api changes but that rt2x00 patches to follow the api changes are going upstream but the mac80211 api changes it depends on are not going anywhere. It seems that mac80211 has not been updated in the -mm tree while the drivers have been updated. This is causing the compilation errors for both rt2x00 as zd1211rw. I'll bet that if you try any other mac80211 driver similar issues will arise. Ivo - To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/