Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Date:   Thu, 12 Jan 2023 19:50:32 +0000
From:   Mark Brown <broonie@kernel.org>
To:     Pierre-Louis Bossart <pierre-louis.bossart@linux.intel.com>
Cc:     Charles Keepax <ckeepax@opensource.cirrus.com>, vkoul@kernel.org,
        yung-chuan.liao@linux.intel.com, sanyog.r.kale@intel.com,
        linux-kernel@vger.kernel.org, patches@opensource.cirrus.com
Subject: Re: [PATCH 2/2] regmap: sdw: Remove 8-bit value size restriction
Message-ID: <Y8BkiF8sfqPifYTO@sirena.org.uk>
References: <20230112171840.2098463-1-ckeepax@opensource.cirrus.com>
 <20230112171840.2098463-3-ckeepax@opensource.cirrus.com>
 <756fcb2d-d571-18cb-985e-d907ab682275@linux.intel.com>
 <Y8BOCpXyOyF3igfG@sirena.org.uk>
 <3320e6b8-28c7-d028-3c4c-2b4b25a963fb@linux.intel.com>
MIME-Version: 1.0
Content-Type: multipart/signed; micalg=pgp-sha512;
        protocol="application/pgp-signature"; boundary="kdxHzIo+lmpm7kNT"
Content-Disposition: inline
In-Reply-To: <3320e6b8-28c7-d028-3c4c-2b4b25a963fb@linux.intel.com>
Precedence: bulk


--kdxHzIo+lmpm7kNT
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline

On Thu, Jan 12, 2023 at 12:43:46PM -0600, Pierre-Louis Bossart wrote:
> On 1/12/23 12:14, Mark Brown wrote:

> > The regmap gather_write() operation allows the bus to take two buffers,
> > one for the register and one for the value, rather than requiring the
> > core combine everything into a single buffer (mainly useful for large
> > transfers like firmware downloads).

> Right, but that's not supported in SoundWire. sdw_nwrite() will only
> work with consecutive addresses - and the auto-increment is handled in
> software, not hardware.

No, that's exactly what this is for.  It's for the *register address*
being in a separate buffer, the data is then a sequence of consecutive
register values.

> What's suggested here is to use the first element of reg_buf, which begs
> the question how different this is from a regular write. If there was a
> discontinuity in reg_buf then this wouldn't work at all.

reg_buf contains the address of exactly one register.

--kdxHzIo+lmpm7kNT
Content-Type: application/pgp-signature; name="signature.asc"

-----BEGIN PGP SIGNATURE-----

iQEzBAABCgAdFiEEreZoqmdXGLWf4p/qJNaLcl1Uh9AFAmPAZIcACgkQJNaLcl1U
h9A1Ngf+KIeT4cHA1t0heeIsCmRspEmUq1LpG69jvzpevaJxWp+UwyYexAhb6Ny5
W9E0VwV/kxd+cRCvATjFbJstHICBBYZ91FHf5Vm02aO0howOio6qdunk1lYPz9X/
IT4T80yD+QF7bZD+lr7znfbStVp1ORQtJJl7BtjtFKZobLWz9KWVCLSDLd6acMRF
MZ+uKsKleQG4R9hWRRzfS7KvZ2epfgjV0GPMHm5/OM2iXLMZdsapHehN2AyfLJVm
bQSAw5Zq3Otqg6WjpaZewK/t1qJYEihF7eHghETSiNPez7+qUxRPdFjNkLRy9uPP
I5c0ZW80V6UYUcMKcrXdeCUzpZU6lQ==
=TNuV
-----END PGP SIGNATURE-----

--kdxHzIo+lmpm7kNT--