Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Date:   Thu, 12 Jan 2023 22:30:15 +0100
From:   Uwe =?utf-8?Q?Kleine-K=C3=B6nig?= <u.kleine-koenig@pengutronix.de>
To:     Mubin Sayyed <mubin.sayyed@amd.com>
Cc:     robh+dt@kernel.org, treding@nvidia.com, linux-pwm@vger.kernel.org,
        devicetree@vger.kernel.org, linux-arm-kernel@lists.infradead.org,
        linux-kernel@vger.kernel.org, git@amd.com, michal.simek@amd.com,
        siva.durga.prasad.paladugu@amd.com, mubin10@gmail.com
Subject: Re: [LINUX PATCH 1/3] clocksource: timer-cadence-ttc: Do not probe
 TTC device configured as PWM
Message-ID: <20230112213015.sw5uxirsrltx3pih@pengutronix.de>
References: <20230112071526.3035949-1-mubin.sayyed@amd.com>
 <20230112071526.3035949-2-mubin.sayyed@amd.com>
MIME-Version: 1.0
Content-Type: multipart/signed; micalg=pgp-sha512;
        protocol="application/pgp-signature"; boundary="7qvaaxqaocpm7pj5"
Content-Disposition: inline
In-Reply-To: <20230112071526.3035949-2-mubin.sayyed@amd.com>
Precedence: bulk


--7qvaaxqaocpm7pj5
Content-Type: text/plain; charset=iso-8859-1
Content-Disposition: inline
Content-Transfer-Encoding: quoted-printable

On Thu, Jan 12, 2023 at 12:45:24PM +0530, Mubin Sayyed wrote:
> TTC device can act either as clocksource/clockevent or
> PWM generator, it would be decided by pwm-cells property.
> TTC PWM feature would be supported through separate driver
> based on PWM framework.
>=20
> If pwm-cells property is present in TTC node, it would be
> treated as PWM device, and clocksource driver should just
> skip it.
>=20
> Signed-off-by: Mubin Sayyed <mubin.sayyed@amd.com>
> ---
>  drivers/clocksource/timer-cadence-ttc.c | 3 +++
>  1 file changed, 3 insertions(+)
>=20
> diff --git a/drivers/clocksource/timer-cadence-ttc.c b/drivers/clocksourc=
e/timer-cadence-ttc.c
> index 4efd0cf3b602..ba46649148b1 100644
> --- a/drivers/clocksource/timer-cadence-ttc.c
> +++ b/drivers/clocksource/timer-cadence-ttc.c
> @@ -476,6 +476,9 @@ static int __init ttc_timer_probe(struct platform_dev=
ice *pdev)
>  	u32 timer_width =3D 16;
>  	struct device_node *timer =3D pdev->dev.of_node;
> =20
While it's more obvious here than in the PWM driver, a comment here
would be good, too.

> +	if (of_property_read_bool(timer, "#pwm-cells"))
> +		return -ENODEV;
> +
>  	if (initialized)
>  		return 0;
> =20
> --=20
> 2.25.1
>=20
>=20

--=20
Pengutronix e.K.                           | Uwe Kleine-K=F6nig            |
Industrial Linux Solutions                 | https://www.pengutronix.de/ |

--7qvaaxqaocpm7pj5
Content-Type: application/pgp-signature; name="signature.asc"

-----BEGIN PGP SIGNATURE-----

iQEzBAABCgAdFiEEfnIqFpAYrP8+dKQLwfwUeK3K7AkFAmPAe+QACgkQwfwUeK3K
7AkUDgf+KIetGF0gWW6g8OkoyM38lCShOVsRVSiy1HszSnswoz5btFRoyngs9aMs
5GH9zt8BePcWiCzgm4uF2GWrz7221Us2orfw+FUf+44Dd5PvHFisuFT4l8rcxgui
Q79H9PmsAigq5fH+fq8sVNLKGQqNbm4B5QfDBUDFknR5VU30PZwUMW0XgQ3zkcr6
K6EoWKslmdEaHP7b5nBHRBeZll0PXnGnMwEaYgqcpLVnXl6uODCmVRi2RKLR0xAC
boUHFwuHy8qxAw+eJYhkN6j/fJ8rSDfoa/TeO9mfAibdDIZeef+j8J6UipWSqO2F
6vu68mcg2tSe56AlF7ITbg0uX8Qp3A==
=e7Bd
-----END PGP SIGNATURE-----

--7qvaaxqaocpm7pj5--