Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Message-ID: <f6d16f82-9cbe-993d-88aa-1644e89c4fe7@intel.com>
Date:   Thu, 12 Jan 2023 17:17:53 -0800
User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:102.0) Gecko/20100101
 Thunderbird/102.6.1
Subject: Re: [PATCH 5/7] x86/cpu: Enable LASS (Linear Address Space
 Separation)
Content-Language: en-US
To:     Dave Hansen <dave.hansen@intel.com>,
        Yian Chen <yian.chen@intel.com>,
        <linux-kernel@vger.kernel.org>, <x86@kernel.org>,
        Andy Lutomirski <luto@kernel.org>,
        Dave Hansen <dave.hansen@linux.intel.com>,
        Ravi Shankar <ravi.v.shankar@intel.com>,
        Tony Luck <tony.luck@intel.com>,
        Paul Lai <paul.c.lai@intel.com>
References: <20230110055204.3227669-1-yian.chen@intel.com>
 <20230110055204.3227669-6-yian.chen@intel.com>
 <7e859e72-4624-73c7-8195-c252ace0a49d@intel.com>
From:   Sohil Mehta <sohil.mehta@intel.com>
In-Reply-To: <7e859e72-4624-73c7-8195-c252ace0a49d@intel.com>
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: 7bit
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?bzlBVHdWTWViZEFRVkN6MzRIYi9RMVh5RGF4NEY0RlErdld0YXB6OUFEYk9t?=
 =?utf-8?B?R1VYZHpRU0w1Mm4wQ2ppTE41UGM4RWhRRFFaUmp4VlJHUjJBaUZwOW5zSWo1?=
 =?utf-8?B?cFFWNGV4SVo4TU05SHVaTStBVDFYNERpS2ZUWXhGWkxpQlhVdkQzMEZZdzhI?=
 =?utf-8?B?UVdTei93MHhzR1VyWVZOSTUzRDloWXRTQmZKRHBGQnljRDgzK3UyUVhMWklB?=
 =?utf-8?B?WHhNeVpkSDExK241ak5uNHdNZGZzQ1R4eS9ZeW42L0dGQWVha1lzNkRHYzNN?=
 =?utf-8?B?cHBuOHExSEdyaGxCODVMKytMN080Q3JSVk9LeDFqKzFsNGtNVHgzcUNicnFq?=
 =?utf-8?B?cHkrek5YL25TNDZJN2I0bDQ0cFliazFWLzZoUDZTU3ZyY2h3K1ZpREp2YnVh?=
 =?utf-8?B?bUEwUUR3cEJGSW4wNEhqNjFpWlo0cDdOUkk4dTRYNXd5NnREYU45Rmc4U2d6?=
 =?utf-8?B?YVlGYkFrK0FYZlYvNHQxVENwQ1paTUJ6OFpja1U3cGowUThxK0E1bkkxRitm?=
 =?utf-8?B?RGN2Qnc4OCtIa3I0M3p4eFRraE1ieCtZWmd5bk1GYzNmc1l6MER1ODFsek9l?=
 =?utf-8?B?SW9oRG1OZm9HcSswRjkwbGJZZlUzWXZDNzZhNFNScWpNdmNJQ1lqVmY0MFlT?=
 =?utf-8?B?OElsVzNsQW5qanNwazRNMkZMR1ZrSlQweU9YOEk3UkZNdFkrMHFjQjNTSzR3?=
 =?utf-8?B?Vm95TDlrZ2UyMm8wc3BXVkIrb1E4Q0pDZzlOZW1kR0dFeFZUeWFVbm1iK0Nj?=
 =?utf-8?B?RWVhclNyWVh3eXFtRXZOM1NybFVjZm9lTWIvTmlxRGJPQk5SRytrT2dNTmhC?=
 =?utf-8?B?YUJ5TU9JYVpMU2dRN0cxUXpnK2hjU1pGdFliZkc0dTZVSlhwZFRMZHRLV3V4?=
 =?utf-8?B?QjRjM25sUUs1czc1VVYrRFdCU1RBR3hkSEVLRUFWVDFicWk3WC9PMmZjYWY3?=
 =?utf-8?B?dUZXQnVTRmY5VlRvbmlwOUVQZnEwbDFRT3Z1YTlTSmtKV21pVFFIc3AzbXpW?=
 =?utf-8?B?d2JLZnYwRXZ0WklvTG1rUk0rZnBoUmxvelkxY2ZJbkFPamM5SkZXWkN4UGhC?=
 =?utf-8?B?ZkRkenkzb3A1a2xFTms3NVlsRDh6b3pXUEIrZWJlRmJnQWxPcmx1WjVOSGo1?=
 =?utf-8?B?NzBIbk9iZ3I0MGhZbTVxeGZIcHFsTW8yNi9QdndRRi9VMmpNeEFQVU5ETTA5?=
 =?utf-8?B?by9PNWtJaWlmMWVsNE5ldU1yemt4U0VGUFJ5UCt1ZnJ2by81cDFTMmhkZVNR?=
 =?utf-8?B?VEVMdVRZanUxY3hVa29mLzhLcS81SGNCdEJDMmc0dTJGR2V6RW5CZHdlbUZj?=
 =?utf-8?B?NUNTRGtTSVkyK0ZmaGswcU5XWS9HTE0wU1ZTV1Z2cW9yUDE1NDZYTzBLVUhY?=
 =?utf-8?B?L2JSellyVzBLRnBRVnZvVkMxVUx2enFjSXhLZnFTRitqRWxkVEQraUZIUVlN?=
 =?utf-8?B?WFVjNWVYTFJyeERTNHB1Q3BsdTZpNVhRZkxlT29LUGF4NHNRRTNJdVVhZUQ3?=
 =?utf-8?B?K0x1NFhHdm5JM1RZZXVqQjErMnlwUXJsOFRIcmFrNGxSNFA3cW92VFZLeEcz?=
 =?utf-8?B?V3hwU2h3bXlaN3Z4OWV4SXJMQjZFTHpCdWlTRVpZMFZ3cWYxUjhYSFhIVjI4?=
 =?utf-8?B?QWUrRE5xK2RjaU9rZWlSQ1VlR0ZtV00zMGV4V0llRU9xcEN4aDl2UjFqWXpo?=
 =?utf-8?B?V0RBU05mNmdRZk1LcGx4cm02ajFNRisxejNtUFk0aUxVQzJxQU5LZXhMUEx4?=
 =?utf-8?B?N0E5MEFTY3AxWmtCNWVhekdnSEVXZTh5eHdVOWpocGpiYkJUSFRnZjBKTWdY?=
 =?utf-8?B?WWt6N2wzUVk3SHZFMENvM3loOElxYmVML3ZnL3lHcEtvKzJFbEVBcWNTWFlC?=
 =?utf-8?B?YzlpekhMMzhOL0o0NnZabGkweXRnd2o4eTIrWi9GUDRhZHZIVG9PS05rQTRl?=
 =?utf-8?B?M09uTXQyY2w2eTZNcmtxQkhEQ1oycmFld0pBa1ExZmhWdnVHeXVYcVNYMUJE?=
 =?utf-8?B?NGQwQnNwcEFYKyswUEc3S0hTcWNOZU9iUXcveW5BQ041VWdnOVZrb3RKTENY?=
 =?utf-8?B?Yk1tb1FkRHdBTStXSlp4NEJGSXYxekRrUXRuTVZFYmJyZXQxbXQ1bjhxWVJh?=
 =?utf-8?Q?uhFxvl8eElxeBRL6XfsUttQfk?=
X-MS-Exchange-CrossTenant-Network-Message-Id: 8d108fe1-3231-4ce1-b448-08daf503ff98
X-MS-Exchange-CrossTenant-AuthSource: BYAPR11MB3320.namprd11.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 13 Jan 2023 01:17:54.9969
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 46c98d88-e344-4ed4-8496-4ed7712e255d
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: Ag/OYeR7SKRkhSiPE7SDzuYFfHaOAQNQ3gzi+9vaOaDHPn9qk59NZT5oADRZt5APEGMHjDckthEc6x1FG9jO3g==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: DS7PR11MB6149
X-OriginatorOrg: intel.com
X-Spam-Status: No, score=-4.4 required=5.0 tests=BAYES_00,DKIMWL_WL_HIGH,
        DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,NICE_REPLY_A,
        RCVD_IN_DNSWL_MED,SPF_HELO_NONE,SPF_NONE autolearn=ham
        autolearn_force=no version=3.4.6
X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on
        lindbergh.monkeyblade.net
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

On 1/12/2023 10:17 AM, Dave Hansen wrote:

> In the end, want X86_CR4_LASS set when the kernel wants LASS and clear
> in *ALL* other cases.  That would be simply:
> 
> 	if (cpu_feature_enabled(X86_FEATURE_LASS)) {
> 		cr4_set_bits(X86_CR4_LASS);
> 	} else {
> 		cr4_clear_bits(X86_CR4_LASS);
> 	}
> 

Thanks for the explanation. This is very helpful.

> I'm also wondering if we even want a Kconfig option.  Is anyone
> realistically going to be compiling this support out?

I was initially thinking we should leave the Kconfig option for users
that really *need* vsyscall support. But, thinking about it more, we
don't need an LASS Kconfig option for that.

We can make CONFIG_LEGACY_VSYSCALL_NONE as the default instead of the
current CONFIG_LEGACY_VSYSCALL_XONLY. The kernel can disable LASS at
boot time if a user/admin has shown explicit preference by selecting
CONFIG_LEGACY_VSYSCALL_XONLY or by providing command line parameter
vsyscall=xonly/emulate.

Thoughts?