Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
MIME-Version: 1.0
References: <20230110233056.3490942-1-michael@walle.cc> <167357352392.592020.6790951746345716129.robh@kernel.org>
In-Reply-To: <167357352392.592020.6790951746345716129.robh@kernel.org>
From:   Rob Herring <robh+dt@kernel.org>
Date:   Thu, 12 Jan 2023 19:33:52 -0600
Message-ID: <CAL_JsqLN0jd0nT7rC7SBMh2zLsAvGCafknnS_oqJJj+=c1m9pg@mail.gmail.com>
Subject: Re: [PATCH] of: property: fix #nvmem-cell-cells parsing
To:     Michael Walle <michael@walle.cc>
Cc:     Robert Marko <robimarko@gmail.com>,
        Frank Rowand <frowand.list@gmail.com>,
        Peng Fan <peng.fan@nxp.com>,
        Miquel Raynal <miquel.raynal@bootlin.com>,
        Alexander Stein <alexander.stein@ew.tq-group.com>,
        devicetree@vger.kernel.org,
        Srinivas Kandagatla <srinivas.kandagatla@linaro.org>,
        linux-kernel@vger.kernel.org, Aisheng Dong <aisheng.dong@nxp.com>
Content-Type: text/plain; charset="UTF-8"
Precedence: bulk

On Thu, Jan 12, 2023 at 7:32 PM Rob Herring <robh@kernel.org> wrote:
>
>
> On Wed, 11 Jan 2023 00:30:56 +0100, Michael Walle wrote:
> > Commit 67b8497f005f ("of: property: make #.*-cells optional for simple
> > props") claims to make the cells-name property optional for simple
> > properties, but changed the code for the wrong property, i.e. for
> > DEFINE_SUFFIX_PROP(). Fix that.
> >
> > Fixes: 67b8497f005f ("of: property: make #.*-cells optional for simple props")
> > Reported-by: Peng Fan <peng.fan@nxp.com>
> > Signed-off-by: Michael Walle <michael@walle.cc>
> > Tested-by: Robert Marko <robimarko@gmail.com>
> > ---
> >  drivers/of/property.c | 8 ++++----
> >  1 file changed, 4 insertions(+), 4 deletions(-)
> >
>
> Applied, thanks!

Or not. 67b8497f005f is not in my tree, so

Acked-by: Rob Herring <robh@kernel.org>