Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Message-ID: <3ae3f5d2-1b58-7498-656d-696182a3589f@linux.intel.com>
Date:   Fri, 13 Jan 2023 09:56:17 +0800
MIME-Version: 1.0
User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:102.0) Gecko/20100101
 Thunderbird/102.6.1
Cc:     baolu.lu@linux.intel.com, Jason Gunthorpe <jgg@nvidia.com>,
        Bjorn Helgaas <bhelgaas@google.com>,
        Joerg Roedel <jroedel@suse.de>,
        =?UTF-8?Q?Christian_K=c3=b6nig?= <christian.koenig@amd.com>,
        Kevin Tian <kevin.tian@intel.com>,
        Vasant Hegde <vasant.hegde@amd.com>,
        Tony Zhu <tony.zhu@intel.com>, linux-pci@vger.kernel.org,
        iommu@lists.linux.dev, linux-kernel@vger.kernel.org,
        Matt Fagnani <matt.fagnani@bell.net>
Subject: Re: [PATCH 1/1] PCI: Add translated request only opt-in for
 pci_enable_pasid()
To:     Bjorn Helgaas <helgaas@kernel.org>
References: <20230112183422.GA1778973@bhelgaas>
Content-Language: en-US
From:   Baolu Lu <baolu.lu@linux.intel.com>
In-Reply-To: <20230112183422.GA1778973@bhelgaas>
Content-Type: text/plain; charset=UTF-8; format=flowed
Content-Transfer-Encoding: 7bit
Precedence: bulk

On 2023/1/13 2:34, Bjorn Helgaas wrote:
> On Thu, Jan 12, 2023 at 09:25:25PM +0800, Baolu Lu wrote:
>> On 2023/1/12 20:38, Jason Gunthorpe wrote:
>>> On Thu, Jan 12, 2023 at 04:46:29PM +0800, Lu Baolu wrote:
>>>
>>>> -int pci_enable_pasid(struct pci_dev *pdev, int features);
>>>> +int pci_enable_pasid(struct pci_dev *pdev, int features, bool
>>>> transled_only);
>        ^^^^^^^^
> 
>> + * @flags: device-specific flags
>> + *   - PCI_PASID_TRANSLED_REQ_ONLY: The PCI device only issues PASID
>> + *                                  memory requests of translated type.
>                      ^^^^^^^^
> 
> I don't like "transled" since it's not a word itself or an obvious
> combination of "translated" and something else.
> 
> Not sure whether you need to abbreviate it, but if you do, "xlate" is
> a common shortening of "translate".

Yes. "xlate" looks better. I will replace with it.

I've updated this patch with a v2.

https://lore.kernel.org/linux-iommu/20230113014409.752405-1-baolu.lu@linux.intel.com/

Thank you both for the comments.

--
Best regards,
baolu