Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S932898AbXHVVHo (ORCPT ); Wed, 22 Aug 2007 17:07:44 -0400 Received: (majordomo@vger.kernel.org) by vger.kernel.org id S1763875AbXHVVHf (ORCPT ); Wed, 22 Aug 2007 17:07:35 -0400 Received: from mx1.suse.de ([195.135.220.2]:48158 "EHLO mx1.suse.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1763237AbXHVVHf (ORCPT ); Wed, 22 Aug 2007 17:07:35 -0400 Date: Wed, 22 Aug 2007 23:07:33 +0200 Message-ID: From: Takashi Iwai To: Mariusz Kozlowski Cc: Andrew Morton , linux-kernel@vger.kernel.org Subject: Re: 2.6.23-rc3-mm1: inlining failures in sound/pci/hda/hda_codec.c In-Reply-To: <200708222223.04610.m.kozlowski@tuxland.pl> References: <20070822020648.5ea3a612.akpm@linux-foundation.org> <200708222223.04610.m.kozlowski@tuxland.pl> User-Agent: Wanderlust/2.15.5 (Almost Unreal) SEMI/1.14.6 (Maruoka) FLIM/1.14.7 (=?ISO-8859-4?Q?Sanj=F2?=) APEL/10.6 MULE XEmacs/21.5 (beta28) (fuki) (+CVS-20070802) (i386-suse-linux) MIME-Version: 1.0 (generated by SEMI 1.14.6 - "Maruoka") Content-Type: text/plain; charset=US-ASCII Sender: linux-kernel-owner@vger.kernel.org X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1850 Lines: 50 At Wed, 22 Aug 2007 22:23:03 +0200, Mariusz Kozlowski wrote: > > Hello, > > This is from x86_32 with gcc 3.4.6: > > CC [M] sound/pci/hda/hda_codec.o > sound/pci/hda/hda_codec.c: In function `snd_hda_codec_free': > sound/pci/hda/hda_codec.c:517: sorry, unimplemented: inlining failed in call to 'free_hda_cache': function body not available > sound/pci/hda/hda_codec.c:534: sorry, unimplemented: called from here > sound/pci/hda/hda_codec.c:517: sorry, unimplemented: inlining failed in call to 'free_hda_cache': function body not available > sound/pci/hda/hda_codec.c:535: sorry, unimplemented: called from here > make[3]: *** [sound/pci/hda/hda_codec.o] Error 1 > make[2]: *** [sound/pci/hda] Error 2 > make[1]: *** [sound/pci] Error 2 > make: *** [sound] Error 2 Since it doesn't happen with gcc-4.x, this looks like a gcc-3.x specific problem. Does the patch below fix? Taksahi diff -r db9001b20d29 pci/hda/hda_codec.c --- a/pci/hda/hda_codec.c Wed Aug 22 14:19:45 2007 +0200 +++ b/pci/hda/hda_codec.c Wed Aug 22 23:06:00 2007 +0200 @@ -514,7 +514,7 @@ static int read_widget_caps(struct hda_c static void init_hda_cache(struct hda_cache_rec *cache, unsigned int record_size); -static inline void free_hda_cache(struct hda_cache_rec *cache); +static void free_hda_cache(struct hda_cache_rec *cache); /* * codec destructor @@ -707,7 +707,7 @@ static void __devinit init_hda_cache(str cache->record_size = record_size; } -static inline void free_hda_cache(struct hda_cache_rec *cache) +static void free_hda_cache(struct hda_cache_rec *cache) { kfree(cache->buffer); } - To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/