Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Message-ID: <bac878be-acaa-e373-f5fc-fb6b35964eb5@amd.com>
Date:   Fri, 13 Jan 2023 10:59:01 +0530
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101
 Thunderbird/102.4.2
Subject: Re: [PATCH v5] x86/sev: Add SEV-SNP guest feature negotiation support
To:     Tom Lendacky <thomas.lendacky@amd.com>,
        linux-kernel@vger.kernel.org, x86@kernel.org, kvm@vger.kernel.org,
        bp@alien8.de
Cc:     mingo@redhat.com, tglx@linutronix.de, dave.hansen@linux.intel.com,
        seanjc@google.com, pbonzini@redhat.com, michael.roth@amd.com,
        David Rientjes <rientjes@google.com>, stable@kernel.org
References: <20230112084139.12615-1-nikunj@amd.com>
 <4cf6a6aa-81f9-4fae-2a39-1825433f9ee4@amd.com>
Content-Language: en-US
From:   "Nikunj A. Dadhania" <nikunj@amd.com>
In-Reply-To: <4cf6a6aa-81f9-4fae-2a39-1825433f9ee4@amd.com>
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 8bit
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?SVowMEFLWEk0aGdHSzEzSTlNakllcjVDNGdjSUw1NHVHaVZiSVdCMCtodDNr?=
 =?utf-8?B?ZEFHcGI0RWlXRVRMY3dWUnpKTmtURWh4YmhkeWVPS2dKRXpoV1VPQUpsdTdN?=
 =?utf-8?B?aEEvNWFzYmRac1JKNzFSNWRhZzNjS0p6UWlMTEtHdkt5R3p4aS84NFljNjQ4?=
 =?utf-8?B?WWlNZTQyNnBhQ0FYOWdwYWVVenN3Mmo1aWhmZ0lZQlhydlZjcEIrcE42Z2cz?=
 =?utf-8?B?YzZpUHB0dG5YOHJWNEJ3UlZFQStPcnZFV28yMVRrWkUveDg2SERXMWxRUXI4?=
 =?utf-8?B?STJNZVZZOE5La0NWWGxESENvWXFXbkpDZ29ydmlvU1NZVElvTHpGV2dzbURy?=
 =?utf-8?B?blNGUmw3L0ZUcVlxZ2licFFuTVo1amhjSE12KzU4TDB0czlOdVhPL01KRmpj?=
 =?utf-8?B?TGx6SW01WUNod3BCM2lmaVNCYXhwcEZyaThSclpUeUJqU2I1RjllcXd2K2VV?=
 =?utf-8?B?V2Zzb3BENGw4bDJ2NW1jMDlqU0FrZHJ6QjVoR3FEaW1lc0RKNGJhMWZoVGo4?=
 =?utf-8?B?aDhFWTdiOUI1S1VpWGt1L1A4Vk1xWXo2OVJLT010UXloZ3J4UFFuVEE3eWJ3?=
 =?utf-8?B?NThFQSsvSGF6aVBTUEVucWE1YmtRV3RRdm90OG8rK1ArUkNPblhPVWVRczNp?=
 =?utf-8?B?enNzb1hGV0VtaHIrMWFCMVhCVVk1S2F0OHZNWjU5TG1weGFTMGx0Y2E5T3pR?=
 =?utf-8?B?cVhsTytkYkg0bkllUGR5eGxUWVdISDR4UW1jVmdON245UmlmK1VKdG4wWlFB?=
 =?utf-8?B?elhNZXFtT0UxdW4xS3hXTVBkWjdoVk9zbVJzZnVGRFd3WXI1blh5ZEZnc2ZD?=
 =?utf-8?B?dDVMVkViWGtZamNJa0FRUzIrRWZsSmgxbk9VQ2JYSnMrdEtPVTNocjVBUS9Y?=
 =?utf-8?B?ejlScDRISGlramgwN1FmN3NvNFNEVWlUQ3FTVnFZMEVadm5nUE45NW5wUkFX?=
 =?utf-8?B?czE0S0dMenRoNGJNRFE2Vlo0YmRzVXRReVZkQ3RsZTNiaEhlaGpDY0cwS0ls?=
 =?utf-8?B?UVNVN2pnWDVjRzdDVXZoNTNBNDBKTWpadE5nSzZZYU1YZUtQTjhuUzZZMFQx?=
 =?utf-8?B?MzlyWmkrWEsrbEZtVVZOdEVRZXNsdHUxYnR0aisvc1E5NitLZTRzL0JzbXkv?=
 =?utf-8?B?dmhXcUYzRDlidTlUdzhOU1RrOG9XakVCaUYzWXJWM25FQTRiM2d1V2F1b01x?=
 =?utf-8?B?dXA5Z01FQm55RytxYUR3VzZxbFBCUW82bDcrWUtSVEhwS2xaWkNsMVdMbTYx?=
 =?utf-8?B?dVBnWGZJMmtsR0xHbHQzOUZtQ3k2M1poc1EwaTRmMVNJZ2xHMVRPSTNHV2JZ?=
 =?utf-8?B?eTQ2N215TmYvUkc2TmdFOTFqWDl4c2Q5cEVjWW1ic2c3YkgrWk5pRm1IUkdU?=
 =?utf-8?B?eTkvazIwOHVXSHlLYUtQcmRLL29uQ3luL1hLd3dJSUl2OVFZalZuOFhUVVVt?=
 =?utf-8?B?VExaYyt3VndFZXVoeXVnY2hrWm9PZk1jT1lLT1Q2MndlMDdnY0EvenpNS2c1?=
 =?utf-8?B?L05udFRoNDVlRmRxejk5WmJBVWhvNVdLK3lKUjhYR2dpN3ArbEVtQmhJbHBx?=
 =?utf-8?B?UGRUYmNCL3VIUlA2cTJ1UjRhT2NFam9FMWlDeWR4cDM4R1hGQ3Z6eE9qQ0kx?=
 =?utf-8?B?c2NPRTRDZ2tLbmpSUXYwT3h3LzZJa3VqaC91YVAwYnU3OHZiL2NLQkJnRmIv?=
 =?utf-8?B?a1k0aFdVZjNGT05oT0JGakl6VlNZUnc0MDh4QlhyY09LQVc5YnJ2WGdDWGpq?=
 =?utf-8?B?TzdFUzA3QUNSTlNUbVVlWmlwOHBYZk8zVkJSeWFVSlVHemVZZUJQN1hIeTM5?=
 =?utf-8?B?dXgxZTBqTnI0NzJXdnVhbDBMV0VqUkUzSWgvakQxWm9rMHJ5d0VFOVkyZHNL?=
 =?utf-8?B?TlVnWElHcDlscHVLTmg4eno2WjNIUFNHcXgzZGkxQ1pVYWphc050a1FnNlVa?=
 =?utf-8?B?RDAvOWpIT0V6TlRjckUyVTV4cXJ5R3luRWY0aGVkbjM0UnF3dnhBMDlKc3V3?=
 =?utf-8?B?L2gxUndtdG1YeXJyN2t5aE9KK3JHOUllMmxZYUU3MThWSFUweVNpZk9OV2o4?=
 =?utf-8?B?U1FLSm9ndHYzQzE0UHVIVWsxbWtER3g0VkFHZlhkVUFoS2t4b2U5cjdaeTA2?=
 =?utf-8?Q?gFfmbsf5lKm4S6I/jmFSxoBHi?=
X-OriginatorOrg: amd.com
X-MS-Exchange-CrossTenant-Network-Message-Id: e5c67a55-fe5e-44e4-7d8e-08daf5271bbb
X-MS-Exchange-CrossTenant-AuthSource: DS7PR12MB6309.namprd12.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 13 Jan 2023 05:29:14.8679
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 3dd8961f-e488-4e60-8e11-a82d994e183d
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: 5aCZepI8c5TjUv3qCTxeJJJNAxi58zoihUho6LCmOHIKTH6jRTgnIq5RJnYTyCmSw0JkKgkm2IHtkHu+FuKDcg==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: DM4PR12MB5183
X-Spam-Status: No, score=-2.1 required=5.0 tests=BAYES_00,DKIM_SIGNED,
        DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,NICE_REPLY_A,RCVD_IN_DNSWL_NONE,
        RCVD_IN_MSPIKE_H2,SPF_HELO_PASS,SPF_PASS autolearn=ham
        autolearn_force=no version=3.4.6
X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on
        lindbergh.monkeyblade.net
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org


On 12/01/23 20:12, Tom Lendacky wrote:
> On 1/12/23 02:41, Nikunj A Dadhania wrote:
>> +
>> +        if (sev_es_get_ghcb_version() < 2 ||
> 
> I would just use ghcb_version directly here.

Right, that will work.

> But if you really want a function, that should be a pre-patch that also updates the other areas that directly use ghcb_version.

There is only one such reference other than this one, will use ghcb_version directly.

Regards
Nikunj