Received: by 2002:a05:6358:a55:b0:ec:fcf4:3ecf with SMTP id 21csp388143rwb;
        Thu, 12 Jan 2023 22:01:37 -0800 (PST)
X-Google-Smtp-Source: AMrXdXtwYX8KD1RZXolyX+218WoLoTS6dde/9dLQVWFJq7BUL94U+01q/Nro0PfwCC8cckS+0F9C
X-Received: by 2002:a05:6a20:47c6:b0:b0:1e9b:e930 with SMTP id ey6-20020a056a2047c600b000b01e9be930mr83576313pzb.57.1673589697574;
        Thu, 12 Jan 2023 22:01:37 -0800 (PST)
ARC-Seal: i=1; a=rsa-sha256; t=1673589697; cv=none;
        d=google.com; s=arc-20160816;
        b=jd7CicinXmFUAlG8lvdUEZz0O8atMTCldNHz3tYQ8NKMivQVjY/06ENvDkq0yN5Y+d
         OuabjsWHdVcsfaMxvpxJMFBAAs9aYHqGumUHjnD3m06GQKIy9F5jvWhJAuR4vFHOzTQA
         d7NNAOvpEs7gITb1ptdQo8IBN7rYR+9tWifk4UeIevW5AHNkhBXXnbOIhcstiKfNQ/Hg
         Q7vn2k/vVknsZ4C9k7uF+SuwEr+QStvq9k4859qDQDRrpHaLKreukKAtRETf8vCTO8Sz
         i3Ca0U+PUfRfhZpcj2R+Ke4iVKUYkxRxFbyNWB+r//PnYj6wgPWLTg3xu+m7R3tlhpgJ
         nWiQ==
ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816;
        h=list-id:precedence:in-reply-to:content-disposition:mime-version
         :references:message-id:subject:cc:to:from:date:dkim-signature;
        bh=ysUCfBrwMEP/gKZvWSb1F9GpsO921UxR4IBhrY7rzmA=;
        b=XBXg6OjVBwZHIRE9Ca5L5mdwNlRtdRvSf2tJOr/hhOHKhh9h7+SY8Kb5LnW5JaJote
         lMGMPOuYVyvb95vi9OieLA35TQbJ+22770PLYL3/23UPffmRn1Nkqb0mYtVnr0HSE+Um
         FthbmtWzVUFllI9ouzlwumnW9uFElVDZ823x1t+0dlErXH1uq5LaweMUqLyp6uZnfAP6
         mhlSBlU5xyvZYpISceBRA9xReVJWMYq0Uz4DFv8utGJIFtoBUieKH5U6H0JLCp5FUDDq
         Rr87RrDb8JztoghMStHMOCy9XWizYc3o7qg2csej934FqdN2o0KijmqdJzaEVEIKe0d+
         cixw==
ARC-Authentication-Results: i=1; mx.google.com;
       dkim=pass header.i=@infradead.org header.s=bombadil.20210309 header.b=eltYYegC;
       spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org
Return-Path: <linux-kernel-owner@vger.kernel.org>
Received: from out1.vger.email (out1.vger.email. [2620:137:e000::1:20])
        by mx.google.com with ESMTP id u1-20020a63d341000000b004792b08adabsi20177076pgi.750.2023.01.12.22.01.30;
        Thu, 12 Jan 2023 22:01:37 -0800 (PST)
Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Authentication-Results: mx.google.com;
       dkim=pass header.i=@infradead.org header.s=bombadil.20210309 header.b=eltYYegC;
       spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org
Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand
        id S233217AbjAMFdy (ORCPT <rfc822;a839024@gmail.com> + 50 others);
        Fri, 13 Jan 2023 00:33:54 -0500
Received: from lindbergh.monkeyblade.net ([23.128.96.19]:36308 "EHLO
        lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org
        with ESMTP id S232602AbjAMFdI (ORCPT
        <rfc822;linux-kernel@vger.kernel.org>);
        Fri, 13 Jan 2023 00:33:08 -0500
Received: from bombadil.infradead.org (bombadil.infradead.org [IPv6:2607:7c80:54:3::133])
        by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 57ECC61455;
        Thu, 12 Jan 2023 21:33:06 -0800 (PST)
DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed;
        d=infradead.org; s=bombadil.20210309; h=In-Reply-To:Content-Type:MIME-Version
        :References:Message-ID:Subject:Cc:To:From:Date:Sender:Reply-To:
        Content-Transfer-Encoding:Content-ID:Content-Description;
        bh=ysUCfBrwMEP/gKZvWSb1F9GpsO921UxR4IBhrY7rzmA=; b=eltYYegCYuaDF2OLOCNenA+MS/
        CJY5LRGNK7trbl5wIFc0/jpq68bC42ljrQTOspX75Hp68CeUs1QkBOGhmXiibOwzcjfwLKcbRCE3n
        ZrzmSarQSHrbj2S386A5nT0taBrT0f/aLoevjW2ry1LTgYwZoLG9UoBOTzmdbM44wm1BOxrBlEZKq
        NcJUVUPWW+PMc4rV5dFTjppnd7Q7yYiYqKVPJhT1xLiw9FYUsUzQuEBAJ77Vt4Fqvwz9/qQ1X7tPI
        tQl9Y1rrZ8Pb611cAL01E3KI95x43t8T1Ev+cjwDGx/z/Ex3fTnZbqSnlIqoVhTQesqt9AhOrWZXE
        Gd0RVsYw==;
Received: from hch by bombadil.infradead.org with local (Exim 4.94.2 #2 (Red Hat Linux))
        id 1pGCgW-000VVZ-C9; Fri, 13 Jan 2023 05:33:00 +0000
Date:   Thu, 12 Jan 2023 21:33:00 -0800
From:   Christoph Hellwig <hch@infradead.org>
To:     Al Viro <viro@zeniv.linux.org.uk>
Cc:     David Howells <dhowells@redhat.com>,
        Christoph Hellwig <hch@infradead.org>,
        Matthew Wilcox <willy@infradead.org>,
        Jens Axboe <axboe@kernel.dk>, Jan Kara <jack@suse.cz>,
        Jeff Layton <jlayton@kernel.org>,
        Logan Gunthorpe <logang@deltatee.com>,
        linux-fsdevel@vger.kernel.org, linux-block@vger.kernel.org,
        linux-kernel@vger.kernel.org
Subject: Re: [PATCH v5 3/9] iov_iter: Use IOCB/IOMAP_WRITE if available
 rather than iterator direction
Message-ID: <Y8DtDDZSWcrfLmy/@infradead.org>
References: <167344725490.2425628.13771289553670112965.stgit@warthog.procyon.org.uk>
 <167344727810.2425628.4715663653893036683.stgit@warthog.procyon.org.uk>
 <Y8CCCQLrm9vshGw0@ZenIV>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <Y8CCCQLrm9vshGw0@ZenIV>
X-SRS-Rewrite: SMTP reverse-path rewritten from <hch@infradead.org> by bombadil.infradead.org. See http://www.infradead.org/rpr.html
X-Spam-Status: No, score=-4.4 required=5.0 tests=BAYES_00,DKIM_SIGNED,
        DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,RCVD_IN_DNSWL_MED,SPF_HELO_NONE,
        SPF_NONE autolearn=ham autolearn_force=no version=3.4.6
X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on
        lindbergh.monkeyblade.net
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

On Thu, Jan 12, 2023 at 09:56:25PM +0000, Al Viro wrote:
> Incidentally, I'd suggest iocb_is_write(iocb) - just look at the amount of
> places where you end up with clumsy parentheses...

Agreed, a little helper won't hurt.