Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
From:   Hardevsinh Palaniya <hardevsinh.palaniya@siliconsignals.io>
To:     Daniel Baluta <daniel.baluta@gmail.com>,
        Daniel Baluta <daniel.baluta@nxp.com>,
        "krzysztof.kozlowski+dt@linaro.org" 
        <krzysztof.kozlowski+dt@linaro.org>
CC:     "robh+dt@kernel.org" <robh+dt@kernel.org>,
        "shawnguo@kernel.org" <shawnguo@kernel.org>,
        "s.hauer@pengutronix.de" <s.hauer@pengutronix.de>,
        "kernel@pengutronix.de" <kernel@pengutronix.de>,
        "festevam@gmail.com" <festevam@gmail.com>,
        "linux-imx@nxp.com" <linux-imx@nxp.com>,
        "lgirdwood@gmail.com" <lgirdwood@gmail.com>,
        "broonie@kernel.org" <broonie@kernel.org>,
        "perex@perex.cz" <perex@perex.cz>,
        "tiwai@suse.com" <tiwai@suse.com>,
        "peng.fan@nxp.com" <peng.fan@nxp.com>,
        "m.felsch@pengutronix.de" <m.felsch@pengutronix.de>,
        "shengjiu.wang@nxp.com" <shengjiu.wang@nxp.com>,
        "Markus.Niebel@ew.tq-group.com" <Markus.Niebel@ew.tq-group.com>,
        "hongxing.zhu@nxp.com" <hongxing.zhu@nxp.com>,
        "tommaso.merciai@amarulasolutions.com" 
        <tommaso.merciai@amarulasolutions.com>,
        "jun.li@nxp.com" <jun.li@nxp.com>,
        "ckeepax@opensource.cirrus.com" <ckeepax@opensource.cirrus.com>,
        "rf@opensource.cirrus.com" <rf@opensource.cirrus.com>,
        "povik+lin@cutebit.org" <povik+lin@cutebit.org>,
        "pierre-louis.bossart@linux.intel.com" 
        <pierre-louis.bossart@linux.intel.com>,
        "james.schulman@cirrus.com" <james.schulman@cirrus.com>,
        "flatmax@flatmax.com" <flatmax@flatmax.com>,
        "srinivas.kandagatla@linaro.org" <srinivas.kandagatla@linaro.org>,
        "ryan.lee.analog@gmail.com" <ryan.lee.analog@gmail.com>,
        "devicetree@vger.kernel.org" <devicetree@vger.kernel.org>,
        "linux-arm-kernel@lists.infradead.org" 
        <linux-arm-kernel@lists.infradead.org>,
        "linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
        "alsa-devel@alsa-project.org" <alsa-devel@alsa-project.org>
Subject: Re: [PATCH] Support for MAX98090/91 codec in iMX8MM evk
Thread-Topic: [PATCH] Support for MAX98090/91 codec in iMX8MM evk
Thread-Index: AQHZJYqW0X9zj+hpQkK22Ny+RkFTBa6Y7JCAgAACEuaAAC3aAIACvW6s
Date:   Fri, 13 Jan 2023 05:50:30 +0000
Message-ID: <MA0PR01MB7145B5094B0E3FB35764DE9FFFC29@MA0PR01MB7145.INDPRD01.PROD.OUTLOOK.COM>
References: <MA0PR01MB7145CB5A2D487FB713CD7C01FFFC9@MA0PR01MB7145.INDPRD01.PROD.OUTLOOK.COM>
 <CAEnQRZC2X5v6hh=-PRiaUgp3SZQYg1vot+4JKwEE6x5bzTKvwA@mail.gmail.com>
 <MA0PR01MB71451A4A70DBD85680E90AE0FFFC9@MA0PR01MB7145.INDPRD01.PROD.OUTLOOK.COM>
 <CAEnQRZDowp=-Cqvy=hJzQDDN_+cEUS7Pj-GJ-0oAhqq=N2STWw@mail.gmail.com>
In-Reply-To: <CAEnQRZDowp=-Cqvy=hJzQDDN_+cEUS7Pj-GJ-0oAhqq=N2STWw@mail.gmail.com>
Accept-Language: en-US
Content-Language: en-US
msip_labels: 
authentication-results: dkim=none (message not signed)
 header.d=none;dmarc=none action=none header.from=siliconsignals.io;
x-ms-publictraffictype: Email
x-ms-traffictypediagnostic: MA0PR01MB7145:EE_|PN3PR01MB6459:EE_
x-ms-office365-filtering-correlation-id: 2724517c-7fc3-42e2-14b5-08daf52a1478
x-ms-exchange-senderadcheck: 1
x-ms-exchange-antispam-relay: 0
x-microsoft-antispam: BCL:0;
x-microsoft-antispam-message-info: FqlajtkW/OD20ZQ0SUmHPzpNP40adYCX1uLuL2rjflsA9Jt//bdnfMvixHh19cHg1BD7mFHXJZrK1x82SUYlrlUeKM7M9hCxQxhL9oGKii6gMrPdBtkvcBCInQVUQO4EW2Mdsogv7CgJnn/1taN1UdGrwXkW6tJi05jsrzIoPhKKP6uUVzswfNWdiD+b69VDwM0VIHkKG9a3fHRWHhgoOtnxQxmYeJMc9MhpADcfICt5+ouA3evb8UOTK59e/7tqU7U/lXWCpvM8Xx/jxnyr+Csn73Pl+ylb/m/YfJYZZGCpW6MDD62/xWuKfH2paj6X+EWWo6CKCmyH++HJJMiDGloBLvTW9TMxXCyjMM/xJY3U1tO5RENiogO7WU2VtOivlZSk2viaN1T5ToJFQSBMWuAIHThw0vxwU5spKIb8fGzvBsuP2Tk1XdRyWkeagQ2D/DRuHmL4iaKUGwGuKcIo/iKupkgFLRpmJT6z8MTOrwr4egRLlXztifIGgWTeniI5ptboF8GOckBFxb35zg2/RH/yOwQ72CfLZDMxzvNcx+GEPmIyHZ+Phz+ttw72Mx3poqSWKrmDJSWq8VA0kQGxi76CL6hwi+XT02ZaJcRpwWADrk3JTaQy2v1F4IhOPeXsHF7ls2vyg8CMvwDgge8eg8/1UdArUXJx1pLWTGJ/oULqPoZIfDjKqsc0nf93rN4fy6c08KyEyOeX9919kiVUpttxGcYHdkm0vspVv4accQE=
x-forefront-antispam-report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:MA0PR01MB7145.INDPRD01.PROD.OUTLOOK.COM;PTR:;CAT:NONE;SFS:(13230022)(376002)(39830400003)(396003)(366004)(346002)(136003)(451199015)(55236004)(53546011)(6506007)(122000001)(38100700002)(2906002)(38070700005)(7416002)(33656002)(9686003)(5660300002)(71200400001)(7696005)(186003)(26005)(478600001)(316002)(7406005)(44832011)(86362001)(52536014)(8936002)(83380400001)(55016003)(91956017)(66946007)(41300700001)(54906003)(66556008)(66476007)(64756008)(8676002)(4326008)(66446008)(110136005)(76116006)(32563001);DIR:OUT;SFP:1101;
x-ms-exchange-antispam-messagedata-chunkcount: 1
x-ms-exchange-antispam-messagedata-0: =?iso-8859-1?Q?r6kQj5ooKApSso7HW5SdSx9LG+z1ytqttMplsjKCVaLCEunam5Pgdg4T++?=
 =?iso-8859-1?Q?u/qw2JSDF7d22OHPy3WuO3gO4rBuflLj79qgt0/QMMXDGiKum4EynRipaB?=
 =?iso-8859-1?Q?mQaURo2vcon8wn2d5HIrjE0dTsrHa0ugUMBU4NiPLep9aUzPhhzfj8jhur?=
 =?iso-8859-1?Q?1Bp+/7HkFIhvdkBOs5FOf4+Wcvs6YweaN8ibald+vqEG+1nV88eqVFWPiM?=
 =?iso-8859-1?Q?Xk1IvD8ijShv5ggnqelBFa+e7x7hkbPogj+Au/1VqV5CBNJXgrVzhW9jcE?=
 =?iso-8859-1?Q?yBQo+TMWwGQCnwvR4qsNFD9NvDpg6RK7rbzb9Cwrl3Cgj/So5+1hdeF+3H?=
 =?iso-8859-1?Q?BSj+dwjhhzbBeEFxFNO1TK4udH+NGFiEknxetQ6YCJfvi8eQN6NVzdxS2K?=
 =?iso-8859-1?Q?1xJvUJ6/jZmLBBTVuvN+0FE1S7aGvovUU3ZiwE8hDIUyx0/BdMDn/UoSKV?=
 =?iso-8859-1?Q?2Hrt1fE61NO7NG8H8oovzMEo9bpEYuMDVhGz7vcmNsE7bua0BsvMUZEDxE?=
 =?iso-8859-1?Q?HGnScxSalLp2z2RpU0QCoQvJhc3oc8I7PLb72Mm5xFx6pk3DCgGCr6CKzs?=
 =?iso-8859-1?Q?5ou4X8ghcUOv+fnCbwJ6lbcj12zHT0FjU/Mk75Ly46CvNNzAiyc5iNtvLi?=
 =?iso-8859-1?Q?+OcLYfwY9yVl5QFegz/iWV0G2FCwxNC9II3uWf83BFZWlYqDwtB12HdaQg?=
 =?iso-8859-1?Q?95V02HhrKxe+KF5CN5VFfjncVcoMcQuzZWTDUlyw6BtMFmr1QcKXLhaxLJ?=
 =?iso-8859-1?Q?pFvloUEOaQ0THhtaRPIFDhTFOM+/IZO96pTg5sp300BJPbtg280TcLcoSF?=
 =?iso-8859-1?Q?Xied6wyp3SB+rIqu++4L+b3l+L95vNpEL3QyhT5KKDR7DdL2lMYtkZua/s?=
 =?iso-8859-1?Q?9GpY3hd7cd6cpp4FrhpTBvtMtqe/JYK5C4dRIaGYmGbcvOi2W1j1wR2xFn?=
 =?iso-8859-1?Q?clZo0VCJ2uWPD39uincEjCJEpLNA6ahWU8l5dYH2c9c+vThvoKsXez2J9c?=
 =?iso-8859-1?Q?N6aTbafXyOtHTgtojIwBa8VV5jDKoKtcwyM/0D2aifawcUSmgCLBykL3rS?=
 =?iso-8859-1?Q?mQ/lO3JA9qDBGwWJIOXIjyLWmhOd08iosS48FgHfI5swW12m4Hhk75UAEX?=
 =?iso-8859-1?Q?aeZIIJ0gAWIUGC249YwMCfiQk/80lm8TskGT6KG4rpPFSep9ktKx2sULml?=
 =?iso-8859-1?Q?3EKGCQSGaTS3vASYsKukQZ9A6aBYl7qwdrd3bQtZwQoIUZ291dkPw9Z03D?=
 =?iso-8859-1?Q?snewCPEiAKJ4HZ4LM7nCf+36m0Pn//Jy0Eiuiazeq/rT4opY42DEghoOAX?=
 =?iso-8859-1?Q?trX8SOGj2vOMKU+2E/NtfxZACGdVyjrT5Fgr4teWdmvV5gxbF9qCuvc/PJ?=
 =?iso-8859-1?Q?8pOUqiCO0nSqeM5oK47opz7eEsWgMJ2uQCNvsu6ItaBohXc820urnCG5f3?=
 =?iso-8859-1?Q?8wYMGb2ut09gWpYcF3TQC/TGWTV66rvhtWl+yldTp/zy/9B2kaTXeXMvHH?=
 =?iso-8859-1?Q?knkj3bnCxqNIaEgPtBPK8+0f2kK3a7OVSE/Oo+QXmGpC/Hh7DiFVsVwKB9?=
 =?iso-8859-1?Q?wy+0rIbTHq3K1LS5v4jx9eO4FLPT07BBQUOT0rpc20fYkN2xSrC8MGpoje?=
 =?iso-8859-1?Q?33gFJJD610HhDV4+j/Ce6l5gfiHnVHE0Snwpn2UuxRpQx0QlstHIaBJGJN?=
 =?iso-8859-1?Q?3COeEOaPgbvaDP6CJ5Q=3D?=
Content-Type: text/plain; charset="iso-8859-1"
Content-Transfer-Encoding: 8BIT
MIME-Version: 1.0
X-OriginatorOrg: siliconsignals.io
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-AuthSource: MA0PR01MB7145.INDPRD01.PROD.OUTLOOK.COM
X-MS-Exchange-CrossTenant-Network-Message-Id: 2724517c-7fc3-42e2-14b5-08daf52a1478
X-MS-Exchange-CrossTenant-originalarrivaltime: 13 Jan 2023 05:50:30.6879
 (UTC)
X-MS-Exchange-CrossTenant-fromentityheader: Hosted
X-MS-Exchange-CrossTenant-id: 7ec5089e-a433-4bd1-a638-82ee62e21d37
X-MS-Exchange-CrossTenant-mailboxtype: HOSTED
X-MS-Exchange-CrossTenant-userprincipalname: /jkxlovXPo3hf3j0FM+nBojFumqVGp15cFdJY2TUS+6xTOVX+ZLXqK68HmmRqoVJH+ot5TMqdYCS2zeJwwBCSYj6wG91QGNWhaBMi6bPeVH9yQkD8lRt/k+G2Za1wboo
X-MS-Exchange-Transport-CrossTenantHeadersStamped: PN3PR01MB6459
X-Spam-Status: No, score=-1.9 required=5.0 tests=BAYES_00,RCVD_IN_DNSWL_NONE,
        RCVD_IN_MSPIKE_H2,SPF_HELO_PASS,SPF_PASS autolearn=ham
        autolearn_force=no version=3.4.6
X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on
        lindbergh.monkeyblade.net
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

From d2001cdbc2fda3345af307b4cf3d0f2e53d80c35 Mon Sep 17 00:00:00 2001
From: Hardevsinh Palaniya <hardevsinh.palaniya@siliconsignals.io>
Date: Fri, 13 Jan 2023 11:01:22 +0530
Subject: [PATCH] Add dts to support MAX98090/91 with i.MX8MM-evk

- Add sound-max98090 node to support external codec MAX98090/91
- Use i2c3 for i2c communicate with codec
- Use sai5 for i2s communication

Signed-off-by: Hardevsinh Palaniya <hardevsinh.palaniya@siliconsignals.io>

diff --git a/arch/arm64/boot/dts/freescale/imx8mm-evk-max98090-91.dts b/arch/arm64/boot/dts/freescale/imx8mm-evk-max98090-91.dts
new file mode 100644
index 000000000000..d053c586514a
--- /dev/null
+++ b/arch/arm64/boot/dts/freescale/imx8mm-evk-max98090-91.dts
@@ -0,0 +1,65 @@
+#include "imx8mm-evk.dtsi"
+
+/ {
+	sound-max98090 {
+		compatible = "simple-audio-card";
+		simple-audio-card,name = "max98090-audio";
+		simple-audio-card,format = "i2s";
+		simple-audio-card,frame-master = <&cpudai>;
+		simple-audio-card,bitclock-master = <&cpudai>;
+		simple-audio-card,widgets = "Speakers", "Speakers";
+		simple-audio-card,routing =
+				"Speakers", "SPKR",
+				"Speakers", "SPKL",
+				"IN1", "MICBIAS",
+				"MIC1","IN1",
+				"MIC2","IN1";
+
+		cpudai: simple-audio-card,cpu {
+			sound-dai = <&sai5>;
+			dai-tdm-slot-num = <2>;
+			dai-tdm-slot-width = <32>;
+		};
+
+		simple-audio-card,codec {
+			sound-dai = <&max98090>;
+			clocks = <&clk IMX8MM_CLK_SAI5_ROOT>;
+		};
+	};
+}
+
+&i2c3 {
+	max98090: audio-codec@10 {
+		compatible = "maxim,max98090","maxim,max98091";
+		#sound-dai-ceddlls = <0>;
+		reg = <0x10>;
+		clocks = <&clk IMX8MM_CLK_SAI5_ROOT>;
+		clock-names = "mclk";
+	};
+}
+
+&sai5 {
+	pinctrl-names = "default";
+	pinctrl-0 = <&pinctrl_sai5>;
+	assigned-clocks = <&clk IMX8MM_CLK_SAI5>;
+	assigned-clock-parents = <&clk IMX8MM_AUDIO_PLL1_OUT>;
+	assigned-clock-rates = <24576000>;
+	clocks = <&clk IMX8MM_CLK_SAI5_IPG>, <&clk IMX8MM_CLK_DUMMY>,
+		<&clk IMX8MM_CLK_SAI5_ROOT>, <&clk IMX8MM_CLK_DUMMY>,
+		<&clk IMX8MM_CLK_DUMMY>, <&clk IMX8MM_AUDIO_PLL1_OUT>,
+		<&clk IMX8MM_AUDIO_PLL2_OUT>;
+	clock-names = "bus", "mclk0", "mclk1", "mclk2", "mclk3", "pll8k", "pll11k";
+	status = "okay";
+};
+
+&iomuxc {
+	pinctrl_sai5: sai5grp {
+		fsl,pins = <
+			MX8MM_IOMUXC_SAI5_MCLK_SAI5_MCLK        0xd6
+			MX8MM_IOMUXC_SAI5_RXD2_SAI5_TX_BCLK     0xd6
+			MX8MM_IOMUXC_SAI5_RXD1_SAI5_TX_SYNC     0xd6
+			MX8MM_IOMUXC_SAI5_RXD0_SAI5_RX_DATA0    0xd6
+			MX8MM_IOMUXC_SAI5_RXD3_SAI5_TX_DATA0    0xd6
+		>;
+	}
+}
-- 
2.25.1
________________________________________
From: Daniel Baluta <daniel.baluta@gmail.com>
Sent: Wednesday, January 11, 2023 5:26 PM
To: Hardevsinh Palaniya; Daniel Baluta
Cc: robh+dt@kernel.org; krzysztof.kozlowski+dt@linaro.org; shawnguo@kernel.org; s.hauer@pengutronix.de; kernel@pengutronix.de; festevam@gmail.com; linux-imx@nxp.com; lgirdwood@gmail.com; broonie@kernel.org; perex@perex.cz; tiwai@suse.com; peng.fan@nxp.com; m.felsch@pengutronix.de; shengjiu.wang@nxp.com; Markus.Niebel@ew.tq-group.com; hongxing.zhu@nxp.com; tommaso.merciai@amarulasolutions.com; jun.li@nxp.com; ckeepax@opensource.cirrus.com; rf@opensource.cirrus.com; povik+lin@cutebit.org; pierre-louis.bossart@linux.intel.com; james.schulman@cirrus.com; flatmax@flatmax.com; srinivas.kandagatla@linaro.org; ryan.lee.analog@gmail.com; devicetree@vger.kernel.org; linux-arm-kernel@lists.infradead.org; linux-kernel@vger.kernel.org; alsa-devel@alsa-project.org
Subject: Re: [PATCH] Support for MAX98090/91 codec in iMX8MM evk


 > I have added support for the external codec MAX98091 with I.MX8MM-EVK.

Please fix your email client to start sending email in text format only.

Now, going back to the matter at hand.

I do think that for an external codec we should find a smarter way of enabling it.

What would happen if you enable MAX codec in the dts but expander board is not plugged in?

Maybe create a separate dts which includes imx8mm-evk.dtsi?