Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Message-ID: <a3d870c7-c906-dc89-7a1c-e933b3a32536@amd.com>
Date:   Thu, 12 Jan 2023 23:38:23 -0600
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101
 Thunderbird/102.5.1
Subject: Re: [PATCH v2 4/6] Documentation: amd_pstate: Move amd_pstate param
 to alphabetical order
Content-Language: en-US
To:     Wyes Karny <wyes.karny@amd.com>,
        Rafael J Wysocki <rafael@kernel.org>,
        Huang Rui <ray.huang@amd.com>,
        Jonathan Corbet <corbet@lwn.net>,
        Viresh Kumar <viresh.kumar@linaro.org>, Perry.Yuan@amd.com,
        Ananth Narayan <ananth.narayan@amd.com>, gautham.shenoy@amd.com
Cc:     linux-doc@vger.kernel.org, linux-kernel@vger.kernel.org,
        linux-pm@vger.kernel.org, Bagas Sanjaya <bagasdotme@gmail.com>,
        santosh.shukla@amd.com
References: <20230113052141.2874296-1-wyes.karny@amd.com>
 <20230113052141.2874296-5-wyes.karny@amd.com>
From:   Mario Limonciello <mario.limonciello@amd.com>
In-Reply-To: <20230113052141.2874296-5-wyes.karny@amd.com>
Content-Type: text/plain; charset=UTF-8; format=flowed
Content-Transfer-Encoding: 7bit
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?M2NVN3h4VEJ5SHBsZWJ5eGxmdDVvNXBQdjVZTC9laVdlbmZ2RE5YUk4zVWpW?=
 =?utf-8?B?YndhRTJjbWVPVlBobE5sQ0dMd2M3Ri93WWxIcU51Sis4SmVIUDg5MUIvNWI1?=
 =?utf-8?B?OGJRNERqaTZubFBSMURWUndvK0NqVHJBRlByRkJpbzUyVE1ZQ1FaUWU5aEhj?=
 =?utf-8?B?SVlLWExZcGpxSGpVVEdiNHpyaWo1ZitIakJxdU5RejBEai9KKzV6cVBjM0FW?=
 =?utf-8?B?K0FxMjlwRkdQUG5DUngxVGxJOWhRbjJ6QmdqWlNUcHdPS3FxWmVGdHB1RnpO?=
 =?utf-8?B?bmVNNVlxeUVnZm5RWmd5S2tBZEp4U1Bna2JKeXlPUVQ4bnM0K0tpT3JLNCtG?=
 =?utf-8?B?b1BHZTVLYUxWN0QrSmE2dzRrcmpMZlVzNUtyUVhMcXNlMkVERzlEL1l1L0ZQ?=
 =?utf-8?B?TXJBVnVMKzBSdVlkZTdoOVJMV0JESnRURjhFcWcybE1zNFY1eThwaGRyUWF4?=
 =?utf-8?B?cEpyOElwc1k1dENZN2pjb0dPWHpLREJkK2p3VXNaa3JVL0YreHBlYk1jTm1J?=
 =?utf-8?B?c2pQSlVwR1FLZmQ2ZG1GOWpHY0xCb3ZwQUJ5ZmY3TENNZFN1bE5OZlVnOHFL?=
 =?utf-8?B?c3FUTGJLaDgweXBUTVhnNDNLb0ZYaW0vUVNHUk5raUdEeFpvSlVOWEhLM1Zt?=
 =?utf-8?B?NDdnY2loempLRms3SFpyRXpHYzdkZEp0OTZOL2tSaU5uRU9CaFBsOVljWmlm?=
 =?utf-8?B?K2Q5R2IwMEo4RjNlQjVQcHliMXFURmNycURKei82RTJvQUMrWEg4Z2xtTUww?=
 =?utf-8?B?T0Q0b3lXRFlab2lHM3FSOVVYS0JMNU5XS0FMRzRFZWdoaytobFVsc3NhMUxS?=
 =?utf-8?B?Y3VlQkptSEtXNnhZajdZT2xKak5QYWVjTGtxUzNUTTZmRGdSSWQrMlk3Y0k2?=
 =?utf-8?B?aEJMYUE5Sk5iUWZGdklzeEFTUlpNQ0ZJdkU4Ym1jUi9lb1NFcDZTQ2k1a0hW?=
 =?utf-8?B?QnVUbkN6US9wOENJOFpSZVJBMDdNQmdSMWR3VXBLa1QzTnVZejJOUGl0MElC?=
 =?utf-8?B?Yy9NZ2VpT056b2ZLRFZFbnRETTNqWnY4ZFpLQTBpY1EzZ3FOd2NnU1Q0a3Ji?=
 =?utf-8?B?S1NyMmNHZG9SVmVkTis5SWpzdWdiTHl4RHJ0Wm1PbnZiNjNQdkk5cEY3b2xR?=
 =?utf-8?B?NDFSMnNNRm9lZXBiTm5hNmxVTWpYQ2tCeVQ0YmV3RHR4WURTTkdiS0J6NTg0?=
 =?utf-8?B?aFRKd295c2RYTUZmL3VsM016cE9LWlF4L1o1b3VsWFMvcjRCNW4xSkpGZTUv?=
 =?utf-8?B?czJxM0NQNFFxNzQ4US8wUFFsODkvb0lnSXc5dXJ5WWxJWFV2ZDBadWRvaE1S?=
 =?utf-8?B?RW50Vlp1Z2NhanRhK1JRVVN2Y2JrckZ4cUVvd2FvbENaa0NVQUEwMlJwQkRy?=
 =?utf-8?B?a01XM2hPakFBRUJaRzA2QitJejVZdlo4SmRKSk1mb0J0citFeHc0ODF4TFh6?=
 =?utf-8?B?SlpaM0pYSzhjQlptcFYvTStQK3docGIvRUsxbWJ5ZlhmczNHN3lxTkJ2NHVn?=
 =?utf-8?B?SFNmU1RySGczZC9sNnc1TUloRkduVnhORTVyOUE5TmNpRk9DSDRsYlpTZlNp?=
 =?utf-8?B?WjN5WTkwWWdWUG9Ec3VRSFhxU3BObWs0N1REZmRiKzR2MjlvVk5xMHFQRVlH?=
 =?utf-8?B?eE9KL3JtMzU5WWcxV3AwSUFIMG9taVhxNzgyS0dwUTE1emovMC8zdUhRUWNG?=
 =?utf-8?B?MzRTcm1oNjF0N2FaOUY5cFFVT3BDTnlaOVZsMjdBQzVsdmpZY3JaR2FySWZY?=
 =?utf-8?B?TXJXbkpCd1d6eFRhNVVKUFNwYzRzK2VJeUx6UVVRNTFPSVl2MWtDTzVEby9O?=
 =?utf-8?B?VENJckd2R2VMYzgxUDhHbHQ0ZTdIQStsMndMM2xobUcwNWNDdW5vUGNTejU3?=
 =?utf-8?B?SExkNDE4QTV0MDJyK2I4bzFMK1ArZTJqTU5LUktpODNuTU5sWkQyRGNRNkN1?=
 =?utf-8?B?NGFGUHp0YnpkcHJRQ1diaHRqWXkzVWRGTVljbGdYdCszdExPMWxMdXVsYy9T?=
 =?utf-8?B?aWtyMU1rdVBibGVBYzJYWHRQTGIyUmFBa2ZtNWNLb1Z0Sk4xaDRKMjBEQmUx?=
 =?utf-8?B?cDlRN29xV0J1bU51WE5qWGJMTy9rTzM3akxPeFdCdGlIRkpFQzhJOTk5Y0g1?=
 =?utf-8?B?bTczL0IyVXIvOWlFdisrUjJKUDMvdzhJTlF6K1h6Rk9rOGh4ci9iUSt5UVRj?=
 =?utf-8?Q?62iIX0ouZD7WQS3HkRo7t7mBz/4D267I12pf1a1kwIOx?=
X-OriginatorOrg: amd.com
X-MS-Exchange-CrossTenant-Network-Message-Id: 59f40f44-3de3-4b9f-249c-08daf52864a3
X-MS-Exchange-CrossTenant-AuthSource: MN0PR12MB6101.namprd12.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 13 Jan 2023 05:38:26.4301
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 3dd8961f-e488-4e60-8e11-a82d994e183d
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: 5DwnbloZ7de+6o7WyqvkGf0ZB+wjhLycbdkFxm23g5hwZZtAcKQHLYW8pRlwKA6rcGtGv7mK71DGToY93E1+sw==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: SJ1PR12MB6146
X-Spam-Status: No, score=-2.1 required=5.0 tests=BAYES_00,DKIM_SIGNED,
        DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,NICE_REPLY_A,RCVD_IN_DNSWL_NONE,
        RCVD_IN_MSPIKE_H2,SPF_HELO_PASS,SPF_PASS autolearn=ham
        autolearn_force=no version=3.4.6
X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on
        lindbergh.monkeyblade.net
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

On 1/12/23 23:21, Wyes Karny wrote:
> Move amd_pstate command line param description to correct alphabetical
> order.
> 
> Signed-off-by: Wyes Karny <wyes.karny@amd.com>

Reviewed-by: Mario Limonciello <mario.limonciello@amd.com>

> ---
>   .../admin-guide/kernel-parameters.txt         | 46 +++++++++----------
>   1 file changed, 23 insertions(+), 23 deletions(-)
> 
> diff --git a/Documentation/admin-guide/kernel-parameters.txt b/Documentation/admin-guide/kernel-parameters.txt
> index 0d8486325c9a..5f6a3a34251e 100644
> --- a/Documentation/admin-guide/kernel-parameters.txt
> +++ b/Documentation/admin-guide/kernel-parameters.txt
> @@ -339,6 +339,29 @@
>   			             This mode requires kvm-amd.avic=1.
>   			             (Default when IOMMU HW support is present.)
>   
> +	amd_pstate=	[X86]
> +			disable
> +			  Do not enable amd_pstate as the default
> +			  scaling driver for the supported processors
> +			passive
> +			  Use amd_pstate with passive mode as a scaling driver.
> +			  In this mode autonomous selection is disabled.
> +			  Driver requests a desired performance level and platform
> +			  tires to match the same performance level (if it is
> +			  satisfied by guaranteed performance level).
> +			active
> +			  Use amd_pstate_epp driver instance as the scaling driver,
> +			  driver provides a hint to the hardware if software wants
> +			  to bias toward performance (0x0) or energy efficiency (0xff)
> +			  to the CPPC firmware. then CPPC power algorithm will
> +			  calculate the runtime workload and adjust the realtime cores
> +			  frequency.
> +			guided
> +			  Activate guided autonomous mode. Driver requests minimum and
> +			  maximum performance level and the platform autonomously
> +			  selects a performance level in this range and appropriate
> +			  to the current workload.
> +
>   	amijoy.map=	[HW,JOY] Amiga joystick support
>   			Map of devices attached to JOY0DAT and JOY1DAT
>   			Format: <a>,<b>
> @@ -7009,26 +7032,3 @@
>   				memory, and other data can't be written using
>   				xmon commands.
>   			off	xmon is disabled.
> -
> -	amd_pstate=	[X86]
> -			disable
> -			  Do not enable amd_pstate as the default
> -			  scaling driver for the supported processors
> -			passive
> -			  Use amd_pstate with passive mode as a scaling driver.
> -			  In this mode autonomous selection is disabled.
> -			  Driver requests a desired performance level and platform
> -			  tires to match the same performance level (if it is
> -			  satisfied by guaranteed performance level).
> -			active
> -			  Use amd_pstate_epp driver instance as the scaling driver,
> -			  driver provides a hint to the hardware if software wants
> -			  to bias toward performance (0x0) or energy efficiency (0xff)
> -			  to the CPPC firmware. then CPPC power algorithm will
> -			  calculate the runtime workload and adjust the realtime cores
> -			  frequency.
> -			guided
> -			  Activate guided autonomous mode. Driver requests minimum and
> -			  maximum performance level and the platform autonomously
> -			  selects a performance level in this range and appropriate
> -			  to the current workload.