Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Date:   Fri, 13 Jan 2023 10:04:38 +0300
From:   Dan Carpenter <error27@gmail.com>
To:     Daniel Machon <daniel.machon@microchip.com>
Cc:     netdev@vger.kernel.org, davem@davemloft.net, edumazet@google.com,
        kuba@kernel.org, pabeni@redhat.com, lars.povlsen@microchip.com,
        Steen.Hegelund@microchip.com, UNGLinuxDriver@microchip.com,
        joe@perches.com, horatiu.vultur@microchip.com,
        Julia.Lawall@inria.fr, petrm@nvidia.com, vladimir.oltean@nxp.com,
        maxime.chevallier@bootlin.com,
        linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH net-next 3/6] net: dcb: add new rewrite table
Message-ID: <Y8EChkENXkUjfUQf@kadam>
References: <20230112201554.752144-1-daniel.machon@microchip.com>
 <20230112201554.752144-4-daniel.machon@microchip.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <20230112201554.752144-4-daniel.machon@microchip.com>
Precedence: bulk

On Thu, Jan 12, 2023 at 09:15:51PM +0100, Daniel Machon wrote:
> +/* Get protocol value from rewrite entry. */
> +u16 dcb_getrewr(struct net_device *dev, struct dcb_app *app)
   ^^^

> +{
> +	struct dcb_app_type *itr;
> +	u8 proto = 0;

Should "proto" be a u16 to match itr->app.protocol and the return type?

> +
> +	spin_lock_bh(&dcb_lock);
> +	itr = dcb_rewr_lookup(app, dev->ifindex, -1);
> +	if (itr)
> +		proto = itr->app.protocol;
> +	spin_unlock_bh(&dcb_lock);
> +
> +	return proto;
> +}
> +EXPORT_SYMBOL(dcb_getrewr);
> +
> + /* Add rewrite entry to the rewrite list. */
> +int dcb_setrewr(struct net_device *dev, struct dcb_app *new)
> +{
> +	int err = 0;

No need to initialize this.  It only disables static checkers and
triggers a false positive about dead stores.

> +
> +	spin_lock_bh(&dcb_lock);
> +	/* Search for existing match and abort if found. */
> +	if (dcb_rewr_lookup(new, dev->ifindex, new->protocol)) {
> +		err = -EEXIST;
> +		goto out;
> +	}
> +
> +	err = dcb_app_add(&dcb_rewr_list, new, dev->ifindex);
> +out:
> +	spin_unlock_bh(&dcb_lock);
> +
> +	return err;
> +}

regards,
dan carpenter