Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Message-ID: <916dec5f-5798-047f-37b9-ea4ced426838@linaro.org>
Date:   Fri, 13 Jan 2023 08:59:28 +0100
MIME-Version: 1.0
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101
 Thunderbird/102.6.0
From:   neil.armstrong@linaro.org
Reply-To: neil.armstrong@linaro.org
Subject: Re: [PATCH v2 5/6] arm64: dts: meson-g12a: Fix internal Ethernet PHY
 unit name
Content-Language: en-US
To:     Martin Blumenstingl <martin.blumenstingl@googlemail.com>,
        linux-amlogic@lists.infradead.org
Cc:     linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org,
        khilman@baylibre.com, jbrunet@baylibre.com,
        krzysztof.kozlowski+dt@linaro.org, robh+dt@kernel.org,
        devicetree@vger.kernel.org
References: <20230111211350.1461860-1-martin.blumenstingl@googlemail.com>
 <20230111211350.1461860-6-martin.blumenstingl@googlemail.com>
Organization: Linaro Developer Services
In-Reply-To: <20230111211350.1461860-6-martin.blumenstingl@googlemail.com>
Content-Type: text/plain; charset=UTF-8; format=flowed
Content-Transfer-Encoding: 7bit
Precedence: bulk

On 11/01/2023 22:13, Martin Blumenstingl wrote:
> Documentation/devicetree/bindings/net/ethernet-phy.yaml defines that the
> node name for Ethernet PHYs should match the following pattern:
>    ^ethernet-phy(@[a-f0-9]+)?$
> 
> Replace the underscore with a hyphen to adhere to this binding.
> 
> Fixes: 280c17df8fbf ("arm64: dts: meson: g12a: add mdio multiplexer")
> Signed-off-by: Martin Blumenstingl <martin.blumenstingl@googlemail.com>
> ---
> changes from v1 -> v2:
> - new patch
> 
>   arch/arm64/boot/dts/amlogic/meson-g12-common.dtsi | 2 +-
>   1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/arch/arm64/boot/dts/amlogic/meson-g12-common.dtsi b/arch/arm64/boot/dts/amlogic/meson-g12-common.dtsi
> index 9dbd50820b1c..c95cf3afc666 100644
> --- a/arch/arm64/boot/dts/amlogic/meson-g12-common.dtsi
> +++ b/arch/arm64/boot/dts/amlogic/meson-g12-common.dtsi
> @@ -1694,7 +1694,7 @@ int_mdio: mdio@1 {
>   					#address-cells = <1>;
>   					#size-cells = <0>;
>   
> -					internal_ephy: ethernet_phy@8 {
> +					internal_ephy: ethernet-phy@8 {
>   						compatible = "ethernet-phy-id0180.3301",
>   							     "ethernet-phy-ieee802.3-c22";
>   						interrupts = <GIC_SPI 9 IRQ_TYPE_LEVEL_HIGH>;

Reviewed-by: Neil Armstrong <neil.armstrong@linaro.org>