Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Date:   Fri, 13 Jan 2023 15:23:17 +0700
From:   Bagas Sanjaya <bagasdotme@gmail.com>
To:     Piergiorgio Beruto <piergiorgio.beruto@gmail.com>,
        Andrew Lunn <andrew@lunn.ch>,
        Heiner Kallweit <hkallweit1@gmail.com>,
        Russell King <linux@armlinux.org.uk>,
        "David S. Miller" <davem@davemloft.net>,
        Eric Dumazet <edumazet@google.com>,
        Jakub Kicinski <kuba@kernel.org>,
        Paolo Abeni <pabeni@redhat.com>
Cc:     linux-kernel@vger.kernel.org, netdev@vger.kernel.org,
        Oleksij Rempel <o.rempel@pengutronix.de>,
        mailhol.vincent@wanadoo.fr, sudheer.mogilappagari@intel.com,
        sbhatta@marvell.com, linux-doc@vger.kernel.org,
        wangjie125@huawei.com, corbet@lwn.net, lkp@intel.com,
        gal@nvidia.com, gustavoars@kernel.org
Subject: Re: [PATCH v2 net-next 1/1] plca.c: fix obvious mistake in checking
 retval
Message-ID: <Y8EU9bCLj6UOz7g8@debian.me>
References: <df38c69a85bf528f3e6e672f00be4dc9cdd6298e.1673538908.git.piergiorgio.beruto@gmail.com>
MIME-Version: 1.0
Content-Type: multipart/signed; micalg=pgp-sha512;
        protocol="application/pgp-signature"; boundary="VIr47Z0aK9LAgJcZ"
Content-Disposition: inline
In-Reply-To: <df38c69a85bf528f3e6e672f00be4dc9cdd6298e.1673538908.git.piergiorgio.beruto@gmail.com>
Precedence: bulk


--VIr47Z0aK9LAgJcZ
Content-Type: text/plain; charset=utf-8
Content-Disposition: inline
Content-Transfer-Encoding: quoted-printable

On Thu, Jan 12, 2023 at 04:56:11PM +0100, Piergiorgio Beruto wrote:
> This patch addresses a wrong fix that was done during the review
> process. The intention was to substitute "if(ret < 0)" with
> "if(ret)". Unfortunately, in this specific file the intended fix did not
> meet the code. After additional review, it seems like if(ret < 0) was
> actually the right thing to do. So this patch reverts those changes.

Try to reword the patch description without writing "This patch does foo"
(prefer imperative mood over descriptive one).

Thanks.

--=20
An old man doll... just what I always wanted! - Clara

--VIr47Z0aK9LAgJcZ
Content-Type: application/pgp-signature; name="signature.asc"

-----BEGIN PGP SIGNATURE-----

iHUEARYKAB0WIQSSYQ6Cy7oyFNCHrUH2uYlJVVFOowUCY8EU9QAKCRD2uYlJVVFO
o2pEAQC26U9ol2XV4h5cE+CG9W83NqjHtLfHUUfsguzqUgGkTQEAk9e5Q7GLjpk2
E1kp0cXI/VTE7qrrqtdlKr8ZxCcMLA8=
=ZTq0
-----END PGP SIGNATURE-----

--VIr47Z0aK9LAgJcZ--