Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Date:   Fri, 13 Jan 2023 15:47:31 +0700
From:   Bagas Sanjaya <bagasdotme@gmail.com>
To:     yang.yang29@zte.com.cn, akpm@linux-foundation.org,
        hannes@cmpxchg.org, willy@infradead.org
Cc:     linux-fsdevel@vger.kernel.org, linux-kernel@vger.kernel.org,
        linux-mm@kvack.org, iamjoonsoo.kim@lge.com, ran.xiaokai@zte.com.cn
Subject: Re: [PATCH linux-next v2] swap_state: update shadow_nodes for
 anonymous page
Message-ID: <Y8Eao1l0qRVLKK7e@debian.me>
References: <202301131550455361823@zte.com.cn>
MIME-Version: 1.0
Content-Type: multipart/signed; micalg=pgp-sha512;
        protocol="application/pgp-signature"; boundary="FfqVFWjacRZfxsuZ"
Content-Disposition: inline
In-Reply-To: <202301131550455361823@zte.com.cn>
Precedence: bulk


--FfqVFWjacRZfxsuZ
Content-Type: text/plain; charset=utf-8
Content-Disposition: inline
Content-Transfer-Encoding: quoted-printable

On Fri, Jan 13, 2023 at 03:50:45PM +0800, yang.yang29@zte.com.cn wrote:
> This patch updates shadow_nodes of anonymous page when swap
> cache is add or delete.

By what?

> diff --git a/mm/swap_state.c b/mm/swap_state.c
> index cb9aaa00951d..7a003d8abb37 100644
> --- a/mm/swap_state.c
> +++ b/mm/swap_state.c
> @@ -94,6 +94,8 @@ int add_to_swap_cache(struct folio *folio, swp_entry_t =
entry,
>  	unsigned long i, nr =3D folio_nr_pages(folio);
>  	void *old;
>=20
> +	xas_set_update(&xas, workingset_update_node);
> +
>  	VM_BUG_ON_FOLIO(!folio_test_locked(folio), folio);
>  	VM_BUG_ON_FOLIO(folio_test_swapcache(folio), folio);
>  	VM_BUG_ON_FOLIO(!folio_test_swapbacked(folio), folio);
> @@ -145,6 +147,8 @@ void __delete_from_swap_cache(struct folio *folio,
>  	pgoff_t idx =3D swp_offset(entry);
>  	XA_STATE(xas, &address_space->i_pages, idx);
>=20
> +	xas_set_update(&xas, workingset_update_node);
> +
>  	VM_BUG_ON_FOLIO(!folio_test_locked(folio), folio);
>  	VM_BUG_ON_FOLIO(!folio_test_swapcache(folio), folio);
>  	VM_BUG_ON_FOLIO(folio_test_writeback(folio), folio);
> @@ -252,6 +256,8 @@ void clear_shadow_from_swap_cache(int type, unsigned =
long begin,
>  		struct address_space *address_space =3D swap_address_space(entry);
>  		XA_STATE(xas, &address_space->i_pages, curr);
>=20
> +		xas_set_update(&xas, workingset_update_node);
> +
>  		xa_lock_irq(&address_space->i_pages);
>  		xas_for_each(&xas, old, end) {
>  			if (!xa_is_value(old))

Adding xas_set_update() call?

In any case, please explain what you are doing above in imperative mood
(no "This patch does foo" but "Do foo" instead).

Thanks.

--=20
An old man doll... just what I always wanted! - Clara

--FfqVFWjacRZfxsuZ
Content-Type: application/pgp-signature; name="signature.asc"

-----BEGIN PGP SIGNATURE-----

iHUEARYKAB0WIQSSYQ6Cy7oyFNCHrUH2uYlJVVFOowUCY8EangAKCRD2uYlJVVFO
o/BdAQDMnNlScYe1V+iOgxiyUqa+4s6U6CuxgqAm32d4eSqx3AEAlj1BCKBcygkF
cWXy2GN8ry6qwub9QEaS1RFWFhC6Ews=
=a99s
-----END PGP SIGNATURE-----

--FfqVFWjacRZfxsuZ--