Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Message-ID: <2f653f1c-161c-57d2-b3c7-f21ded261938@paragon-software.com>
Date:   Fri, 13 Jan 2023 13:44:48 +0400
MIME-Version: 1.0
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101
 Thunderbird/102.6.0
Subject: Re: [PATCH] fs/ntfs3: Fix error handling in ntfs_new_inode()
Content-Language: en-US
To:     Shigeru Yoshida <syoshida@redhat.com>
CC:     <ntfs3@lists.linux.dev>, <linux-kernel@vger.kernel.org>
References: <20230104123902.978084-1-syoshida@redhat.com>
From:   Konstantin Komarov <almaz.alexandrovich@paragon-software.com>
In-Reply-To: <20230104123902.978084-1-syoshida@redhat.com>
Content-Type: text/plain; charset="UTF-8"; format=flowed
Content-Transfer-Encoding: 7bit
Precedence: bulk

On 04.01.2023 16:39, Shigeru Yoshida wrote:
> When memory allocation for mi->mrec fails, ntfs_new_inode() calls
> iput().  iput() calls ni_write_inode() indirectly, it references
> uninitialized mi->mrec, and this causes the kernel crash.  This patch
> fixes the issue by making the inode bad before calling iput().
>
> Signed-off-by: Shigeru Yoshida <syoshida@redhat.com>
> ---
>   fs/ntfs3/fsntfs.c | 1 +
>   1 file changed, 1 insertion(+)
>
> diff --git a/fs/ntfs3/fsntfs.c b/fs/ntfs3/fsntfs.c
> index 567563771bf8..7b93f2aeb6f6 100644
> --- a/fs/ntfs3/fsntfs.c
> +++ b/fs/ntfs3/fsntfs.c
> @@ -1683,6 +1683,7 @@ struct ntfs_inode *ntfs_new_inode(struct ntfs_sb_info *sbi, CLST rno, bool dir)
>   
>   out:
>   	if (err) {
> +		_ntfs_bad_inode(inode);
>   		iput(inode);
>   		ni = ERR_PTR(err);
>   	}

Hello.

This bug have been already fixed by Ye Bin 
(https://lore.kernel.org/lkml/20221117091912.3436127-1-yebin@huaweicloud.com/).

  * Thanks for your work.