Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Message-ID: <2d656d51-a0ce-88bc-529e-e254defdc421@suse.cz>
Date:   Fri, 13 Jan 2023 12:20:52 +0100
MIME-Version: 1.0
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101
 Thunderbird/102.6.1
Subject: Re: [PATCH V2] mm/slab.c: Delete the if statement
Content-Language: en-US
To:     David Rientjes <rientjes@google.com>, lvqian <lvqian@nfschina.com>
Cc:     cl@linux.co, penberg@kernel.org, kim@lge.com,
        akpm@linux-foundation.org, roman.gushchin@linux.dev,
        42.hyeyoo@gmail.com, linux-mm@kvack.org,
        linux-kernel@vger.kernel.org
References: <20230111092744.112038-1-lvqian@nfschina.com>
 <1848b8d7-f40e-1851-b2b1-68c3df8f0bb7@google.com>
From:   Vlastimil Babka <vbabka@suse.cz>
In-Reply-To: <1848b8d7-f40e-1851-b2b1-68c3df8f0bb7@google.com>
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 7bit
Precedence: bulk

On 1/13/23 00:53, David Rientjes wrote:
> On Wed, 11 Jan 2023, lvqian@nfschina.com wrote:
> 
>> From: lvqian <lvqian@nfschina.com>
>> 
>> 	Remove the if statement to increase code readability.
>> 
>> Signed-off-by: lvqian <lvqian@nfschina.com>
> 
> Acked-by: David Rientjes <rientjes@google.com>
> 
> Will rely on Vlastimil to remove the spurious tab in the commit 
> description.

Right, also changed subject to:
mm/slab.c: cleanup is_debug_pagealloc_cache()

Function could be inline, but no strong preference.

Good point, did that too.

Added to
slab/for-6.3/cleanups

Thanks.