Received: by 2002:a05:6358:a55:b0:ec:fcf4:3ecf with SMTP id 21csp753177rwb; Fri, 13 Jan 2023 03:52:50 -0800 (PST) X-Google-Smtp-Source: AMrXdXsOD9kHJ14lYinGXtYh9bXdX15ljUYaFi1nTaTSyIGrbfwhsq7N7UGCN8aHXAaK4/z79ClD X-Received: by 2002:a17:906:6b86:b0:86b:6a02:3187 with SMTP id l6-20020a1709066b8600b0086b6a023187mr779257ejr.71.1673610770315; Fri, 13 Jan 2023 03:52:50 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1673610770; cv=none; d=google.com; s=arc-20160816; b=Aeo+EYru96FDG6RLHIsua2UD+d0iedLDf7n8D34h1tWT29h62ouCc7GeDDaTgA2l6c VBooXs1iRXYnIOZu9m+PX6qD2kRMcbr6DrnMhCE8ia18LI2WbPOmn9IupOv1fpRbGZV6 amtluJ7csjiM1fVFpR8UDyivtgpQOmlAexxXzheWtD3asiyx9XQozfRPYeXiqkD2AcTU EDFq494GPfZ1yhpATbafFxOdVB36pbSmF+LJB1Si2B8j83Z1r/AIA7IeYjdsKjh8lJ77 I4sW1eQzFHXsSEuVphwTlX+oDxW/AlYz8EWQ1WXPFBnTs4u4cTU9i0hUUcrNQEgFZP+G Nusg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:in-reply-to:content-disposition:mime-version :references:message-id:subject:cc:to:from:date:dkim-signature; bh=3vRfHiLfrkhVRWh8Q836T2oAvikTr6SSM9QK64azLu0=; b=ROn2o9Ojo6X1mMa0TBnCrvc+7LBk3qx10jABNtlLrcZfJQR6Wf4ZQBwS7/KtfWnhgO FNBI858UldAYAldnqMd40aYni9mfIHoEwZhT5HBb/WCmTK4efvQhCXg1y+PWnRF750ip BJ3TRbOQSMNfwJm/Qg1pXF+oTjWPt0MfbW+1IGFLZZw2ijeBreCRSrTDvWyGJJFIskBt kX1YRZN8OJbh92mKGiec50o0XH0lRJvENRwzkWYESnCmrsg+dwE3ZrUtr6f7BZkYEqff fP96CdFLmBqZOeBQ6ZWflRimmzA6xEvrQBWamHa7tEmugscO92Rx9WWr7GfjellZj3bV 6VDw== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@infradead.org header.s=casper.20170209 header.b=oCsjbMHx; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from out1.vger.email (out1.vger.email. [2620:137:e000::1:20]) by mx.google.com with ESMTP id sh15-20020a1709076e8f00b008379ac04127si21714903ejc.199.2023.01.13.03.52.37; Fri, 13 Jan 2023 03:52:50 -0800 (PST) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20; Authentication-Results: mx.google.com; dkim=pass header.i=@infradead.org header.s=casper.20170209 header.b=oCsjbMHx; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S241251AbjAMLfr (ORCPT + 51 others); Fri, 13 Jan 2023 06:35:47 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:53746 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S241252AbjAMLfI (ORCPT ); Fri, 13 Jan 2023 06:35:08 -0500 Received: from casper.infradead.org (casper.infradead.org [IPv6:2001:8b0:10b:1236::1]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id B03867FEF6; Fri, 13 Jan 2023 03:21:15 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=infradead.org; s=casper.20170209; h=In-Reply-To:Content-Type:MIME-Version: References:Message-ID:Subject:Cc:To:From:Date:Sender:Reply-To: Content-Transfer-Encoding:Content-ID:Content-Description; bh=3vRfHiLfrkhVRWh8Q836T2oAvikTr6SSM9QK64azLu0=; b=oCsjbMHx33bOAX4Tv4zwpoNCZ6 ovcZmpwpYf3viEaCmWRW1NjHS5BElLNn1CYHwWZWXf3pTtgLXKIu8GwzSuaV09b6XBhOyrMKufQQk yRIRjZX3u8LpQjJInVH763XEP5XYL1JljGVBD3AkCYeY8uj2JsFHPaslEQQajitHyRv0M5HnahN+d yyXUqPZWC+AqB4hukGLV9YpXDWYQIG/8L2vMIStio0Ur1lLnUYE0bsCmJdgxVriPy/x5zg+ohZ/py nD83bKZoyz2MtKvMX5iEGtVOOxRCMKi/i4afyUhvUnmfmtSN+Ko8vy2tsG+dStL9dYZ9hWCbGfbnT CmC1ij5w==; Received: from j130084.upc-j.chello.nl ([24.132.130.84] helo=noisy.programming.kicks-ass.net) by casper.infradead.org with esmtpsa (Exim 4.94.2 #2 (Red Hat Linux)) id 1pGI7f-0062lE-Ma; Fri, 13 Jan 2023 11:21:23 +0000 Received: from hirez.programming.kicks-ass.net (hirez.programming.kicks-ass.net [192.168.1.225]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits)) (Client did not present a certificate) by noisy.programming.kicks-ass.net (Postfix) with ESMTPS id 65E413001F7; Fri, 13 Jan 2023 12:21:10 +0100 (CET) Received: by hirez.programming.kicks-ass.net (Postfix, from userid 1000) id 564F62CCEBAD8; Fri, 13 Jan 2023 12:21:10 +0100 (CET) Date: Fri, 13 Jan 2023 12:21:10 +0100 From: Peter Zijlstra To: Namhyung Kim Cc: Ingo Molnar , Mark Rutland , Alexander Shishkin , Arnaldo Carvalho de Melo , Jiri Olsa , LKML , Song Liu , bpf@vger.kernel.org Subject: Re: [PATCHSET 0/8] perf/core: Prepare sample data for BPF Message-ID: References: <20230112214015.1014857-1-namhyung@kernel.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20230112214015.1014857-1-namhyung@kernel.org> X-Spam-Status: No, score=-4.4 required=5.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,RCVD_IN_DNSWL_MED,SPF_HELO_NONE, SPF_NONE autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Thu, Jan 12, 2023 at 01:40:07PM -0800, Namhyung Kim wrote: > Namhyung Kim (8): > perf/core: Save the dynamic parts of sample data size > perf/core: Add perf_sample_save_callchain() helper > perf/core: Add perf_sample_save_raw_data() helper > perf/core: Add perf_sample_save_brstack() helper > perf/core: Set data->sample_flags in perf_prepare_sample() > perf/core: Do not pass header for sample id init > perf/core: Introduce perf_prepare_header() > perf/core: Call perf_prepare_sample() before running BPF Aside from a few small niggles, this looks really good, Thanks!