Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Message-ID: <608756bb-3012-e02c-5b16-04314cdc9889@intel.com>
Date:   Fri, 13 Jan 2023 12:25:48 +0100
User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:102.0) Gecko/20100101
 Thunderbird/102.6.1
Subject: Re: [PATCH rcu v2 15/20] kernel/notifier: Remove CONFIG_SRCU
To:     "Paul E. McKenney" <paulmck@kernel.org>, <rcu@vger.kernel.org>
CC:     <linux-kernel@vger.kernel.org>, <kernel-team@meta.com>,
        <rostedt@goodmis.org>,
        =?UTF-8?B?TWljaGHFgiBNaXJvc8WCYXc=?= <mirq-linux@rere.qmqm.pl>,
        Borislav Petkov <bp@suse.de>,
        Alan Stern <stern@rowland.harvard.edu>,
        John Ogness <john.ogness@linutronix.de>
References: <20230113001103.GA3374173@paulmck-ThinkPad-P17-Gen-1>
 <20230113001132.3375334-15-paulmck@kernel.org>
Content-Language: en-US
From:   "Wysocki, Rafael J" <rafael.j.wysocki@intel.com>
In-Reply-To: <20230113001132.3375334-15-paulmck@kernel.org>
Content-Type: text/plain; charset="UTF-8"; format=flowed
Content-Transfer-Encoding: 8bit
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?MGdhQ2dmZngrY1YyZmt2bDRjeDBmLzZ5WTdlNUJaVmlUemRtRHNKaFRJbngr?=
 =?utf-8?B?dGZSWm5UZy9oR2pzMks3VTdDWVJVaTdmRkprQ1I3YlJJZ1N0a2R1UDc2UXBn?=
 =?utf-8?B?NUpBdXNIMmpmMWdpVEs2UUxrWWltOUFkaWwrRGpueU1DbllmV3NYUXcxQVpm?=
 =?utf-8?B?YjFRdHNKSW55aGlYeUR5dmFkWDRoMURrdTNiWXBOY3ZEWnVWc2tlaHZITkxR?=
 =?utf-8?B?VzR1STU3dnlNM1lkb1cwckRnamJuVHl4TFg3U2orQm9LaUdWWlhtQ1p5cWZI?=
 =?utf-8?B?ZnRYKythRFhBRVo3a3pBNXFhMjRRYTBZWEtQdG1pNnZOdXJOOXJYUjBRNmEx?=
 =?utf-8?B?eDk4c0JLeldtaitObnhGbWFYNUVWb3ZyL0VpK0VFSlZLWUdWZ3ZuT2tXSXJk?=
 =?utf-8?B?eVpIa3V1TFJnSFd3SGNhb1FSRmhBZUtXb3liNm5WRFQ3b1Y1cU1EbFhsSUpt?=
 =?utf-8?B?dlM5aTh5aVZpZjVEU2ZzSngwMjNZbUo1Nk0xMnVNK1FzV1JCbWMxczdLWjBv?=
 =?utf-8?B?ZDZ2MFhYYkRHZkEzT0o5QU5iQ2M5LzRLamZldU83VDJlMmJtRkZUTkE0ZE1H?=
 =?utf-8?B?NHdvVnkzcnp1ZmNnT0g5V3BubzJuS05VZlBEYTNJaWJyQjh5T2hVRzV4MDhH?=
 =?utf-8?B?Y05mdjJqRWxaa3dnQnFyTFpNOWJtd1hUWXJqNEQzdzFHTFVUU21BcjVhU0Nx?=
 =?utf-8?B?eUhaT0FqR3E2T0ZJSDVyQml0anhsa1V2djM0cWZqUXg5MjlKTUtWK29DdU9K?=
 =?utf-8?B?L3ByMXZPMlBadFVEMUxWemxsejlGWXBITGRyc2JTUzloNmtMVXRyR1BqTVFD?=
 =?utf-8?B?UFZ3TmNQeFBWcW1GUVR5bHNVQjJLN0dua1dRQjlyRXhWeU1NSW5vZWYybFph?=
 =?utf-8?B?NENXb2Z6VnhGTmxsZUVhTzBvd3F3LzBFVVJOUktiUVZqbU4xRmF3UWdnSXMr?=
 =?utf-8?B?bldoay9uNFZna0lBRC9zTzFhZEk0ZFB6cHVTczRmaEdabVVBT29XTW9ETlFh?=
 =?utf-8?B?WkhMZzVjRnh6cjJoVGRXR1drWmQ1ZUtGdDZoWkdaak1NcW92cmZnWEQyb0Nq?=
 =?utf-8?B?bGtKOG9kUFdTdTEvRk9tTXFwZlRXWG1EVTdDcnprQmYvc0RTekpzS2VmY3RI?=
 =?utf-8?B?QytFYTljZ2h2T29IK25OdnA0L0tFNHFyZzlVV1d1U3d5dmRUTzBrK3RxUk9h?=
 =?utf-8?B?WTQrdGtNU2I2WTdmWVZoSHZuRkI2cTcyR2FUek94eEFNSzZqbmtnYTI2RWZV?=
 =?utf-8?B?KzhnOGROUVpaM0lPUnhnUUpOR0JTWWJkNmptekdtMDB2SzhxRERZa0xvalBE?=
 =?utf-8?B?MDJUclhIVnlqM2tkcGhMcVBCY2o5YTE4b2hxYlEyVGlIUUVKN1pGZ3B1dm43?=
 =?utf-8?B?bXdqd3V1enNJNXp1cXFqN3dDZmNmR052UUpEdzZ1U2tHV1RaNWl1dnRrT0FT?=
 =?utf-8?B?MnNrc1huSWRxU0gyOXV0L1gvYWJqRFF5cnQvajYyOUVOMHZEc2U0RzFmeFRs?=
 =?utf-8?B?aHc2dGxDRWN6WHpKdDRkYXlodXkzaUN2OXd3WnhWb29wOEI5YU1idHZ5RENs?=
 =?utf-8?B?b3VGaWcvcG94c3JJa0kyclNpQ3E2Z2lCNnF0YWlEUmJTeGsvMzBwVVpVZFNz?=
 =?utf-8?B?NHVueGVLbDQrSW9oeW92NnRvN2Y2dG5DUWphcGkwZStYTkl3d2RJYXJZQnRt?=
 =?utf-8?B?NzdNRFFDNjdUbkRzaEhBREg3SjVFR09LWDNpclEvaTJHSktPMHV1Y0Q4QVV1?=
 =?utf-8?B?cnZEdzN6d01ORjUrd1FkMldIQXBWSE1EN1V5SXVKZFk1UmMwWHlPejVjWkNr?=
 =?utf-8?B?MzhxSlBPcnU4cURpblZIREdaVVVSWEJvRDcvenNqcHorODVWNStWRUIxN281?=
 =?utf-8?B?UHdUV2JjL0s4Vzh5MWxUZFdldUY3cGdIVkhscXl0dnZTeU5WM2g1ZGE1VGk5?=
 =?utf-8?B?OWVxalZmQVErVzVkV2hqZ1dTV1p2eGVwNVhvZTFOQXZHdXFlTGpLaHpsZExU?=
 =?utf-8?B?cTFzakhlcGdUazNHR09ScDd3NGpTdmpPenRyL3pHQUpLRTN0ZXYvRmhSb1dy?=
 =?utf-8?B?L3FXNllYUFViZkhWbkQyMjFDQUR1T21EY1c1M1YyQjFNRisxL0JtZEU4Vjkz?=
 =?utf-8?B?Vzh2MDZlVHZTR3g5YWxaeE85TVBnWlJuc041SVNPZy96K1RFc2tGUUNsTnBY?=
 =?utf-8?B?WGc9PQ==?=
X-MS-Exchange-CrossTenant-Network-Message-Id: 3d819a7c-768e-4711-6a92-08daf558efed
X-MS-Exchange-CrossTenant-AuthSource: SA1PR11MB5825.namprd11.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 13 Jan 2023 11:25:56.1037
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 46c98d88-e344-4ed4-8496-4ed7712e255d
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: H6DXRf9z12u0Wd9zEWDvdTRZFWpshdfr2QpsmzhOVyjrIi43ni3xJiTSkuvosteXQy6EPO3OXpb7+xG1Gz2pxwdniVJ2vNQhI2PSxbtzmRY=
X-MS-Exchange-Transport-CrossTenantHeadersStamped: DM6PR11MB4627
X-OriginatorOrg: intel.com
X-Spam-Status: No, score=-4.4 required=5.0 tests=BAYES_00,DKIMWL_WL_HIGH,
        DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,NICE_REPLY_A,
        RCVD_IN_DNSWL_MED,SPF_HELO_NONE,SPF_NONE autolearn=ham
        autolearn_force=no version=3.4.6
X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on
        lindbergh.monkeyblade.net
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org


On 1/13/2023 1:11 AM, Paul E. McKenney wrote:
> Now that the SRCU Kconfig option is unconditionally selected, there is
> no longer any point in conditional compilation based on CONFIG_SRCU.
> Therefore, remove the #ifdef.
>
> Signed-off-by: Paul E. McKenney <paulmck@kernel.org>
> Cc: "Rafael J. Wysocki" <rafael.j.wysocki@intel.com>
> Cc: "Michał Mirosław" <mirq-linux@rere.qmqm.pl>
> Cc: Borislav Petkov <bp@suse.de>
> Cc: Alan Stern <stern@rowland.harvard.edu>
> Reviewed-by: John Ogness <john.ogness@linutronix.de>

Acked-by: Rafael J. Wysocki <rafael.j.wysocki@intel.com>


> ---
>   kernel/notifier.c | 3 ---
>   1 file changed, 3 deletions(-)
>
> diff --git a/kernel/notifier.c b/kernel/notifier.c
> index ab75637fd904f..d353e4b5402d7 100644
> --- a/kernel/notifier.c
> +++ b/kernel/notifier.c
> @@ -456,7 +456,6 @@ int raw_notifier_call_chain(struct raw_notifier_head *nh,
>   }
>   EXPORT_SYMBOL_GPL(raw_notifier_call_chain);
>   
> -#ifdef CONFIG_SRCU
>   /*
>    *	SRCU notifier chain routines.    Registration and unregistration
>    *	use a mutex, and call_chain is synchronized by SRCU (no locks).
> @@ -573,8 +572,6 @@ void srcu_init_notifier_head(struct srcu_notifier_head *nh)
>   }
>   EXPORT_SYMBOL_GPL(srcu_init_notifier_head);
>   
> -#endif /* CONFIG_SRCU */
> -
>   static ATOMIC_NOTIFIER_HEAD(die_chain);
>   
>   int notrace notify_die(enum die_val val, const char *str,