Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
MIME-Version: 1.0
References: <20230110110052.14851-1-sinthu.raja@ti.com> <20230110110052.14851-3-sinthu.raja@ti.com>
 <d109dbf8-ba51-7322-34e7-f688c5a18908@ti.com>
In-Reply-To: <d109dbf8-ba51-7322-34e7-f688c5a18908@ti.com>
From:   Sinthu Raja M <sinthu.raja@mistralsolutions.com>
Date:   Fri, 13 Jan 2023 17:56:44 +0530
Message-ID: <CAEd-yTQ9eEz_Q6ncNP3vc9oerqiXfhrGK7DvsAnm21OZzYUe2w@mail.gmail.com>
Subject: Re: [RESEND PATCH V3 2/3] arm64: dts: ti: Add initial support for
 AM68 SK System on Module
To:     Vaishnav Achath <vaishnav.a@ti.com>
Cc:     Nishanth Menon <nm@ti.com>, Tero Kristo <kristo@kernel.org>,
        Rob Herring <robh+dt@kernel.org>,
        Vignesh Raghavendra <vigneshr@ti.com>,
        Krzysztof Kozlowski <krzysztof.kozlowski+dt@linaro.org>,
        linux-arm-kernel@lists.infradead.org, devicetree@vger.kernel.org,
        linux-kernel@vger.kernel.org, Sinthu Raja <sinthu.raja@ti.com>
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: quoted-printable
Precedence: bulk

On Fri, Jan 13, 2023 at 5:24 PM Vaishnav Achath <vaishnav.a@ti.com> wrote:
>
> Hi Sinthu,
>
> On 10/01/23 16:30, Sinthu Raja wrote:
> > From: Sinthu Raja <sinthu.raja@ti.com>
> >
> > AM68 Starter Kit (SK) is a low cost, small form factor board designed
> > for TI=E2=80=99s AM68 SoC. TI=E2=80=99s AM68 SoC comprises of dual core=
 A72, high
> > performance vision accelerators, hardware accelerators, latest C71x
> > DSP, high bandwidth real-time IPs for capture and display. The SoC is
> > power optimized to provide best in class performance for industrial
> > applications.
> >
> >     AM68 SK supports the following interfaces:
> >       * 16 GB LPDDR4 RAM
> >       * x1 Gigabit Ethernet interface
> >       * x1 USB 3.1 Type-C port
> >       * x2 USB 3.1 Type-A ports
> >       * x1 PCIe M.2 M Key
> >       * 512 Mbit OSPI flash
> >       * x2 CSI2 Camera interface (RPi and TI Camera connector)
> >       * 40-pin Raspberry Pi GPIO header
> >
> > SK's System on Module (SoM) contains the SoC and DDR.
> > Therefore, add DT node for the SOC and DDR on the SoM.
> >
> > Schematics: https://www.ti.com/lit/zip/SPRR463
> > TRM: http://www.ti.com/lit/pdf/spruj28
> >
> > Signed-off-by: Sinthu Raja <sinthu.raja@ti.com>
> > ---
> >
> > Changes in V3:
> > =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D
> > Addressed review comments
> >  - Removed the unused nodes that are disabled by default.
> > OSPI support will be added once the OSPI node is enabled for J721s2/AM6=
8 in main DTSI.
> >
> > Changes in V2:
> > =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D
> > Address review comments
> >  - drop the empty lines.
> >
> > V1: https://lore.kernel.org/linux-arm-kernel/20221018123849.23695-3-sin=
thu.raja@ti.com/
> > V2: https://lore.kernel.org/lkml/20221107123852.8063-3-sinthu.raja@ti.c=
om/
> >
> >  arch/arm64/boot/dts/ti/k3-am68-sk-som.dtsi | 31 ++++++++++++++++++++++
> >  1 file changed, 31 insertions(+)
> >  create mode 100644 arch/arm64/boot/dts/ti/k3-am68-sk-som.dtsi
> >
> > diff --git a/arch/arm64/boot/dts/ti/k3-am68-sk-som.dtsi b/arch/arm64/bo=
ot/dts/ti/k3-am68-sk-som.dtsi
> > new file mode 100644
> > index 000000000000..c35f81edee8c
> > --- /dev/null
> > +++ b/arch/arm64/boot/dts/ti/k3-am68-sk-som.dtsi
> > @@ -0,0 +1,31 @@
> > +// SPDX-License-Identifier: GPL-2.0
> > +/*
> > + * Copyright (C) 2023 Texas Instruments Incorporated - https://www.ti.=
com/
> > + */
> > +
> > +/dts-v1/;
> > +
> > +#include "k3-j721s2.dtsi"
> > +#include <dt-bindings/gpio/gpio.h>
> > +
> > +/ {
> > +     memory@80000000 {
> > +             device_type =3D "memory";
> > +             /* 16 GB RAM */
> > +             reg =3D <0x00 0x80000000 0x00 0x80000000>,
> > +                   <0x08 0x80000000 0x03 0x80000000>;
> > +     };
> > +
> > +     /* Reserving memory regions still pending */
>
> Is this comment needed?
>
> > +     reserved_memory: reserved-memory {
> > +             #address-cells =3D <2>;
> > +             #size-cells =3D <2>;
> > +             ranges;
> > +
> > +             secure_ddr: optee@9e800000 {
> > +                     reg =3D <0x00 0x9e800000 0x00 0x01800000>;
> > +                     alignment =3D <0x1000>;
>
> Is alignment needed here?
This is used to mention the address boundary. Removing this will
affect memory allocation. Isn't so?
>
>
> Please see https://lore.kernel.org/lkml/cd5dbbb0-2d9f-8d7d-b051-f8d01d710=
c62@ti.com/
>
> > +                     no-map;
> > +             };
> > +     };
> > +};
>
> --
> Regards,
> Vaishnav


--=20
With Regards
Sinthu Raja