Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
MIME-Version: 1.0
References: <20230104141245.8407-1-aford173@gmail.com> <CAMuHMdWuE4L6K4ULdVLZKeLwd3xYfzkyBNrf6s7Qc2kf9b-_Cg@mail.gmail.com>
 <CAHCN7xKJRE7mrRgpKiEEgpkH1NLR8uGcc3mr5Khp3sWjxEtbdQ@mail.gmail.com>
In-Reply-To: <CAHCN7xKJRE7mrRgpKiEEgpkH1NLR8uGcc3mr5Khp3sWjxEtbdQ@mail.gmail.com>
From:   Adam Ford <aford173@gmail.com>
Date:   Fri, 13 Jan 2023 07:17:00 -0600
Message-ID: <CAHCN7xLSgrzxL0W0ue7wi8DBCH-EB574QtS6wsyrVNpHDFiE6Q@mail.gmail.com>
Subject: Re: [PATCH 1/4] arm64: dts: beacon-renesom: Fix gpio expander reference
To:     Geert Uytterhoeven <geert@linux-m68k.org>
Cc:     linux-renesas-soc@vger.kernel.org, aford@beaconembedded.com,
        Magnus Damm <magnus.damm@gmail.com>,
        Rob Herring <robh+dt@kernel.org>,
        Krzysztof Kozlowski <krzysztof.kozlowski+dt@linaro.org>,
        devicetree@vger.kernel.org, linux-kernel@vger.kernel.org
Content-Type: text/plain; charset="UTF-8"
Precedence: bulk

On Wed, Jan 11, 2023 at 11:05 AM Adam Ford <aford173@gmail.com> wrote:
>
> On Wed, Jan 11, 2023 at 10:29 AM Geert Uytterhoeven
> <geert@linux-m68k.org> wrote:
> >
> > Hi Adam,
> >
> > On Wed, Jan 4, 2023 at 3:12 PM Adam Ford <aford173@gmail.com> wrote:
> > > The board used to originally introduce the Beacon Embedded
> > > RZ/G2[M/N/H] boards had a GPIO expander with address 20, but
> > > this was change when the final board went to production.
> > >
> > > The production boards changed both the part itself and
> > > the address.  With the incorrect address, the LCD cannot
> > > come up.  If the LCD fails, the rcar-du driver fails to come up,
> > > and that also breaks HDMI.
> > >
> > > Pre-release board were not shipped to the general public, so it
> > > should be safe to push this as a fix.  Anyone with a production
> > > board would have video fail due to this GPIO expander change.
> > >
> > > Fixes: a1d8a344f1ca ("arm64: dts: renesas: Introduce r8a774a1-beacon-rzg2m-kit")
> > > Signed-off-by: Adam Ford <aford173@gmail.com>
> >
> > Thanks for your patch!
> >
> > > --- a/arch/arm64/boot/dts/renesas/beacon-renesom-baseboard.dtsi
> > > +++ b/arch/arm64/boot/dts/renesas/beacon-renesom-baseboard.dtsi
> > > @@ -437,20 +437,6 @@ wm8962_endpoint: endpoint {
> > >                 };
> > >         };
> > >
> > > -       /* 0 - lcd_reset */
> > > -       /* 1 - lcd_pwr */
> > > -       /* 2 - lcd_select */
> > > -       /* 3 - backlight-enable */
> > > -       /* 4 - Touch_shdwn */
> > > -       /* 5 - LCD_H_pol */
> > > -       /* 6 - lcd_V_pol */
> > > -       gpio_exp1: gpio@20 {
> > > -               compatible = "onnn,pca9654";
> > > -               reg = <0x20>;
> > > -               gpio-controller;
> > > -               #gpio-cells = <2>;
> > > -       };
> > > -
> > >         touchscreen@26 {
> > >                 compatible = "ilitek,ili2117";
> > >                 reg = <0x26>;
> > > @@ -482,6 +468,21 @@ hd3ss3220_out_ep: endpoint {
> > >                         };
> > >                 };
> > >         };
> > > +
> > > +       gpio_exp1: gpio@70 {
> > > +               compatible = "onnn,pca9654";
> >
> > According to the patch description, the actual part was changed, too?

After a bit of some investigation, the part was changed to
nxp,pca9538.  It appears to be the same driver and the same ".data"
structure is used.  This probably explains why I didn't see any issues
when I was testing this.  Unfortunately, the hardware engineer who
made this hardware change is not around to ask why the change was
made.    I'll do a V2 since, I don't see this in renesas-devel.

adam
>
> humm.. I was under the impression it was after talking with one of the
> hardware developers, but clearly it's using the same compatible name.
> I will investigate this further.  One way or the other, I'll redo the
> commit message.
>
> adam
> >
> > > +               reg = <0x70>;
> > > +               gpio-controller;
> > > +               #gpio-cells = <2>;
> > > +               gpio-line-names =
> > > +                       "lcd_reset",
> > > +                       "lcd_pwr",
> > > +                       "lcd_select",
> > > +                       "backlight-enable",
> > > +                       "Touch_shdwn",
> > > +                       "LCD_H_pol",
> > > +                       "lcd_V_pol";
> > > +       };
> > >  };
> >
> > The rest LGTM.
> >
> > Gr{oetje,eeting}s,
> >
> >                         Geert
> >
> > --
> > Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@linux-m68k.org
> >
> > In personal conversations with technical people, I call myself a hacker. But
> > when I'm talking to journalists I just say "programmer" or something like that.
> >                                 -- Linus Torvalds