Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Date:   Fri, 13 Jan 2023 14:26:58 +0100
From:   Piergiorgio Beruto <piergiorgio.beruto@gmail.com>
To:     Bagas Sanjaya <bagasdotme@gmail.com>
Cc:     Andrew Lunn <andrew@lunn.ch>,
        Heiner Kallweit <hkallweit1@gmail.com>,
        Russell King <linux@armlinux.org.uk>,
        "David S. Miller" <davem@davemloft.net>,
        Eric Dumazet <edumazet@google.com>,
        Jakub Kicinski <kuba@kernel.org>,
        Paolo Abeni <pabeni@redhat.com>, linux-kernel@vger.kernel.org,
        netdev@vger.kernel.org, Oleksij Rempel <o.rempel@pengutronix.de>,
        mailhol.vincent@wanadoo.fr, sudheer.mogilappagari@intel.com,
        sbhatta@marvell.com, linux-doc@vger.kernel.org,
        wangjie125@huawei.com, corbet@lwn.net, lkp@intel.com,
        gal@nvidia.com, gustavoars@kernel.org
Subject: Re: [PATCH v2 net-next 1/1] plca.c: fix obvious mistake in checking
 retval
Message-ID: <Y8FcImfvUAVa4NoB@gvm01>
References: <df38c69a85bf528f3e6e672f00be4dc9cdd6298e.1673538908.git.piergiorgio.beruto@gmail.com>
 <Y8EU9bCLj6UOz7g8@debian.me>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <Y8EU9bCLj6UOz7g8@debian.me>
Precedence: bulk

On Fri, Jan 13, 2023 at 03:23:17PM +0700, Bagas Sanjaya wrote:
> On Thu, Jan 12, 2023 at 04:56:11PM +0100, Piergiorgio Beruto wrote:
> > This patch addresses a wrong fix that was done during the review
> > process. The intention was to substitute "if(ret < 0)" with
> > "if(ret)". Unfortunately, in this specific file the intended fix did not
> > meet the code. After additional review, it seems like if(ret < 0) was
> > actually the right thing to do. So this patch reverts those changes.
> 
> Try to reword the patch description without writing "This patch does foo"
> (prefer imperative mood over descriptive one).
> 
> Thanks.
> 
> -- 
> An old man doll... just what I always wanted! - Clara
Fixed. Thanks.