Received: by 2002:a05:6358:a55:b0:ec:fcf4:3ecf with SMTP id 21csp920009rwb; Fri, 13 Jan 2023 05:57:23 -0800 (PST) X-Google-Smtp-Source: AMrXdXvJG92NEk92SJjud3+NaCpE2pCdn/6OERUfTI/Vx5LmJbv3ZXk2lrK8UOTRPaZheiXnJN9r X-Received: by 2002:a17:902:db08:b0:194:5d2d:3c31 with SMTP id m8-20020a170902db0800b001945d2d3c31mr9259125plx.11.1673618243368; Fri, 13 Jan 2023 05:57:23 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1673618243; cv=none; d=google.com; s=arc-20160816; b=F8HY/g21JlTt9ElwZG64ympRD4MYfq9cg8GfljEHZ4MrBJlcWT9vNIV3wLBk2e86pq exJrxFqtezXuioYS3ATn1DG+Zafte1ZoREN9ehylSAEVEMd1cc+QLL81XKv7lYSzLmkO 3GuTtQsozGrmCL+/RzGizjRjnN8nWCD61jaDJVoEAq1HI4Kv/xh41CFly6rvdZW+tPJW y/FWZkkx7VpQui/XT2CtofC5zOd4q4MdlDjpxq3Qy76xgpUNYBxm8Z48DAdBx1jeXb+g lvokCyqJOyeepI2ltUtv8Q6mPaCh9gNsrbca8vNsIwqGEPzsa66xSyhDwnuAdeeOazK4 DnMQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:mime-version:message-id:date:references :in-reply-to:subject:cc:to:from:dkim-signature; bh=SIimS6dlFX7jkCJ504BScuOul7TISPli5vt+Yekfd2g=; b=Wn8g2TfmX1YomrfUp+vj+7Fw2Au0i7RHykKX+yityYXq+a7zFp5m43l5KC2cQ6+SGk U3epT5s+cBggiF6+y1yyb5Pra8JMxpx3sTcS30WqmtOH9Gh0A20fulL+gKFXOhSy66jZ WwOjUfFdYF1C7HqzwLvveJN0gLE425LU/XjOaWYNlSSZXDTB2C3c3JXcZiJur1xnit1a Jr4egK3ENkmdcBCxDrk1ZqseSVYgBMBAdtegwaQamKFpa6P5/KqWfbP9bm/9xB6iFXQb JMNqM/oK+YXtFi9G3RQAMLgSbUN0suqYPp3qDRZ0cPnHuqYnyCkEXsi09OlsrgnwXMRm OVJA== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@intel.com header.s=Intel header.b=JWqMAXaI; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=intel.com Return-Path: Received: from out1.vger.email (out1.vger.email. [2620:137:e000::1:20]) by mx.google.com with ESMTP id n3-20020a170902f60300b00188ef2314acsi5279974plg.527.2023.01.13.05.57.16; Fri, 13 Jan 2023 05:57:23 -0800 (PST) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20; Authentication-Results: mx.google.com; dkim=pass header.i=@intel.com header.s=Intel header.b=JWqMAXaI; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=intel.com Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S241599AbjAMNjY (ORCPT + 53 others); Fri, 13 Jan 2023 08:39:24 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:41198 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S241828AbjAMNil (ORCPT ); Fri, 13 Jan 2023 08:38:41 -0500 Received: from mga01.intel.com (mga01.intel.com [192.55.52.88]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 4FB3B10C1; Fri, 13 Jan 2023 05:33:30 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1673616810; x=1705152810; h=from:to:cc:subject:in-reply-to:references:date: message-id:mime-version; bh=SIimS6dlFX7jkCJ504BScuOul7TISPli5vt+Yekfd2g=; b=JWqMAXaI3NY0NUrLwAfgHteNbeUosSi9422ea7XNGO4HvafBN6G8IUci Tz6SonHdvmmseG03Df+B1a1WhRVd+UnYs92xoGf5LWwl9bkc0E1eSlZjZ 2GN2u06a+fWZD1aobmavS2IK0OxZYunczGFlq/k+pa4DfZ5IUAurveZrO mWQbglwK1ZQ1n/PinYgWdUUKZcbZZRuNFfmN00+rgrqQholH08WjiDaKo yA+8l2oj1yg2W7krbwHY2M1CjWjxAqfi9SplyZ+mLA9PslisIFrRspMYD a8toEbJPgomuMgcKIkd8nb2JnUE6gPuWgkPd3ME+soWR1XwxuzBzDIKrW g==; X-IronPort-AV: E=McAfee;i="6500,9779,10588"; a="351224602" X-IronPort-AV: E=Sophos;i="5.97,214,1669104000"; d="scan'208";a="351224602" Received: from fmsmga006.fm.intel.com ([10.253.24.20]) by fmsmga101.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 13 Jan 2023 05:33:29 -0800 X-ExtLoop1: 1 X-IronPort-AV: E=McAfee;i="6500,9779,10588"; a="903572429" X-IronPort-AV: E=Sophos;i="5.97,214,1669104000"; d="scan'208";a="903572429" Received: from ubik.fi.intel.com (HELO localhost) ([10.237.72.184]) by fmsmga006.fm.intel.com with ESMTP; 13 Jan 2023 05:33:23 -0800 From: Alexander Shishkin To: Greg Kroah-Hartman , linux-kernel@vger.kernel.org Cc: Greg Kroah-Hartman , Jens Axboe , Alison Schofield , Vishal Verma , Ira Weiny , Ben Widawsky , Jeremy Kerr , Joel Stanley , Alistar Popple , Eddie James , Jonathan Cameron , Jilin Yuan , Heikki Krogerus , Alan Stern , Andy Shevchenko , Thomas Gleixner , Jason Gunthorpe , "Rafael J. Wysocki" , Won Chung , linux-block@vger.kernel.org, linux-cxl@vger.kernel.org, linux-fsi@lists.ozlabs.org, linux-usb@vger.kernel.org, Dan Williams , alexander.shishkin@linux.intel.com Subject: Re: [PATCH v2 06/16] driver core: make struct device_type.devnode() take a const * In-Reply-To: <20230111113018.459199-7-gregkh@linuxfoundation.org> References: <20230111113018.459199-1-gregkh@linuxfoundation.org> <20230111113018.459199-7-gregkh@linuxfoundation.org> Date: Fri, 13 Jan 2023 15:33:16 +0200 Message-ID: <877cxqsgo3.fsf@ubik.fi.intel.com> MIME-Version: 1.0 Content-Type: text/plain X-Spam-Status: No, score=-4.3 required=5.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_EF,RCVD_IN_DNSWL_MED, RCVD_IN_MSPIKE_H3,RCVD_IN_MSPIKE_WL,SPF_HELO_NONE,SPF_NONE autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Greg Kroah-Hartman writes: > The devnode() callback in struct device_type should not be modifying the > device that is passed into it, so mark it as a const * and propagate the > function signature changes out into all relevant subsystems that use > this callback. For the intel-th bit: Acked-by: Alexander Shishkin Thanks, -- Alex