Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
From:   Anastasia Belova <abelova@astralinux.ru>
To:     Tomasz Duszynski <tomasz.duszynski@octakon.com>
Cc:     Anastasia Belova <abelova@astralinux.ru>,
        Jonathan Cameron <jic23@kernel.org>,
        Lars-Peter Clausen <lars@metafoo.de>,
        Andy Shevchenko <andy.shevchenko@gmail.com>,
        linux-iio@vger.kernel.org, linux-kernel@vger.kernel.org,
        lvc-project@linuxtesting.org
Subject: [PATCH] iio: chemical: scd30: Add check for NULL in scd30_i2c_command
Date:   Fri, 13 Jan 2023 16:33:20 +0300
Message-Id: <20230113133320.7531-1-abelova@astralinux.ru>
MIME-Version: 1.0
Content-Transfer-Encoding: quoted-printable
Precedence: bulk

Check rsp for NULL-pointer before dereferencing.

Found by Linux Verification Center (linuxtesting.org) with SVACE.

Fixes: e510190e0139 ("iio: chemical: scd30: add I2C interface driver")
Signed-off-by: Anastasia Belova <abelova@astralinux.ru>
---
 drivers/iio/chemical/scd30_i2c.c | 6 ++++--
 1 file changed, 4 insertions(+), 2 deletions(-)

diff --git a/drivers/iio/chemical/scd30_i2c.c b/drivers/iio/chemical/scd3=
0_i2c.c
index bae479a4721f..84baf67fc0ce 100644
--- a/drivers/iio/chemical/scd30_i2c.c
+++ b/drivers/iio/chemical/scd30_i2c.c
@@ -101,8 +101,10 @@ static int scd30_i2c_command(struct scd30_state *sta=
te, enum scd30_cmd cmd, u16
 			return -EIO;
 		}
=20
-		*rsp++ =3D buf[i];
-		*rsp++ =3D buf[i + 1];
+		if (rsp) {
+			*rsp++ =3D buf[i];
+			*rsp++ =3D buf[i + 1];
+		}
 	}
=20
 	return 0;
--=20
2.30.2