Received: by 2002:a05:6358:a55:b0:ec:fcf4:3ecf with SMTP id 21csp1008588rwb; Fri, 13 Jan 2023 06:55:24 -0800 (PST) X-Google-Smtp-Source: AMrXdXta7jfKbqHBEpBM/77NIxY8d1KTAS4P8nd642DhF61FxiqDl9BB7OK9PuhgsJXwurbDaBe0 X-Received: by 2002:a17:906:7714:b0:829:6064:bc52 with SMTP id q20-20020a170906771400b008296064bc52mr60935857ejm.74.1673621724311; Fri, 13 Jan 2023 06:55:24 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1673621724; cv=none; d=google.com; s=arc-20160816; b=0q08piOo03PIqSc8+EwvBlA1uxBYzDocssy2gNu/CH8HD6Hc5h7ZnlFfjCquB239KX qQXIIOguwE/TwmIuqCXIlPP3sVLeONGiCJfAKm+bP1jTCITgU4/i+13sC+r1evpXiAgX L6hFQqLNLa/uTHgmayFXVUm+2XetbxmUJ4dk3l2DFyqu08cAUPxAHYSyjsHvhNRVE7bD 5ZBc3VcggcIUHdORAppNSnDqUoTmD+sRuKCtPCTyk7fnv/jP+E4CgBdqRMY23ot0KF2F BYGX8fOGQgdO9ukL1JslfLMKsKnxpAdfIsq9f3H5cNYhPScfYZdt644E/uk6cUqH334f 7FzA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:cc:to:message-id:date:from :content-transfer-encoding:mime-version:subject:dkim-signature; bh=l1RIwBp0yJ5lH1L64wuQ7APSBGMzI08Fx77HiM0sRVY=; b=iOUsIuuYnEIUih5ISnj7u0S7yZsa+A06WWKi1JJyRFsu4SJSA+msjtejP8NlNcgowG Y627w9wwcn2gE+tOBELhTFSN2U+4OHl46ndZCX0rTJ+E1lVaPy9eRbcxSL9YehKsFOIL 7Ck/n3Baqy29vDAozwCk6HqrSKXZ9G8CcIODG3ZjSfpGtGuwZSq0Z7RjDX4FxctlvWlG JdcPuN2hdXL/kBEUIdwU3AUcTygjQ+Z3Spyw9sgIR4Q+3vv3QRjlBObB0J4qb+P+TJOj xDZIX2eIcUiH/ZD4n7qi2M3w1iAXDxNRIe8Q/7fviQXUCzrJpE68PYDu2tHh0416OWyI lbdg== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@chromium.org header.s=google header.b=W0Mfb3U7; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=chromium.org Return-Path: Received: from out1.vger.email (out1.vger.email. [2620:137:e000::1:20]) by mx.google.com with ESMTP id bb6-20020a1709070a0600b0084e3eac46d5si12779121ejc.729.2023.01.13.06.55.08; Fri, 13 Jan 2023 06:55:24 -0800 (PST) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20; Authentication-Results: mx.google.com; dkim=pass header.i=@chromium.org header.s=google header.b=W0Mfb3U7; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=chromium.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S241825AbjAMNwq (ORCPT + 51 others); Fri, 13 Jan 2023 08:52:46 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:51220 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S241800AbjAMNwT (ORCPT ); Fri, 13 Jan 2023 08:52:19 -0500 Received: from mail-ej1-x62a.google.com (mail-ej1-x62a.google.com [IPv6:2a00:1450:4864:20::62a]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 642EC66983 for ; Fri, 13 Jan 2023 05:49:04 -0800 (PST) Received: by mail-ej1-x62a.google.com with SMTP id tz12so52469018ejc.9 for ; Fri, 13 Jan 2023 05:49:04 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=chromium.org; s=google; h=cc:to:message-id:date:from:content-transfer-encoding:mime-version :subject:from:to:cc:subject:date:message-id:reply-to; bh=l1RIwBp0yJ5lH1L64wuQ7APSBGMzI08Fx77HiM0sRVY=; b=W0Mfb3U70T2Wycyjf93CaAwwa1HXqY1j/j1XwfFi/rJR2gi68CNenGYB7rYxQdm954 iFxhSm8Q5nuGXAJnjS32hAxm8oNf7fpg4pbkIicLhBBdGazzrYb3xI++X91P7BgXLyDJ ftAXsqsroGAVfZwHxnALShlKOXn06/Ar/LH60= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=cc:to:message-id:date:from:content-transfer-encoding:mime-version :subject:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=l1RIwBp0yJ5lH1L64wuQ7APSBGMzI08Fx77HiM0sRVY=; b=2TvvzkhRf/CDqc0SYBCrKlenF6tMwjnViXCwotYVR/7crpV/CBb7oo4Je6DmWYKNtx io26P2ocCNoBDVmX8/77RXxizvsuAHmfnKw+rYbI7bXuZxzMOTc64v/4NW+pGQRX+jpl xxsSaJZJujIxIxoC75F9gUCJG5OBzYuFfXL1b/hqapAWMUSoCzM4w72H+aR538ZvNBTY QpUGP8/wUIiBSJ4cDO4a40qOZQwb+o5JvqTiEo8/wB1tgRe+ASNFjFaihfD4rsP5CQb1 PIR5Pyq2q7SM8IqzN8eaUoQA5VSQKvyn6xHXy0XHya3I4SbJesHSaMIpN1u5FNqc+cAs Nv5Q== X-Gm-Message-State: AFqh2kr8RwUij4q1zvNyWiBzNril33FJ/OCyxEEO9YDdYJ5yRPz9t77G UNCTZsttRo9mkPBuLtNTZWzhSbLILEtXmva5HUQ= X-Received: by 2002:a17:906:6d8a:b0:7c0:f907:89a2 with SMTP id h10-20020a1709066d8a00b007c0f90789a2mr58259617ejt.61.1673617742791; Fri, 13 Jan 2023 05:49:02 -0800 (PST) Received: from alco.roam.corp.google.com ([2620:0:1059:10:b023:4272:bddc:acf2]) by smtp.gmail.com with ESMTPSA id w23-20020a1709062f9700b0084d3bf44996sm7072888eji.142.2023.01.13.05.49.01 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 13 Jan 2023 05:49:02 -0800 (PST) Subject: [PATCH v5 0/5] uvcvideo: Fixes for hw timestamping MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 7bit X-B4-Tracking: v=1; b=H4sIAD5hwWMC/4XNzarCMBAF4FeRrG8kmaZt4sr3EBf5GU3AppK0FZ G+u3PvUuR2NZwD55sXq1gSVnbYvVjBJdU0Zgrtz475aPMVeQqUGQgAYUDwghVz4PExpQHrZIc7dw 0C9GBAq8Bo6GxF7orNPtI0z7cblTHVaSzPv0eLpHP611wkFxyNl8pBq5VQRx/LOKR52I/lys4kLr CtAClBB9HJzrlOwhel2VaaX8WZi0XsL6oPXxS1rShSrA7By6bVFsyHsq7rGzxXxVCOAQAA From: Ricardo Ribalda Date: Fri, 13 Jan 2023 14:48:46 +0100 Message-Id: <20220920-resend-hwtimestamp-v5-0-660679c6e148@chromium.org> To: Mauro Carvalho Chehab , Laurent Pinchart Cc: "hn.chen" , linux-kernel@vger.kernel.org, linux-media@vger.kernel.org, Ricardo Ribalda X-Mailer: b4 0.11.0-dev-696ae X-Developer-Signature: v=1; a=openpgp-sha256; l=2802; i=ribalda@chromium.org; h=from:subject:message-id; bh=0PV0sUQqxlmjE21EwLCffDJjqS6YLgkk2HDuasuWIrM=; b=owEBbQKS/ZANAwAKAdE30T7POsSIAcsmYgBjwWE/Q89zpxJmxeKVAldSf+ac05R3bvBuUSMjq2d+ wk6nBpqJAjMEAAEKAB0WIQREDzjr+/4oCDLSsx7RN9E+zzrEiAUCY8FhPwAKCRDRN9E+zzrEiEq/EA CUllrcopo8nrPc3h0qC25Jp+7tmZL+y4qDktkIO77bc66ngbYk4XewGHaEKoozUQF34vq9ZwqtX7yW ExIdhS29fj6k8Aohui8kvgwrp/iHM4/b1jd+e8M4zXGLmZMXJod3YDVBV1d14vQNUbddmulvy4pe04 jN4Z3sjsW0gad/p3OMBR9Q0dC8QmYWbRQJ8ZAct9LyI0Qy0ECo2A7gW/pPzZdDWpvlZDKZ56iuT3Px GZul4vyxaV+Ar2HG/ksaowHTHI8auwkgOVhDz1Fa/NShEkfSAKKmsNxBOcKm4x6FPtW3sJD3CGeFG/ s3HVpaaPzK5mfpbCNHutEAzDFgPKe8yqKCbBzGGkq86KA1F3C+ij3FmeCna1rpk9nelpk/20nzS6I5 Bz+NwKAzBybsk4gkG7yp8NaCWTaRsmXQt4ezy2SAQUoBQ6Dm74BJvSq90V7pb/IrEgwveKLDYvQ1l3 mmKXL+vGni7jugK5WBElF8AK7yHAvhjTag2oPoSQIERnpC22+W+RgGoJXjV2uFiVQ+VlulOJVTv3iJ 10bkMa/ErOFBq44AlG6lPuZaoNwpCNkGb2oHm7/dDg3gnjWab45v+Lgw+NMNGFQFL39HDy9hIUfKi2 UXcCwkTG65eixpu2WwEe2LO2+Fwn15yTelUSjCN9NkKTilrySEap4dnuTryg== X-Developer-Key: i=ribalda@chromium.org; a=openpgp; fpr=9EC3BB66E2FC129A6F90B39556A0D81F9F782DA9 X-Spam-Status: No, score=-2.1 required=5.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,RCVD_IN_DNSWL_NONE, SPF_HELO_NONE,SPF_PASS autolearn=unavailable autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Add some fixes for fixing hw timestamp on some Logitech and SunplusIT cameras. The issues have been previously reported to the manufacturers. Also include a patch to fix the current hw timestamping logic for ANY uvc 1.5 model running at under 16 fps. @HungNien, the logic for empty_ts has slightly changed since v4, would be great if you could test it on your end. To: Laurent Pinchart To: Mauro Carvalho Chehab Cc: linux-media@vger.kernel.org Cc: linux-kernel@vger.kernel.org Cc: hn.chen Tested-by: HungNien Chen Signed-off-by: Ricardo Ribalda --- Changes in v5: Thanks Dan - Check for !buf on empty TS packets. - Link to v4: https://lore.kernel.org/r/20220920-resend-hwtimestamp-v4-0-a8ddc1358a29@chromium.org Changes in v4 (Thanks Laurent!): - Rebase on top of pinchart/next/uvc - Use heuristic for UVC_QUIRK_IGNORE_EMPTY_TS - Link to v3: https://lore.kernel.org/r/20220920-resend-hwtimestamp-v3-0-db9faee7f47d@chromium.org Changes in v3 (Thanks Laurent!): - Rebase on top of pinchart/uvc/next - Fix hw timestampt handling for slow FPS - Improve commit message - Quirk for invalid dev_sof in Logi C922 - Improve commit message - Allow hw clock updates with buffers not full - Fix typo and improve messages - Refactor clock circular buffer - Improve commit message - Quirk for autosuspend in Logi C910 - Improve commit message - Add comments around the quirk - Create UVC_QUIRK_IGNORE_EMPTY_TS quirk - Improve comments - Allow quirking by entity guid - unsinged int - Extend documentation of uvc_video_clock_decode() - uvcvideo on commit message - Improve comment - Link to v2: https://lore.kernel.org/r/20220920-resend-hwtimestamp-v2-0-d8d0616bb612@chromium.org Changes in v2: - Require 1/4 sec of data before using the hw timestamps - Add Tested-by SunplusIT - Link to v1: https://lore.kernel.org/r/20220920-resend-hwtimestamp-v1-0-e9c14b258404@chromium.org --- Ricardo Ribalda (5): media: uvc: Ignore empty TS packets media: uvcvideo: Quirk for invalid dev_sof in Logitech C922 media: uvcvideo: Allow hw clock updates with buffers not full media: uvcvideo: Refactor clock circular buffer media: uvcvideo: Fix hw timestamp handling for slow FPS drivers/media/usb/uvc/uvc_driver.c | 9 +++ drivers/media/usb/uvc/uvc_video.c | 123 ++++++++++++++++++++++++------------- drivers/media/usb/uvc/uvcvideo.h | 2 + 3 files changed, 91 insertions(+), 43 deletions(-) --- base-commit: 73d6709376914f577a61bb29e596fa93ec66598c change-id: 20220920-resend-hwtimestamp-b3e22729284d Best regards, -- Ricardo Ribalda