Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Message-ID: <2f9ef115-a508-090b-d804-23235a447063@oracle.com>
Date:   Fri, 13 Jan 2023 09:16:23 -0600
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101
 Thunderbird/102.6.0
Subject: Re: [PATCH mm-unstable v2 8/8] mm/hugetlb: convert
 demote_free_huge_page to folios
Content-Language: en-US
To:     Mike Kravetz <mike.kravetz@oracle.com>,
        Matthew Wilcox <willy@infradead.org>,
        Naoya Horiguchi <naoya.horiguchi@linux.dev>
Cc:     linux-kernel@vger.kernel.org, linux-mm@kvack.org,
        akpm@linux-foundation.org, songmuchun@bytedance.com,
        jhubbard@nvidia.com
References: <20230110212821.984047-1-sidhartha.kumar@oracle.com>
 <20230110212821.984047-9-sidhartha.kumar@oracle.com>
 <Y73bP5CFT/8T/DvO@casper.infradead.org> <Y738EQkRcgv1eO66@monkey>
From:   Sidhartha Kumar <sidhartha.kumar@oracle.com>
In-Reply-To: <Y738EQkRcgv1eO66@monkey>
Content-Type: text/plain; charset=UTF-8; format=flowed
Content-Transfer-Encoding: 7bit
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?RlltQmdLeUFzby9WRExncFZQdzdiSUtPNVFGZFdYd3dmaUhvRWZOeEJ0MFZN?=
 =?utf-8?B?ZWc3dm9ZVnRGdlBMbUhsTTlIQU0wRlNjUVU2VVJwdU9QNWl0dDR5bTNLYnJz?=
 =?utf-8?B?Zm1WeFJKbGVZclZzaFlYdlJ4OGZtSnEwL3QxOVBWTnBDVDBBdUlsU3pqQzU2?=
 =?utf-8?B?R01KNFF0Z3RQSFNLaktKVzc3S3h4ekgvUk81WlBHRHRHeURrMXdGUStIRlpQ?=
 =?utf-8?B?bXRHNXd6NXBYRG1iYTRybGQrbmdzOTRrV1JObTBna0lUT2cxM1M4WXhONEMr?=
 =?utf-8?B?S3JpclA3eUR6NHZzck5idEZRdzNDK1VJTnNqZis3b3pJRXpUWVFLcjY1Vy9Z?=
 =?utf-8?B?Yk5MUDZYYmpWdFFEZlhrSlZNTG9URXcwSWZ2Slp6c1I2elRzWlNxa2U1MmtG?=
 =?utf-8?B?VWFabkQyb3FvcU1zN2kzTWxlVE5SSkYyZWVIdCtCT1pxN2ZGZ21QNHZVWXVS?=
 =?utf-8?B?RWYyUXNhVmVFTTNuc21HZzBiSFFFSGZpYlNPM0dVNWszUU9WMTk3Y3ZaSHBU?=
 =?utf-8?B?NFJYYjhRdFFqcG11Vk0vY0tCOXBJOFpnaXpXcjZRMy80RitqOWVZcWlPdkw4?=
 =?utf-8?B?S2RRN2JMZXhFSW0zUTNuU0tqcFVscWdTNTJBYW9pVnpWbFRKdTBZNHRQMG9s?=
 =?utf-8?B?aFA2ZDViaGJzNmI5ckFreFZTRG01aHcyRDFLNFJRbytBSFNPWWpXRFQ4K0t1?=
 =?utf-8?B?R1RGKzQ0K3hkY0RkUzAvY0ZuSmZEUDh6YXh5SzNRb25PcWxzMHYxV09iNTVy?=
 =?utf-8?B?elIvUnBWbHVSSHRVOXh3ZThFK01ySUhBSXVzQVR2VUN5dHpFVWxQUEtxSGpW?=
 =?utf-8?B?aElKckxHVkRjS0VlaFJZNUkyM1UrcnlidnJQYlhCRnJLbk0yS0lMblc2ZGFa?=
 =?utf-8?B?RmRUWnlHc2RkSW1iUHhGN1MrQVZBUzdIQUgzRjVhdFR0a05meURrYjVLa3dt?=
 =?utf-8?B?S0taSW5aSExmSy9VR0VQS1FPZjMwK3QyWGpCVFREME8xR0dqUFVoVlk3TW9z?=
 =?utf-8?B?OWd4Y0pwOXZHdTE3S0pWcjJhQnRYUlNPWVN4ck4rOXNScnhnWk5QNnE0QnIy?=
 =?utf-8?B?SHljclViV3pUd3JkRitZeEFzUFVqV1BQSFJ5ZzltWlNaY2JVaUlhekgvZ3hX?=
 =?utf-8?B?SGpuMFFrTHNKV2h3OGFSNWJsRmxQWDRSK0VLSGxsYWx1TDFaa21JVytHNmJz?=
 =?utf-8?B?Z3Y5MzVYSlptNEo4SWsrOENqMzBwdkVJVHRtUXc1THNSejRGU0tTbXNlcmo2?=
 =?utf-8?B?dUJwZjNLVlM2cFc0RlhCaXE4VjUvVVJOU1VZbEN1U1lzb0k0Q0lPRFh6L1VF?=
 =?utf-8?B?blZFRUxkMUZTUi9MaUluZVNJOTFXRGUyZ05VeEJYRjdqUjFxNGROaEd5dGVN?=
 =?utf-8?B?U3BWTDVQRGptdTlIcDhDOWtDbzBiQWVJME00M1J3aFZ2MUJZaU45aldEWUF5?=
 =?utf-8?B?RldEY1FzMzJpdE9Udm5VYmhqMWs1TnBrNE9BRFdtQzNQaDFLMXZ6dFQ3QUdZ?=
 =?utf-8?B?NXdaR0J1d1haK3Q3SmE0eStqWjQzR0RxbERaRkpJVFZ4dkJrNWo0T01jZnpC?=
 =?utf-8?B?ODlqei9QY3JCVy9Lc2RNcmg1dXZqeis5U2c0QmhONHUxOWNwKzRZaU5WYTBn?=
 =?utf-8?B?WEY4QjZkQ1hidmczbUsxb2dydXVuTTR4TXVxbUt3amZMNHB6U0hjYkdzZkFF?=
 =?utf-8?B?UFRVcHBwQXNYVlg4UndaY3kxc1RpendnZzRZWUVGTUM0YWNtQ2hHWGg0eGFt?=
 =?utf-8?B?U3RqSEdXUkp5N1hSd1FpSEJjSmhKdEQ3YmpGTkdCVEdFcVJpZzhnbXlPSkZu?=
 =?utf-8?B?dFNkVTF0L0xmem9rWHpRQi9XdXVhRGw5cU91SU5RSi95OVd0V1ZnMmlGYnUz?=
 =?utf-8?B?NXNvYjBrZ0ZmbWhYVlFKSy9oeThHWVNFeTJvekJTSmFselJ1QWdqblJYWHdq?=
 =?utf-8?B?c0dmOG9BODdUVDZtclIzZmxvSFhhWjR2aktaSUNBOHRqM0hPTTBiVjRycyto?=
 =?utf-8?B?SmdSL3dSSy9oYTh6RUZBNVBVNmUwRldLbldLZXRSL1RKaDZONGI4ekdFVHc3?=
 =?utf-8?B?d3RHaDdiOCtnU1Z2Y3J6NVJMRnZWOXRKTEhCMHFFeEJHTGEvL2d4bm9aMFE3?=
 =?utf-8?B?Q1NXR2pvVWMrTzRjTkRLVUJnYitWNDNXMHlUb3JtUDQyUmMyZ0hnbm56c2lL?=
 =?utf-8?B?R1E9PQ==?=
X-MS-Exchange-AntiSpam-ExternalHop-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-ExternalHop-MessageData-0: =?utf-8?B?ZXR3MDZDTS9YdlA5bDl6MFFjTXlhMVl5WnNxZVhCYWpRSGNKVkFXUkF0RlVz?=
 =?utf-8?B?ejc4MGtKMmg2Z1NoeVg1MzFUdTdGQmZGb09LOXJRajVHV1lhMFVUREpxbzJ5?=
 =?utf-8?B?dUdnc01ERHAvLzRGWnd2dGpVRGJmNGZEQUxYQllvaGdSbDVnck5ZQ0JHc3VJ?=
 =?utf-8?B?Z0k3NUYxYTVDWVNzd1ZFRjlNYmJFUmEwRWlYaGZVZnlMcVNVQjhnY2U5V2Jr?=
 =?utf-8?B?alB3WVdWV3BPOHltc3djbWsyTGd2ciszemE5aHo4cmdJNFo5dHFES1hIa244?=
 =?utf-8?B?R3Vsek40NEFISHArUmRBaDFVNSsyNUszV3BuSngrM2FjdGpYZmZLaXJ0cVVy?=
 =?utf-8?B?UHlJSFFLc0xwbDFnUFFFdEVWL3kvSW9QbUFWdUhKTzBOUUJqZ0FJYkt3RUVz?=
 =?utf-8?B?TUtNdlNmd0FKVFVrS2JJcWtkRkpTdFg1SGdYQXQxblhKcUlqeVNSS3ByM0tV?=
 =?utf-8?B?Sk93N3pxb3VKU3VNL1N2U05Fb3pkQWc2NHNKN051WU1wNzI5d3k3OEEzVG1K?=
 =?utf-8?B?VHB1NGhScDhpVUNzejRJeEh4QnNEMzNEMk1zeWpXMVRTYVhYdDNjU3NiN1JY?=
 =?utf-8?B?QjJ2bHFHbzhSRHFKaE9FK2h1cnhaWGNXdWFkLzE0UUo3Qk5jdVRuTDVTdFhF?=
 =?utf-8?B?dW9UakNrKzBDUk9wYzhTMVJhNVh0S3M0eUM1U1o1YWcwM05EVm1RN0pLYi95?=
 =?utf-8?B?OXZlYmZ3NytaTjZxUjFQd21zVzc3a0hLY0krbXFyK3liMG5WWVNJaytNaXhO?=
 =?utf-8?B?NHQvVDhIRDY0emQvRnZkVSsxMWJvSDYxclR1OW4raDByb3Z0TVM3MEJKOGwz?=
 =?utf-8?B?VUZnQzhYMnFHNXNMN2dTc3Z0NFZVSFBiT2JtZEpMWUJyRHVYOGJTNHdCN3ds?=
 =?utf-8?B?R052dWhUSzBQc2hxQWlDRFk2QVNPZHc5ZGF2S3p2SG5kR3dBeFVoWENpaHQy?=
 =?utf-8?B?L0NkcmdYSFlodDROR1U2Y2pkYzYyd1RYenVjS1pSeG16Nkd3WXpTTzNqS011?=
 =?utf-8?B?QkR1RDMwUk45REtpTTg4YktYMnh6MGg2UjhYOUllZ3VXbEg5WlhaWmV2NS8r?=
 =?utf-8?B?aldidmpWb2JiM3pSUCtVTSszdEorRTdMTmZyZG9NNThSK2dxM3RERXZiYzFJ?=
 =?utf-8?B?SWxSOTNKSnRDdmpLR3h6aDlON2IxUDZ0ZE9vZEVocGZyczZQem4rWXp2Q1Iy?=
 =?utf-8?B?eGY0eWxQVVJxQWpUTktjcEk5N2ZlZDZ4b1JLVUE5aTNGMWFFQ3hVUXV5UWRS?=
 =?utf-8?B?cDVqOTJpb2dRSDUwTFh6d08wY2tmOGxpTnd2eWRoZ204NElnOWtjaXNiTk9P?=
 =?utf-8?Q?1uS2xfBkPxRE0=3D?=
X-OriginatorOrg: oracle.com
X-MS-Exchange-CrossTenant-Network-Message-Id: dff5c86e-9fa6-4cf0-0521-08daf57922a6
X-MS-Exchange-CrossTenant-AuthSource: DS7PR10MB5117.namprd10.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 13 Jan 2023 15:16:25.8592
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 4e2c6054-71cb-48f1-bd6c-3a9705aca71b
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: wRHi5NUHvCYuLVEsIypR4S3ibMosEmMp5HTwml2SUPoYwPPL14LC4SSUoprCd5KQPo3yEa9iSuoMZEfqLjwqm0hm1JMuznaZc4m41+dpI7I=
X-MS-Exchange-Transport-CrossTenantHeadersStamped: SN7PR10MB6406
X-Proofpoint-Virus-Version: vendor=baseguard
 engine=ICAP:2.0.219,Aquarius:18.0.923,Hydra:6.0.562,FMLib:17.11.122.1
 definitions=2023-01-13_07,2023-01-13_02,2022-06-22_01
X-Proofpoint-Spam-Details: rule=notspam policy=default score=0 spamscore=0 phishscore=0 suspectscore=0
 malwarescore=0 mlxscore=0 bulkscore=0 mlxlogscore=999 adultscore=0
 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.12.0-2212070000
 definitions=main-2301130100
X-Proofpoint-GUID: iiUrNoJ3UqeRvWhNyjR5XFvQCD9tl3bE
X-Proofpoint-ORIG-GUID: iiUrNoJ3UqeRvWhNyjR5XFvQCD9tl3bE
X-Spam-Status: No, score=-2.8 required=5.0 tests=BAYES_00,DKIM_SIGNED,
        DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,NICE_REPLY_A,RCVD_IN_DNSWL_LOW,
        RCVD_IN_MSPIKE_H2,SPF_HELO_NONE,SPF_NONE autolearn=ham
        autolearn_force=no version=3.4.6
X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on
        lindbergh.monkeyblade.net
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

On 1/10/23 6:00 PM, Mike Kravetz wrote:
> On 01/10/23 21:40, Matthew Wilcox wrote:
>> On Tue, Jan 10, 2023 at 03:28:21PM -0600, Sidhartha Kumar wrote:
>>> @@ -3505,6 +3505,7 @@ static int demote_pool_huge_page(struct hstate *h, nodemask_t *nodes_allowed)
>>>   {
>>>   	int nr_nodes, node;
>>>   	struct page *page;
>>> +	struct folio *folio;
>>>   
>>>   	lockdep_assert_held(&hugetlb_lock);
>>>   
>>> @@ -3518,8 +3519,8 @@ static int demote_pool_huge_page(struct hstate *h, nodemask_t *nodes_allowed)
>>>   		list_for_each_entry(page, &h->hugepage_freelists[node], lru) {
>>>   			if (PageHWPoison(page))
>>>   				continue;
>>> -
>>> -			return demote_free_huge_page(h, page);
>>> +			folio = page_folio(page);
>>> +			return demote_free_hugetlb_folio(h, folio);
>>>   		}
>>>   	}
>>
>> Can't this be
>> 		list_for_each_entry(folio, &h->hugepage_freelists[node], lru)
>>
>> which avoids the call to page_folio() here.
>>
>> I think the call to PageHWPoison is actually wrong here.  That would
>> only check the hwpoison bit on the first page, whereas we want to know
>> about the hwpoison bit on any page (don't we?)  So this should be
>> folio_test_has_hwpoisoned()?
>>
>> Or is that a THP-thing that is different for hugetlb pages?
> 
> I believe it is different for hugetlb pages.  See hugetlb_set_page_hwpoison()
> where it sets PageHWPoison on head page as well as allocating a raw_hwp_page

I agree, this line in hugetlb_set_page_hwpoison (which is now 
folio_set_hugetlb_hwpoison) sets the HWPoison flag on the head page

int ret = folio_test_set_hwpoison(folio) ? -EHWPOISON : 0;

so the correct code in demote_pool_huge_page() would be:

	list_for_each_entry(folio, &h->hugepage_freelists[node], lru) {
			if (folio_test_hwpoison(folio))
				continue;
			return demote_free_hugetlb_folio(h, folio);
		}


> to track the actual page with poison.  Note that we can not directly flag
> hugetlb 'subpages' because we may not have the struct pages due to vmemmap
> optimization.  Adding Naoya just to be sure.
> 
> Do agree that this could be list_for_each_entry(folio ...

Will make this change in v3.

Thanks,
Sidhartha Kumar