Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Date:   Fri, 13 Jan 2023 15:50:04 +0000
From:   Matthew Wilcox <willy@infradead.org>
To:     Kefeng Wang <wangkefeng.wang@huawei.com>
Cc:     akpm@linux-foundation.org, linux-mm@kvack.org,
        linux-kernel@vger.kernel.org
Subject: Re: [PATCH -next 7/7] mm: swap: remove unneeded
 cgroup_throttle_swaprate()
Message-ID: <Y8F9rHVHu7XsBg49@casper.infradead.org>
References: <20230112083006.163393-1-wangkefeng.wang@huawei.com>
 <20230112083006.163393-8-wangkefeng.wang@huawei.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <20230112083006.163393-8-wangkefeng.wang@huawei.com>
Precedence: bulk

On Thu, Jan 12, 2023 at 04:30:06PM +0800, Kefeng Wang wrote:
> All the callers of cgroup_throttle_swaprate() are converted to
> folio_throttle_swaprate(), so make __cgroup_throttle_swaprate()
> to take a folio, and drop unused cgroup_throttle_swaprate().

Shouldn't __cgroup_throttle_swaprate() then be called
__folio_throttle_swaprate()?

> +extern void __cgroup_throttle_swaprate(struct folio *folio, gfp_t gfp_mask);

Also you can drop the 'extern'.

> +static inline void folio_throttle_swaprate(struct folio *folio, gfp_t gfp_mask)

And it's not a gfp mask.  It's gfp_flags (we have this mistake all
through the mm).  Or you can just call it 'gfp'.