Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Message-ID: <34f9fc91c398f85c0bedaff89adbb33897cb1f62.camel@linux.intel.com>
Subject: Re: [PATCH 3/3] thermal/drivers/intel: Use generic trip points
 int340x
From:   srinivas pandruvada <srinivas.pandruvada@linux.intel.com>
To:     Daniel Lezcano <daniel.lezcano@linaro.org>,
        "Zhang, Rui" <rui.zhang@intel.com>,
        "rafael@kernel.org" <rafael@kernel.org>
Cc:     "linux-pm@vger.kernel.org" <linux-pm@vger.kernel.org>,
        "daniel.lezcano@kernel.org" <daniel.lezcano@kernel.org>,
        "linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
        "christophe.jaillet@wanadoo.fr" <christophe.jaillet@wanadoo.fr>,
        "linux-acpi@vger.kernel.org" <linux-acpi@vger.kernel.org>,
        "amitk@kernel.org" <amitk@kernel.org>
Date:   Fri, 13 Jan 2023 07:48:59 -0800
In-Reply-To: <ddcfbd2e-2ea0-9305-96c4-8127181cdd8c@linaro.org>
References: <20230110151745.2546131-1-daniel.lezcano@linaro.org>
         <20230110151745.2546131-4-daniel.lezcano@linaro.org>
         <4f461027be209156d6d9f26870748f204ff4184b.camel@intel.com>
         <ddcfbd2e-2ea0-9305-96c4-8127181cdd8c@linaro.org>
Content-Type: text/plain; charset="UTF-8"
User-Agent: Evolution 3.38.4 (3.38.4-1.fc33) 
MIME-Version: 1.0
Content-Transfer-Encoding: 8bit
Precedence: bulk

Hi Daniel,

> > > 

[...]

> > > -       status = acpi_evaluate_integer(d->adev->handle, "GTSH",
> > > NULL,
> > > &hyst);
> > > -       if (ACPI_FAILURE(status))
> > > -               *temp = 0;
> > > -       else
> > > -               *temp = hyst * 100;
> > 
> > The previous code returns hyst * 100.
> > But the new API retuurns hyst directly.
> > 
> > -/sys/class/thermal/thermal_zone2/trip_point_4_hyst:2000
> > +/sys/class/the
> > rmal/thermal_zone2/trip_point_4_hyst:20
> > 
> > Is this done on purpose?
> 
> No, it is an error. The function thermal_acpi_trip_gtsh() should do:
> 
>         return deci_kelvin_to_millicelsius(hyst);
> 
> 

GTSH returns here in tenths of degree Kelvin. For example 15 means 1.5
degree K.

I would like to test your next series with thermald. If there is a
problem, it will break every distro.

Thanks,
Srinivas


> 
>