Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Message-ID: <5c046bb8-3d74-04c2-f32e-b6fd450f80fc@linaro.org>
Date:   Fri, 13 Jan 2023 17:49:43 +0100
MIME-Version: 1.0
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101
 Thunderbird/102.6.1
Subject: Re: [PATCH 2/2] Revert "dt-bindings: power: rpmpd: Add SM4250
 support"
Content-Language: en-US
To:     Konrad Dybcio <konrad.dybcio@linaro.org>,
        linux-arm-msm@vger.kernel.org, andersson@kernel.org,
        agross@kernel.org
Cc:     marijn.suijten@somainline.org, linux-kernel@vger.kernel.org,
        Rob Herring <robh+dt@kernel.org>,
        Krzysztof Kozlowski <krzysztof.kozlowski+dt@linaro.org>,
        devicetree@vger.kernel.org
References: <20230113152232.2624545-1-konrad.dybcio@linaro.org>
 <20230113152232.2624545-2-konrad.dybcio@linaro.org>
 <e1782f36-5a28-1fe4-47d5-b3bc00317b57@linaro.org>
 <92b7955c-bcac-20ad-ccde-3eef17f092b6@linaro.org>
From:   Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>
In-Reply-To: <92b7955c-bcac-20ad-ccde-3eef17f092b6@linaro.org>
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 7bit
Precedence: bulk

On 13/01/2023 17:36, Konrad Dybcio wrote:
> 
> 
> On 13.01.2023 17:33, Krzysztof Kozlowski wrote:
>> On 13/01/2023 16:22, Konrad Dybcio wrote:
>>> SM4250 and SM6115 use a shared device tree and the RPMPDs are
>>> identical. There's no need for a separate entry, so remove it.
>>>
>>> This reverts commit 45ac44ed10e58cf9b510e6552317ed7d2602346f.
>>>
>>> Signed-off-by: Konrad Dybcio <konrad.dybcio@linaro.org>
>>> ---
>>>  .../devicetree/bindings/power/qcom,rpmpd.yaml          |  1 -
>>>  include/dt-bindings/power/qcom-rpmpd.h                 | 10 ----------
>>>  2 files changed, 11 deletions(-)
>>>
>>> diff --git a/Documentation/devicetree/bindings/power/qcom,rpmpd.yaml b/Documentation/devicetree/bindings/power/qcom,rpmpd.yaml
>>> index 633d49884019..5bb9f59d196f 100644
>>> --- a/Documentation/devicetree/bindings/power/qcom,rpmpd.yaml
>>> +++ b/Documentation/devicetree/bindings/power/qcom,rpmpd.yaml
>>> @@ -39,7 +39,6 @@ properties:
>>>        - qcom,sdm845-rpmhpd
>>>        - qcom,sdx55-rpmhpd
>>>        - qcom,sdx65-rpmhpd
>>> -      - qcom,sm4250-rpmpd
>>
>> Yet, dedicated compatibles are usually recommended. Maybe this should be
>> used with fallback:
>> "qcom,sm4250-rpmpd", "qcom,sm6115-rpmpd"
> The compatible has never been used so far and it's really the
> same situation as SDM630/660 AFAIK, so I don't think it makes
> much sense.

OK, assuming these are almost the same SoCs in that aspect:

Acked-by: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>

Best regards,
Krzysztof