Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Date:   Fri, 13 Jan 2023 17:11:15 +0000
From:   Mark Brown <broonie@kernel.org>
To:     Pierre-Louis Bossart <pierre-louis.bossart@linux.intel.com>
Cc:     Charles Keepax <ckeepax@opensource.cirrus.com>, vkoul@kernel.org,
        yung-chuan.liao@linux.intel.com, sanyog.r.kale@intel.com,
        linux-kernel@vger.kernel.org, patches@opensource.cirrus.com
Subject: Re: [PATCH 2/2] regmap: sdw: Remove 8-bit value size restriction
Message-ID: <Y8GQs6svuei0SnX6@sirena.org.uk>
References: <20230112171840.2098463-1-ckeepax@opensource.cirrus.com>
 <20230112171840.2098463-3-ckeepax@opensource.cirrus.com>
 <756fcb2d-d571-18cb-985e-d907ab682275@linux.intel.com>
 <Y8BOCpXyOyF3igfG@sirena.org.uk>
 <3320e6b8-28c7-d028-3c4c-2b4b25a963fb@linux.intel.com>
 <Y8BkiF8sfqPifYTO@sirena.org.uk>
 <4a6ae9b4-2748-c751-aec6-05979de95cfe@linux.intel.com>
 <20230113110252.GK36097@ediswmail.ad.cirrus.com>
 <487b7647-8304-8e36-00f2-c9ba3aa50004@linux.intel.com>
MIME-Version: 1.0
Content-Type: multipart/signed; micalg=pgp-sha512;
        protocol="application/pgp-signature"; boundary="Z4kQJHcgSRHcgMz/"
Content-Disposition: inline
In-Reply-To: <487b7647-8304-8e36-00f2-c9ba3aa50004@linux.intel.com>
Precedence: bulk


--Z4kQJHcgSRHcgMz/
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline

On Fri, Jan 13, 2023 at 10:57:39AM -0600, Pierre-Louis Bossart wrote:

> The change from reg_write/read_reg to write/read seems ok, what I was
> asking about was the gather_write.

> +	.write = regmap_sdw_write,
> +	.gather_write = regmap_sdw_gather_write,
> +	.read = regmap_sdw_read,

> what happens if you only have .write and .read? What does the
> .gather_write help with if you only use only address?

Like I said before it means that the core doesn't have to put the
register in a linear buffer with the values, meaning it can avoid
copying already formatted data around or allocating memory.

--Z4kQJHcgSRHcgMz/
Content-Type: application/pgp-signature; name="signature.asc"

-----BEGIN PGP SIGNATURE-----

iQEzBAABCgAdFiEEreZoqmdXGLWf4p/qJNaLcl1Uh9AFAmPBkLIACgkQJNaLcl1U
h9CVJgf9GMgtyJcMx5FSRjr5BEqOqFjs+LoFoue2wNLyCXl7cwU7l9BIVKNQpm8K
NL0JghhDvda6gGYrDbrLFp/Hd85ImgzJ1jN6W5cR2fIaP+K11BzJe+l9euqqannn
lUqNOt9FVbkjDKcXxXE1wgjfvy5EbZHs8cHG/EUiTzRj+idv9k2V5cUFxICu6g7k
qxzj0rX64flrsECenoTs9vcXPhUjvtqki6PxxkZKysbyrDCxISDYYSmKx1D6qn5P
nHSio8V6Me7vNGihfJlUr4l3OsBXOTGfJUNRo3EYF4OxAwasYz6FWoTf5NXxwsB9
GZBqtAMKplyND2JA7ZJc52nZ0r2DVA==
=7nwP
-----END PGP SIGNATURE-----

--Z4kQJHcgSRHcgMz/--