Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
MIME-Version: 1.0
References: <20220415050003.3257645-1-mattst88@gmail.com> <20221019232952.2212729-1-mattst88@gmail.com>
 <CAEdQ38FO0SH80SLQKpLxadOBKn7cuRmZLd=xU8jJguq+MuD+Lw@mail.gmail.com>
 <CAEdQ38G8_bNzNnvYj2RHoOEufv4P3gKKGxHNgGWGG7_gBrR4dg@mail.gmail.com> <CAEdQ38E8du48Q1KNnRRokftRpMmjUb-anCKX_3Q9n77KfZF-6A@mail.gmail.com>
In-Reply-To: <CAEdQ38E8du48Q1KNnRRokftRpMmjUb-anCKX_3Q9n77KfZF-6A@mail.gmail.com>
From:   Ian Rogers <irogers@google.com>
Date:   Fri, 13 Jan 2023 10:20:18 -0800
Message-ID: <CAP-5=fWJ4mU67J+peDnvuUaz3ZoaSGx=wfJ1Vnux2ce3T0C8Wg@mail.gmail.com>
Subject: Re: [PATCH v2] tools: port perf ui from GTK 2 to GTK 3
To:     Matt Turner <mattst88@gmail.com>
Cc:     linux-perf-users@vger.kernel.org, linux-kernel@vger.kernel.org,
        Peter Zijlstra <peterz@infradead.org>,
        Ingo Molnar <mingo@redhat.com>,
        Arnaldo Carvalho de Melo <acme@kernel.org>,
        Mark Rutland <mark.rutland@arm.com>,
        Alexander Shishkin <alexander.shishkin@linux.intel.com>,
        Jiri Olsa <jolsa@kernel.org>,
        Namhyung Kim <namhyung@kernel.org>,
        Jelle van der Waa <jvanderwaa@redhat.com>
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: quoted-printable
Precedence: bulk

On Fri, Jan 13, 2023 at 9:53 AM Matt Turner <mattst88@gmail.com> wrote:
>
> On Fri, Dec 2, 2022 at 4:11 PM Matt Turner <mattst88@gmail.com> wrote:
> >
> > On Mon, Oct 31, 2022 at 10:02 AM Matt Turner <mattst88@gmail.com> wrote=
:
> > >
> > > On Wed, Oct 19, 2022 at 7:30 PM Matt Turner <mattst88@gmail.com> wrot=
e:
> > > >
> > > > From: Jelle van der Waa <jvanderwaa@redhat.com>
> > > >
> > > > GTK 2 is a legacy API and the newer version is GTK 3 which changes =
a few
> > > > API functions. gtk_tree_view_set_rules_hint is no longer required s=
ince
> > > > theme's are now responsible to handle this, gtk_vbox_new is depreca=
ted
> > > > and replaced by passing the orientation to gtk_box_new. Apart from =
these
> > > > changes the accessing of the screen changed in GTK which requires u=
sing
> > > > new functions for getting geometry. Lastly the GTK_STOCK_OK define =
is
> > > > deprecated in GTK 3.
> > > >
> > > > Signed-off-by: Jelle van der Waa <jvanderwaa@redhat.com>
> > > > Signed-off-by: Matt Turner <mattst88@gmail.com>
> > > > ---
> > > > Originally sent in 2019. I've rebased it and given it a test.
> > > >
> > > > One problem I've noticed is that C++ symbol names are often broken.
> > > > E.g.:
> > > >
> > > > (perf:3254940): Gtk-WARNING **: 21:47:46.663: Failed to set text fr=
om
> > > > markup due to error parsing markup: Error on line 1 char 95:
> > > > =E2=80=9Cstd::char_traits<char=E2=80=9D is not a valid name: =E2=80=
=9C<=E2=80=9D
> > > >
> > > > Presumably we need to call g_markup_escape_text() somewhere, but I
> > > > struggled to find the right place.
> > > >
> > > > Without the patch, the GTK-2 version repeatedly segfaults, so this =
is an
> > > > improvement regardless.
> > > >
> > > > v2: Dropped changes to test-all.c. I don't know how to build that
> > > >     apparently.
> > >
> > >
> > > Arnaldo, does this work better for you?
> >
> > Ping=C2=B2
>
> Ping=C2=B3

Hi Matt,

did you see Namhyung's comment? It looks possible that we can drop the
infobar feature check for GTK3, which would help simplify the builds.
It seems to make sense to fold that into this change, or to have it as
a patch on top of this. Wdyt?

Thanks,
Ian