Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Message-ID: <b79f7e0a-8048-d0e1-ad0b-d15d72288fde@amd.com>
Date:   Fri, 13 Jan 2023 10:08:19 -0800
User-Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.15; rv:109.0)
 Gecko/20100101 Thunderbird/109.0
Subject: Re: [PATCH] dt-bindings: sram: Tightly Coupled Memory (TCM) bindings
Content-Language: en-US
To:     Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>,
        Tanmay Shah <tanmay.shah@amd.com>, robh+dt@kernel.org,
        krzysztof.kozlowski+dt@linaro.org
Cc:     devicetree@vger.kernel.org, linux-kernel@vger.kernel.org,
        linux-remoteproc@vger.kernel.org
References: <20230113073045.4008853-1-tanmay.shah@amd.com>
 <6f43e320-b533-e5fb-3886-1b6ccc7f9548@linaro.org>
From:   Tanmay Shah <tanmays@amd.com>
In-Reply-To: <6f43e320-b533-e5fb-3886-1b6ccc7f9548@linaro.org>
Content-Type: text/plain; charset=UTF-8; format=flowed
Content-Transfer-Encoding: 7bit
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?WXlUSGJZYVBRUVFhLzVTYk1hRHFITUJ2bGMzK0VBRWV4ckM1STEvSXRuWnU3?=
 =?utf-8?B?MVpScXp1c29ZUlZ2cFJhTlo3UzIvRWdnbmVGeUFqYlBkeGZqMS9Gd2pmS2E0?=
 =?utf-8?B?QTNGNEIzNEhlVmc1N0hTNkxKbzNIMzJYSjc1NVZGQzRIVDZ6QW1sWVl6ZXh0?=
 =?utf-8?B?aGtqVU1rdG43bjcza1dlaGo3dzZ6TGNsM05qVm9tdFAraXo5S2dFalU2MVlu?=
 =?utf-8?B?Q0k1dFRuTS95TTJZVHU5ZWl2ZHh0TTE5dmJWM1pUbGI4Z1h6ekhtWmN4U3lD?=
 =?utf-8?B?UlpBdTc3VmtyWDh2U1ZYWGpzeDR2TkQ1V0JVbC8zUGNWK0xSNWc5Q01NMmdX?=
 =?utf-8?B?SWs0NlptZGE4Z05CSFdKckUxbWZLdXk4NFBkMEVNMTBIUWZHc0FXVWpnVnBa?=
 =?utf-8?B?L1h5T2srcG5SYjZmbmhaVmFXU094cGlaUGE3c3diQWhwazJFYVNLSGczMnlG?=
 =?utf-8?B?S2doWGg0bnJtN3FhQld5MUkvMS9CRSs3NVB1ZFRWaVJ2bm1vdi9ybEhUTndy?=
 =?utf-8?B?K1A3ZGQrSkV0cG9LREljcytSa3NzdFR6b1Q0YjY2enNBRk9pZitBUVdrdVZ5?=
 =?utf-8?B?V2xiNFVqUEpzNHEzMEJXRzBOYzRVVExyZG81czVFaVQzanM5ZzB2UXRBeWEx?=
 =?utf-8?B?Yzkwd2xLcnVwUExkNFdEdHZ5LzV6UFFoVkwrcGJYOTRKN1o5UTY4eGs0eUNI?=
 =?utf-8?B?UVBFb2ZSV1NGdkd6bXU2MHlGU1duazdVSmR2Y0Y2YTI2OFBpOVJGTnc0dDc0?=
 =?utf-8?B?UTJtWW9CU3dmY2NVMVBBQ2VBUmF5eHUzbVppbkQ0WnEreXlrVXBYaFoyNm1Z?=
 =?utf-8?B?VmVSeFhWSFJPdG45bTlJYVFnbmx6bjlENmJvUGJHSmpDQ3pIWXJTcVZFckdY?=
 =?utf-8?B?ZUhpMDdqM0dONXVYdnlFME14N29ERWxUU0FnUzFLQ1k1UG1qTFFEVEtFNjl0?=
 =?utf-8?B?L2VJeGNVK28zMkh4QWtmS29ocDRLMFp2Wi8vdzhkOTRQR1lTcGYzOEdiajVW?=
 =?utf-8?B?WDg3alJEOWVGVDBjck9JZVE2U3h5cmhEam93VXozTWRtLy9hZi9jY3lWOVI4?=
 =?utf-8?B?Uk9ZT2NabW5FUDVjbXdrdGlyMUVLQkJkVUVZR3pKSmgzU3FNWjN6VGZCMVNm?=
 =?utf-8?B?QlA5Tkd3Y1VjSzZISEw1bWszZUd2MkFNS2l0REdlK291MzZTd1pFTEpTMGd2?=
 =?utf-8?B?OXZZMWsxMWJZdWFESEw4WTd0UEEzdnNYWUQyMmZwaG5ock9pMEtkSFJNRzAr?=
 =?utf-8?B?Z1FxQVV0NkJlV0hBOFlueE0rcXhWTUhHcnBUclpPUUozUlVQRmo5bVNCQitV?=
 =?utf-8?B?VTBLcXFmdjc1bUtPNEN0bTJ2NjlUNURxL1VQSFVadEhqWTlTTlBTdFduYWRt?=
 =?utf-8?B?dHlpeE8xYy9MeHMzbnJweHlMcTdVZkJJK21hbmFncVFMR1VFMnNySmlVQmhP?=
 =?utf-8?B?Ukpzb3ExdWY0bmx4Yi8xY25GK2wwNmlVYVdUVVhueGxOaWpyOUNIekJHQ0xR?=
 =?utf-8?B?RjJ0Ti81d2c4T0cvTmw3eWFjaE5aL2VNaWNJMTRlQjFsanBSNGl5NnluTGFM?=
 =?utf-8?B?b1R4dWY3ZG1SeFE2NzZnaW42Vi81UFdWNkdYNDBENDFCMHZBMm15SzZ5cWU4?=
 =?utf-8?B?ZWI1QjBhWE5obzNmRHN4UnlGOFlYOVZGM0l1ZjM2WjVBdi9MK2VNcmpBU3ht?=
 =?utf-8?B?VWE3OWZGcHJnMEZnNm94YUM1dUdndVZnbXFWejRQcW1CYUh6SXZMMGpRMmxM?=
 =?utf-8?B?bjYyY0I5QTU0a1NZc0QzOHpDdkl1UlZqMU13aVo0Mmo1K055ZklHRkJKYWFv?=
 =?utf-8?B?ZnZIYmx4RnVwQldXK25vV1JQc3ZJQzZMTDgvb2JGcjQ5VVBLUExLa2o4L1N6?=
 =?utf-8?B?cHViNjdaaG9OTlo1YUtNU25yZUlvVlZ2Z1Mxb05LbGthaXk2U3JtRGJYYmNL?=
 =?utf-8?B?dXB5MzJ1a25vdkVzYURGczhYZzNwQUg5MGRtUnVzTnJpdkx1QjU5dHF5M2pH?=
 =?utf-8?B?TmZWejNZSHMzbmhrNWhOOWF2TE0vUkM1cU9BQXVOeGtmUXU1SzE2ck9tNmJa?=
 =?utf-8?B?dG9TeXZxTlpCN01zTE9lREdIUHJ6VWpzT3c3YWxuVCtMam8xTHFkS0JuTmtk?=
 =?utf-8?B?SWZKempBTUUyUFRCajBYSHQ0SnpTeFg4TEFpYnZhbWloSk4xUWdJMHBBNkh0?=
 =?utf-8?Q?a0Kd8Mg9OZVuoPbSp+Cl5p0myXJb38tdfU4HxkN7Uh61?=
X-OriginatorOrg: amd.com
X-MS-Exchange-CrossTenant-Network-Message-Id: c851bbea-82f1-471a-b8f8-08daf591298a
X-MS-Exchange-CrossTenant-AuthSource: BY5PR12MB3683.namprd12.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 13 Jan 2023 18:08:24.3929
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 3dd8961f-e488-4e60-8e11-a82d994e183d
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: rHWy4fEVmAZ+7QnSOQwfAb202Gk10u1ySZcUjxnIbQ9yQVbbL699ducc56V8Tc62
X-MS-Exchange-Transport-CrossTenantHeadersStamped: DM4PR12MB6469
X-Spam-Status: No, score=-2.1 required=5.0 tests=BAYES_00,DKIM_SIGNED,
        DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,NICE_REPLY_A,RCVD_IN_DNSWL_NONE,
        RCVD_IN_MSPIKE_H2,SPF_HELO_PASS,SPF_PASS autolearn=ham
        autolearn_force=no version=3.4.6
X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on
        lindbergh.monkeyblade.net
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org


On 1/12/23 11:52 PM, Krzysztof Kozlowski wrote:
> On 13/01/2023 08:30, Tanmay Shah wrote:
>> This patch introduces bindings for TCM memory address space on AMD-xilinx
>> platforms. As of now TCM addresses are hardcoded in xilinx remoteproc
>> driver. This bindings will help in defining TCM in device-tree and
>> make it's access platform agnostic and data-driven from the driver.
>>
> Subject: drop second/last, redundant "bindings". The "dt-bindings"
> prefix is already stating that these are bindings.

Ack.


>
> Where is driver or DTS? Are you now adding a dead binding without users?


TCM is used by drivers/remoteproc/xlnx_r5_remoteproc.c driver. Howerver, 
we have hardcode addresses in TCM as bindings are not available yet.


>
> Best regards,
> Krzysztof
>