Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Content-Type: text/plain; charset=utf-8
Content-Transfer-Encoding: 8BIT
From:   John Paul Adrian Glaubitz <glaubitz@physik.fu-berlin.de>
Mime-Version: 1.0 (1.0)
Subject: Re: [PATCH v4] sh: avoid using IRQ0 on SH3/4
Date:   Fri, 13 Jan 2023 19:38:44 +0100
Message-Id: <09EB6264-E85C-487C-B706-6411BB18DDDF@physik.fu-berlin.de>
References: <961f3b42-1522-79d5-7012-1533b568696f@omp.ru>
Cc:     Rich Felker <dalias@libc.org>, linux-sh@vger.kernel.org,
        linux-kernel@vger.kernel.org,
        Yoshinori Sato <ysato@users.sourceforge.jp>,
        Greg Kroah-Hartman <gregkh@linuxfoundation.org>
In-Reply-To: <961f3b42-1522-79d5-7012-1533b568696f@omp.ru>
To:     Sergey Shtylyov <s.shtylyov@omp.ru>
Precedence: bulk

Hi Sergey!

> On Jan 13, 2023, at 7:27 PM, Sergey Shtylyov <s.shtylyov@omp.ru> wrote:
> 
> ﻿Hello!
> 
>> On 5/3/22 11:42 PM, Sergey Shtylyov wrote:
>> 
>> Using IRQ0 by the platform devices is going to be disallowed soon (see [1])
>> and even now, when IRQ0 is about to be returned by platfrom_get_irq(), you
>> see a big warning.  The code supporting SH3/4 SoCs maps the IRQ #s starting
>> at 0 -- modify that code to start the IRQ #s from 16 instead.
>> 
>> The patch should mostly affect the AP-SH4A-3A/AP-SH4AD-0A boards as they
>> indeed use IRQ0 for the SMSC911x compatible Ethernet chip...
>> 
>> [1] https://lore.kernel.org/all/025679e1-1f0a-ae4b-4369-01164f691511@omp.ru/
>> 
>> Fixes: a85a6c86c25b ("driver core: platform: Clarify that IRQ 0 is invalid")
>> Signed-off-by: Sergey Shtylyov <s.shtylyov@omp.ru>
>> Reviewed-by: Geert Uytterhoeven <geert+renesas@glider.be>
>> Tested-by: Geert Uytterhoeven <geert+renesas@glider.be>
>> Tested-by: John Paul Adrian Glaubitz <glaubitz@physik.fu-berlin.de>
>> 
>> ---
>> The patch is against Linus Torvalds' 'linux.git' repo.
> 
>   So, this patch hasn't been merged... may I ask why? :-(

The SH maintainers have been MIA which is why the other maintainers want to kill the architecture again.

I’m seriously considering adopting the architecture.

Not sure whether Linus would grant that though.

Adrian