Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Date:   Fri, 13 Jan 2023 14:05:58 -0500
From:   Rodrigo Vivi <rodrigo.vivi@intel.com>
To:     Deepak R Varma <drv@mailo.com>
CC:     Jani Nikula <jani.nikula@linux.intel.com>,
        Joonas Lahtinen <joonas.lahtinen@linux.intel.com>,
        Tvrtko Ursulin <tvrtko.ursulin@linux.intel.com>,
        David Airlie <airlied@gmail.com>,
        "Daniel Vetter" <daniel@ffwll.ch>,
        <intel-gfx@lists.freedesktop.org>,
        <dri-devel@lists.freedesktop.org>, <linux-kernel@vger.kernel.org>,
        "Saurabh Singh Sengar" <ssengar@microsoft.com>,
        Praveen Kumar <kumarpraveen@linux.microsoft.com>
Subject: Re: [PATCH v3 0/2] drm/i915: Avoid full proxy f_ops debug attributes
Message-ID: <Y8Grli/Ie01RvDBR@intel.com>
References: <cover.1673451705.git.drv@mailo.com>
Content-Type: text/plain; charset="us-ascii"
Content-Disposition: inline
In-Reply-To: <cover.1673451705.git.drv@mailo.com>
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?us-ascii?Q?pBCfhI+p55xPy6Q+eaRbSOa+eSNn0I1IsMfNuW7BcFPa8k3AoLfRujUNiCv8?=
 =?us-ascii?Q?ndw3ot1yFtTWjMhpBA2u1nYDjgQnSEGU3x+431BxABM0qkBdTXOrO4x1+4mp?=
 =?us-ascii?Q?XpnsOT9/rDVldj0csngU71XbHUxnqYSr2XVKRcvr3af0pWEq9QR+lJaBiEqZ?=
 =?us-ascii?Q?M9NCZRlVLHnslgPKJJ9NjQai1ZnvlZB4SGVg8bU82wsQrRtddNgJkddDv5oq?=
 =?us-ascii?Q?PdIUqeuXFBpxbk2VoDhPw7KsTXg2m3JP1j1e8MOijn/1T4f622ir6NAc5yTF?=
 =?us-ascii?Q?ac+ej0aSPRWI/4vzMLjs54nieVwb7E69vsbOD0Ea90On121cr6fAwJXULmUo?=
 =?us-ascii?Q?cusKGentJuoi087LCNN3ZirKsrujQme+E0Kn487lOL16D+XRsixY1pKoUBJL?=
 =?us-ascii?Q?A5SY0uT2eE6lXvF0QCND1HwISymTiPkzwTO835JHnzaba/HXS7i+Tit/Iiqm?=
 =?us-ascii?Q?b7iBnpix5wdcLh0TS6WldAdlcomiR3gpsHVLV+ivyf1BY5pj6MbB0JDbh4xN?=
 =?us-ascii?Q?mjbHW1sEt/4WY3hff1p4PICm+24g4GYTN53QWa4sNBKCvTk5l5aIeUCI4FoS?=
 =?us-ascii?Q?n6GQ8YO8ld+smHLmVu50JPxZnTUoSIGexuEY6NGdQbGePIZaJpAL7LHfMMAh?=
 =?us-ascii?Q?WZXLLLg5mgwBLSczfrCDKfiAxUmBd3tUSWlCG4uJ8n1whdS4jd5nFSksJOEw?=
 =?us-ascii?Q?uSKjRghB1uQsqPob1yuNfmiKm+2AEKtr3SPeGa+yyLk529Osg6QgvnxNpw/M?=
 =?us-ascii?Q?VbJ4OpiMkBPcuxv2xYRSpjgf3cmYzmFcCu+Fo4e0F6sI27blkGA9enC1bc3l?=
 =?us-ascii?Q?7eI+ugw68uzFW+u1C+/e3yFdZ3Z15BfHIny1fdOJ6lcK0LmqWG9hhPY3MeHS?=
 =?us-ascii?Q?VvpVg99ZABQKwvmwUnMA3dEZ1oFoCqVwu/xpiayhcJC9F9jm0NlDb59WSg67?=
 =?us-ascii?Q?Le6RdIr372bxxMFm8xX2HzMfoTQqEtvNP4fneosWbUzgH7Vjm1cuAZRtimuk?=
 =?us-ascii?Q?plZplso+iLtJtLWuGGsA6Jd1x9PJgJ9VvObCCmGg5Vmv5NBK/3fpfp2u1zVz?=
 =?us-ascii?Q?Kdo737NOEbj7+c1GrbWQsanOFIl176IFWzVOrtnseB6NVDPjKIq+IRtrHH/E?=
 =?us-ascii?Q?gFOBEAHG85i8pQaCRazSIBnMYzOwe32VcKbaL5UFBlROozczWSIJeW60sFIo?=
 =?us-ascii?Q?aMZn2yLMw2KZxO4yyTitta0u/jURnRy8RCbmaiGNWWQSWwPdJJSGeNUaglPe?=
 =?us-ascii?Q?13GYLuPkq0Dpcmd1aQJWRfJcnALMZlVmKjEWbJc0b2BDM8mER//0MLbxurSd?=
 =?us-ascii?Q?3cuYMp5VARdQryFpT/n99j6RCA6raoFOOxRQgBbiz+ETbCGhYtH6nA+imwd5?=
 =?us-ascii?Q?V2pC1JN9cJ/Y+Gp+WgPiKndUBAXTaVAERNLF9cHTm9+54q7JMV8EmaMJp5kU?=
 =?us-ascii?Q?emh5b0tf15TKsNonFl7bblym0DZZZmztCXCBA0Lpz/HiX74UUIRkTRtbv//1?=
 =?us-ascii?Q?tqJagkEQXdQ/lBnTNmak2aSzAB4D6OI0/r03F/Rydixo4vOs3SkIU5Wv+Kq/?=
 =?us-ascii?Q?sCESy0tUiCohVOkteFESGbZoKfI5cGSZs6dglMgxKcVE4URVM1fqQG7/YowV?=
 =?us-ascii?Q?Gw=3D=3D?=
X-MS-Exchange-CrossTenant-Network-Message-Id: 805b76c2-9443-4961-0926-08daf59937ac
X-MS-Exchange-CrossTenant-AuthSource: MN0PR11MB6059.namprd11.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 13 Jan 2023 19:06:07.8699
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 46c98d88-e344-4ed4-8496-4ed7712e255d
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: RPcgEKY+hefyqvjxWmCqdZdLN6Wfosi/lFS+azl+ds5k6znF5DYxXa1/pZrvpA0Dfb2+tYD/Ncr2wh4+1v9XWw==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: PH7PR11MB6474
X-OriginatorOrg: intel.com
X-Spam-Status: No, score=-4.4 required=5.0 tests=BAYES_00,DKIMWL_WL_HIGH,
        DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,RCVD_IN_DNSWL_MED,
        RCVD_IN_MSPIKE_H3,RCVD_IN_MSPIKE_WL,SPF_HELO_NONE,SPF_NONE
        autolearn=ham autolearn_force=no version=3.4.6
X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on
        lindbergh.monkeyblade.net
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

On Wed, Jan 11, 2023 at 09:20:40PM +0530, Deepak R Varma wrote:
> This patch series proposes to replace a combination of DEFINE_SIMPLE_ATTRIBUTE() +
> debugfs_create_file() by a combination of DEFINE_DEBUGFS_ATTRIBUTE() +
> debugfs_create_file_unsafe(). The change reduced overhead in terms of managing
> the full proxy f_ops at runtime. The patches 1 & 2 covers for the DRRS and FBC
> f_ops debugfs attributes respectively.
> 
> Following coccicheck make command helped identify this change:
> 
> make coccicheck M=drivers/gpu/drm/i915/ MODE=patch COCCI=./scripts/coccinelle/api/debugfs/debugfs_simple_attr.cocci

pushed both patches to drm-intel-next. Thanks for the patches.

> 
> Changes in v3:
>    Patch 1/2: fix checkpatch function parameter alignment complaint
>    Patch 2/2: None
> 
> Changes in v2:
>    - Individual patches clubbed in patch set
>    - Update patch log message to include coccicheck make command
> 
> 
> Deepak R Varma (2):
>   drm/i915/display: Avoid full proxy f_ops for DRRS debug attributes
>   drm/i915/fbc: Avoid full proxy f_ops for FBC debug attributes
> 
>  drivers/gpu/drm/i915/display/intel_drrs.c |  8 ++++----
>  drivers/gpu/drm/i915/display/intel_fbc.c  | 12 ++++++------
>  2 files changed, 10 insertions(+), 10 deletions(-)
> 
> -- 
> 2.34.1
> 
> 
>