Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Date:   Fri, 13 Jan 2023 13:25:04 -0600
From:   Rob Herring <robh@kernel.org>
To:     Wadim Egorov <w.egorov@phytec.de>
Cc:     linux-leds@vger.kernel.org, devicetree@vger.kernel.org,
        linux-kernel@vger.kernel.org, linux-rtc@vger.kernel.org,
        upstream@lists.phytec.de, riku.voipio@iki.fi,
        alexandre.belloni@bootlin.com, a.zummo@towertech.it,
        krzysztof.kozlowski+dt@linaro.org, lee@kernel.org, pavel@ucw.cz
Subject: Re: [PATCH v2 2/2] dt-bindings: rtc: Move rv3028 from
 trivial-rtc.yaml into own schema file
Message-ID: <20230113192504.GA2800695-robh@kernel.org>
References: <20230111163404.3526248-1-w.egorov@phytec.de>
 <20230111163404.3526248-2-w.egorov@phytec.de>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <20230111163404.3526248-2-w.egorov@phytec.de>
Precedence: bulk

On Wed, Jan 11, 2023 at 05:34:04PM +0100, Wadim Egorov wrote:
> Move RV3028 RTC bindings from trivial-rtc.yaml into microcrystal,rv3032.yaml.

That's obvious from the diff. What's not obvious is 'why' and the commit 
message should answer that. I assume something about it makes it not 
trivial.

> 
> Signed-off-by: Wadim Egorov <w.egorov@phytec.de>
> ---
> v2:
>   - Update subject 
>   - Remove not needed quotes
>   - Remove start-year
>   - Use unevaluatedProperties instead of additionalProperties
> ---
>  .../bindings/rtc/microcrystal,rv3028.yaml     | 54 +++++++++++++++++++
>  .../devicetree/bindings/rtc/trivial-rtc.yaml  |  2 -
>  2 files changed, 54 insertions(+), 2 deletions(-)
>  create mode 100644 Documentation/devicetree/bindings/rtc/microcrystal,rv3028.yaml

Otherwise,

Reviewed-by: Rob Herring <robh@kernel.org>