Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Date:   Fri, 13 Jan 2023 11:42:08 -0800
From:   "Paul E. McKenney" <paulmck@kernel.org>
To:     "Wysocki, Rafael J" <rafael.j.wysocki@intel.com>
Cc:     rcu@vger.kernel.org, linux-kernel@vger.kernel.org,
        kernel-team@meta.com, rostedt@goodmis.org,
        =?utf-8?B?TWljaGHFgiBNaXJvc8WCYXc=?= <mirq-linux@rere.qmqm.pl>,
        Borislav Petkov <bp@suse.de>,
        Alan Stern <stern@rowland.harvard.edu>,
        John Ogness <john.ogness@linutronix.de>
Subject: Re: [PATCH rcu v2 15/20] kernel/notifier: Remove CONFIG_SRCU
Message-ID: <20230113194208.GE4028633@paulmck-ThinkPad-P17-Gen-1>
Reply-To: paulmck@kernel.org
References: <20230113001103.GA3374173@paulmck-ThinkPad-P17-Gen-1>
 <20230113001132.3375334-15-paulmck@kernel.org>
 <608756bb-3012-e02c-5b16-04314cdc9889@intel.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Disposition: inline
Content-Transfer-Encoding: 8bit
In-Reply-To: <608756bb-3012-e02c-5b16-04314cdc9889@intel.com>
Precedence: bulk

On Fri, Jan 13, 2023 at 12:25:48PM +0100, Wysocki, Rafael J wrote:
> 
> On 1/13/2023 1:11 AM, Paul E. McKenney wrote:
> > Now that the SRCU Kconfig option is unconditionally selected, there is
> > no longer any point in conditional compilation based on CONFIG_SRCU.
> > Therefore, remove the #ifdef.
> > 
> > Signed-off-by: Paul E. McKenney <paulmck@kernel.org>
> > Cc: "Rafael J. Wysocki" <rafael.j.wysocki@intel.com>
> > Cc: "Michał Mirosław" <mirq-linux@rere.qmqm.pl>
> > Cc: Borislav Petkov <bp@suse.de>
> > Cc: Alan Stern <stern@rowland.harvard.edu>
> > Reviewed-by: John Ogness <john.ogness@linutronix.de>
> 
> Acked-by: Rafael J. Wysocki <rafael.j.wysocki@intel.com>

Thank you!  I will apply both of your acks on my next rebase.

							Thanx, Paul

> > ---
> >   kernel/notifier.c | 3 ---
> >   1 file changed, 3 deletions(-)
> > 
> > diff --git a/kernel/notifier.c b/kernel/notifier.c
> > index ab75637fd904f..d353e4b5402d7 100644
> > --- a/kernel/notifier.c
> > +++ b/kernel/notifier.c
> > @@ -456,7 +456,6 @@ int raw_notifier_call_chain(struct raw_notifier_head *nh,
> >   }
> >   EXPORT_SYMBOL_GPL(raw_notifier_call_chain);
> > -#ifdef CONFIG_SRCU
> >   /*
> >    *	SRCU notifier chain routines.    Registration and unregistration
> >    *	use a mutex, and call_chain is synchronized by SRCU (no locks).
> > @@ -573,8 +572,6 @@ void srcu_init_notifier_head(struct srcu_notifier_head *nh)
> >   }
> >   EXPORT_SYMBOL_GPL(srcu_init_notifier_head);
> > -#endif /* CONFIG_SRCU */
> > -
> >   static ATOMIC_NOTIFIER_HEAD(die_chain);
> >   int notrace notify_die(enum die_val val, const char *str,