Received: by 2002:a05:6358:a55:b0:ec:fcf4:3ecf with SMTP id 21csp1495547rwb; Fri, 13 Jan 2023 13:09:36 -0800 (PST) X-Google-Smtp-Source: AMrXdXta3zDl6vx3UA2uo1iWTUbVV5ZGpVAWwWYnmDPBu8aOtY5738BRzKk/cQ9zcAeq9UQ3cyTk X-Received: by 2002:a17:902:6bca:b0:189:d8fb:152d with SMTP id m10-20020a1709026bca00b00189d8fb152dmr81289230plt.25.1673644176561; Fri, 13 Jan 2023 13:09:36 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1673644176; cv=none; d=google.com; s=arc-20160816; b=FsYuQrkX0348p2MwwDj+UOnul8WSUhrrW+NUPFK57zOVkXyYwk6X3mKR+8SqYk91Al fEzrimGhVRksp7SlcsxmPx30bMH8puumNVNxnVlkNvqxdcU02cv8YYsKhkszPNj2hsof QEXdaeNuRzFbbLVlFAtoJzFcVl41JcxtnoyG2C2T15idtktdCiq2YX2NKVK9Ea+kosl/ ePVj/Ng/quuoOzV615Ecwac+EpJBGhabSwfarF45vUvx5E7vrbzv4E6c/4+da9kPApp2 EeGIiaRgPbbl/gnVJvXRjeu+DU6S2joqod8y1BecMMDc5pzD2mlK76UxkFLVmR+k2T76 u+hw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:cc:to:subject:message-id:date:from:in-reply-to :references:mime-version:dkim-signature; bh=dgYH247P+0aBOraZVoHt3Mc1CNyhHmgwBVhCXKN0lPE=; b=Sg+FWbnom0YcajgQNgj+agmLefO7bH9BS2+fCMrxtxVYZ8qNY3ZA5/qVY2LXFeiWqA V9wRV1bB3kHKRYxTy5vEsOIusCsGi6o0GD+p1VmeHjcAHU6jb8KnSEWwhd+NiFL+p2HM ItpVOdkd3xu+6o1O4VPSK1naHp2DsGfITsvwbiIjMD9uMTZ1S/HZhfOsp6QbNvQGU03K fPoZ+ahLHVWbde2O/w3nbvIfwgzsy172STDMJuBafFfuBfyuEU/QzPG/KMq8IHufaLN1 0erawIb471ndVVYAqcOrPt4PvOU53Mfdl6Jqrship5wmFAbpl7ula/RhPBr9tQQVKSL1 nNHw== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@kernel.org header.s=k20201202 header.b=S43jiel7; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org Return-Path: Received: from out1.vger.email (out1.vger.email. [2620:137:e000::1:20]) by mx.google.com with ESMTP id t2-20020a170902e84200b00189ccadd447si4990321plg.101.2023.01.13.13.09.30; Fri, 13 Jan 2023 13:09:36 -0800 (PST) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20; Authentication-Results: mx.google.com; dkim=pass header.i=@kernel.org header.s=k20201202 header.b=S43jiel7; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S231345AbjAMUq4 (ORCPT + 52 others); Fri, 13 Jan 2023 15:46:56 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:59798 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S231343AbjAMUqj (ORCPT ); Fri, 13 Jan 2023 15:46:39 -0500 Received: from dfw.source.kernel.org (dfw.source.kernel.org [139.178.84.217]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id C41C9892C5 for ; Fri, 13 Jan 2023 12:46:14 -0800 (PST) Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by dfw.source.kernel.org (Postfix) with ESMTPS id 5D90B6231C for ; Fri, 13 Jan 2023 20:46:14 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id C4031C433F0 for ; Fri, 13 Jan 2023 20:46:13 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1673642773; bh=7eYc0XhXnQW93GkTSFYdIkOSneTuRRIkHMfKlRT3emM=; h=References:In-Reply-To:From:Date:Subject:To:Cc:From; b=S43jiel7jHVWZxXocbPs9onLt6Fmy7xZvOXNcw7RyKIjL9j58y5jmOYd6x9IANi74 3cG2ay04GatN2G0GsHHOsl6/ORg+pEG78YEAiCsiXpzOqccOOJsij7CHeM5BTOQo8T 6gQiAPkXmVtgAtO4nyEQw/P31IfjQvynNFaove79hMNNpuiMZEpt3Ac1Gm5EEPvtLK uPoN/vq8nTxqn8RljxyKi73zI+0Ws007ZP0FdIpOC/UrFsNx33ShV3wk5m4ifXrtV8 cGhxoSWe4KlsYoYRILYfMYYQdKevAbpEsQwsAai2c9o1+ZyHdYVOBgSr4RyjLdFL3/ TXe/sNtjKGiPQ== Received: by mail-lf1-f48.google.com with SMTP id b3so34726384lfv.2 for ; Fri, 13 Jan 2023 12:46:13 -0800 (PST) X-Gm-Message-State: AFqh2krrXhLwGTr4e/PYX1VkcYIJGFxpD0RMMx1bVwFOP1LzFnocqkRF KaYL7rHsHzm5DhfYjFjUiV1b+96ZvXPB3QeDVwk= X-Received: by 2002:a19:640f:0:b0:4b6:e71d:94a6 with SMTP id y15-20020a19640f000000b004b6e71d94a6mr6072221lfb.476.1673642771838; Fri, 13 Jan 2023 12:46:11 -0800 (PST) MIME-Version: 1.0 References: <20230112214015.1014857-1-namhyung@kernel.org> <20230112214015.1014857-3-namhyung@kernel.org> In-Reply-To: <20230112214015.1014857-3-namhyung@kernel.org> From: Song Liu Date: Fri, 13 Jan 2023 12:45:59 -0800 X-Gmail-Original-Message-ID: Message-ID: Subject: Re: [PATCH 2/8] perf/core: Add perf_sample_save_callchain() helper To: Namhyung Kim Cc: Peter Zijlstra , Ingo Molnar , Mark Rutland , Alexander Shishkin , Arnaldo Carvalho de Melo , Jiri Olsa , LKML , x86@kernel.org Content-Type: text/plain; charset="UTF-8" X-Spam-Status: No, score=-7.1 required=5.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,RCVD_IN_DNSWL_HI, SPF_HELO_NONE,SPF_PASS autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Thu, Jan 12, 2023 at 1:40 PM Namhyung Kim wrote: > > When it saves the callchain to the perf sample data, it needs to update > the sample flags and the dynamic size. To make sure this, add the > perf_sample_save_callchain() helper and convert all call sites. > > Cc: x86@kernel.org > Suggested-by: Peter Zijlstra > Signed-off-by: Namhyung Kim Acked-by: Song Liu