Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
MIME-Version: 1.0
References: <20230110213010.2683185-1-avagin@google.com> <20230110213010.2683185-2-avagin@google.com>
 <Y8AgC99AUeMjFWKt@tycho.pizza>
In-Reply-To: <Y8AgC99AUeMjFWKt@tycho.pizza>
From:   Andrei Vagin <avagin@gmail.com>
Date:   Fri, 13 Jan 2023 13:51:14 -0800
Message-ID: <CANaxB-wVizq9RbSmidH6iSU2ymbHcpZc0k7AaA727qk-q78c0A@mail.gmail.com>
Subject: Re: [PATCH 1/5] seccomp: don't use semaphore and wait_queue together
To:     Tycho Andersen <tycho@tycho.pizza>
Cc:     Andrei Vagin <avagin@google.com>,
        Peter Zijlstra <peterz@infradead.org>,
        Ingo Molnar <mingo@redhat.com>,
        Vincent Guittot <vincent.guittot@linaro.org>,
        Dietmar Eggemann <dietmar.eggemann@arm.com>,
        linux-kernel@vger.kernel.org, Kees Cook <keescook@chromium.org>,
        Christian Brauner <brauner@kernel.org>,
        Andy Lutomirski <luto@amacapital.net>,
        Juri Lelli <juri.lelli@redhat.com>,
        Peter Oskolkov <posk@google.com>,
        Will Drewry <wad@chromium.org>
Content-Type: text/plain; charset="UTF-8"
Precedence: bulk

On Thu, Jan 12, 2023 at 6:58 AM Tycho Andersen <tycho@tycho.pizza> wrote:
>
> On Tue, Jan 10, 2023 at 01:30:06PM -0800, Andrei Vagin wrote:
> > From: Andrei Vagin <avagin@gmail.com>
> >
> > The main reason is to use new wake_up helpers that will be added in the
> > following patches. But here are a few other reasons:
> >
> > * if we use two different ways, we always need to call them both. This
> >   patch fixes seccomp_notify_recv where we forgot to call wake_up_poll
> >   in the error path.
>
> [snip]
>
> > @@ -1515,7 +1546,8 @@ static long seccomp_notify_recv(struct seccomp_filter *filter,
> >                       if (should_sleep_killable(filter, knotif))
> >                               complete(&knotif->ready);
> >                       knotif->state = SECCOMP_NOTIFY_INIT;
> > -                     up(&filter->notif->request);
> > +                     atomic_add(1, &filter->notif->requests);
> > +                     wake_up_poll(&filter->wqh, EPOLLIN | EPOLLRDNORM);
> >               }
> >               mutex_unlock(&filter->notify_lock);
> >       }
>
> I wonder if this shouldn't be a separate patch that you can send now
> independent of this series?

You are right. It is a bug fix and I can send it in a separate patch.
I didn't expect it would take so long to merge the whole set.

Thanks,
Andrei