Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Date:   Fri, 13 Jan 2023 13:45:58 -0800
From:   Ira Weiny <ira.weiny@intel.com>
To:     Jonathan Cameron <Jonathan.Cameron@huawei.com>
CC:     Dan Williams <dan.j.williams@intel.com>,
        Bjorn Helgaas <bhelgaas@google.com>,
        Alison Schofield <alison.schofield@intel.com>,
        "Vishal Verma" <vishal.l.verma@intel.com>,
        Davidlohr Bueso <dave@stgolabs.net>,
        "Dave Jiang" <dave.jiang@intel.com>,
        Ben Widawsky <bwidawsk@kernel.org>,
        "Steven Rostedt" <rostedt@goodmis.org>,
        <linux-kernel@vger.kernel.org>, <linux-pci@vger.kernel.org>,
        <linux-acpi@vger.kernel.org>, <linux-cxl@vger.kernel.org>,
        Bjorn Helgaas <helgaas@kernel.org>
Subject: Re: [PATCH v6 2/8] cxl/mem: Wire up event interrupts
Message-ID: <Y8HRFjA0bQKw/yoZ@iweiny-mobl>
References: <20221216-cxl-ev-log-v6-0-346583105b30@intel.com>
 <20221216-cxl-ev-log-v6-2-346583105b30@intel.com>
 <20230113122845.00006be6@Huawei.com>
Content-Type: text/plain; charset="us-ascii"
Content-Disposition: inline
In-Reply-To: <20230113122845.00006be6@Huawei.com>
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?us-ascii?Q?vcEoNMnn3yDwOM8TBC8A362jRR22NOTo/k1YTvNTN+jbzNso+UTNsqWFSo1F?=
 =?us-ascii?Q?uHPBH8FHZWerazzSlGOFxIjTPOVqiYcJ7YDc8qdgwKBWuI5WTC2ESJv6C21Q?=
 =?us-ascii?Q?IP+/WcK2ATb+opNpha1+8ktjsCh8pvEaMqhIhhL+xfuVo+ig34lp4J+PmicP?=
 =?us-ascii?Q?9oQ1ARDtTd9wFwD/pgNwZ8W1G2knBxo7peKMixPubBbshYynZXobGlneVL83?=
 =?us-ascii?Q?s/N1Ar7Ey9rhpULZxUoofmxKlD98ICcmw+0499HBVsLW6ht1ftxONIPm/Q7k?=
 =?us-ascii?Q?yLfz4thZf8KyJBcrTnPiZK9v1n8B2ouWjCOWQ6F9HhuJJ/U4bYhAGDA69MAf?=
 =?us-ascii?Q?301a4bzv5T+bywQRVkkrkL7z18XntDrKkJxgfFs6tPnXogwRWd0U0+3LckfS?=
 =?us-ascii?Q?Wyvk2213wTRBr2iE/UBicbAtlpKdzwKe79hiWsONc2toeiWoXAJWQF0yDrfL?=
 =?us-ascii?Q?Bo+RuIfHrPvjNwYuF1ZLK/OREaRTPaAain2gP62p4FDfcHRmiBZf7ELgEi4b?=
 =?us-ascii?Q?76k2VrtqefOcGOco2sgw9hmBjRXDLmRJCrExvDt9dTff76UkXYbZTf4uSZci?=
 =?us-ascii?Q?HTQUQqOAxeh5k5+nPjFXWREhJQzEFA2+MXjx33V3FFZpz+xNc94A9YiuQJvm?=
 =?us-ascii?Q?+JTG9oHAr+8pVoqAfTUqfzw6HpNabXhLaWD7eF7vuM12t+Kum2KLDNQvmlw1?=
 =?us-ascii?Q?/8Wu5eNxURWHWk+ipE5wJDN9iscYNLwmPZjMh8XWr6jo8+2DAYUPiUo6i8lP?=
 =?us-ascii?Q?Ex+/AdmNo9fq5OIfOSkszolBh4xM1dCwPGxZB8tT6rsxJ6+MH2soizzAyfQi?=
 =?us-ascii?Q?MtrZmek6RWVKaHFO1p9UxT4tD62CdWlpRJnBvrJdDnsyfd0Nn1G0ztLySzCY?=
 =?us-ascii?Q?QaixZKez/0ZKUDmYggBt2aRokO+w46ZoV6JykjX2icW2ljTcLDp1AAEL69ym?=
 =?us-ascii?Q?VbSGakglAqbR7aRNUq5gDmekoTcigp7BSEIOwpCQoixaEOoYdba1dO23GeH7?=
 =?us-ascii?Q?VhrzMyUUz3++AIfMPPt3rHGZSi4XSZcwP9IXVuCUScb9PCCyNcB+iIoh5fY+?=
 =?us-ascii?Q?xVE8Kn7OCUL4PJX/ksSoo24KKbsk7kSZ/ybEn/z+z49JNQk+isyhO9wY+dIb?=
 =?us-ascii?Q?ruH650YjcYrYuG/tYE7+JxDkFxZVdHAHmFIKEdfHU2Ol5fMT/VdE6DmqeaV/?=
 =?us-ascii?Q?C0h0hOqIbf77AwaW9lqxM1dTHZAKnIM8wnnCylsyowG+sfX7xvG5k5Wxlx7b?=
 =?us-ascii?Q?lAr6ECHZG2iAqe09BVd5fRQDwO+QXSm1x6MxyXLd0LSNWsgAHh8MA7EoeUQ2?=
 =?us-ascii?Q?sFs89y6GahQLzmLg9qenA+r9eyE218YrUVgqMuQcZOH3D3f29B4lrfgjZLke?=
 =?us-ascii?Q?r1Ke5vAfVZYCVq/SAFyrnwxTrLWpCSzwG4ottxXvbKpG8IowZavNBkjdn/Nb?=
 =?us-ascii?Q?6qQEstz3+vJYPNri2BkucFfb4ThZyuzgdhEPRF8a3hSgpxgA1Gy2z1C8OK6o?=
 =?us-ascii?Q?4rBkFm4krRDEzJ5QaM10fnkfdZt9ZhPafhZ6RXeayaG5sfZEIWgAksO0BhXw?=
 =?us-ascii?Q?Tl1Gvyt1X/sHfrTvxBBui1BeXPN6+5I9KiprnynP?=
X-MS-Exchange-CrossTenant-Network-Message-Id: ea114c7f-42d4-4590-6448-08daf5af90f5
X-MS-Exchange-CrossTenant-AuthSource: SA1PR11MB6733.namprd11.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 13 Jan 2023 21:46:02.9085
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 46c98d88-e344-4ed4-8496-4ed7712e255d
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: OlSKsDWmQNhfylp89jI5yJ861aRLV7Z1rAYIMbqAEFUqA7Y4gU1mJH81syGR3Kbr1qw1ouvbl2O3BhUvPXYkMg==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: SJ0PR11MB5920
X-OriginatorOrg: intel.com
X-Spam-Status: No, score=-4.4 required=5.0 tests=BAYES_00,DKIMWL_WL_HIGH,
        DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,RCVD_IN_DNSWL_MED,
        SPF_HELO_NONE,SPF_NONE autolearn=ham autolearn_force=no version=3.4.6
X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on
        lindbergh.monkeyblade.net
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

On Fri, Jan 13, 2023 at 12:28:45PM +0000, Jonathan Cameron wrote:
> On Mon, 09 Jan 2023 11:42:21 -0800
> ira.weiny@intel.com wrote:
> 
> > From: Davidlohr Bueso <dave@stgolabs.net>
> > 
> > Currently the only CXL features targeted for irq support require their
> > message numbers to be within the first 16 entries.  The device may
> > however support less than 16 entries depending on the support it
> > provides.
> > 
> > Attempt to allocate these 16 irq vectors.  If the device supports less
> > then the PCI infrastructure will allocate that number.  Upon successful
> > allocation, users can plug in their respective isr at any point
> > thereafter.
> > 
> > CXL device events are signaled via interrupts.  Each event log may have
> > a different interrupt message number.  These message numbers are
> > reported in the Get Event Interrupt Policy mailbox command.
> > 
> > Add interrupt support for event logs.  Interrupts are allocated as
> > shared interrupts.  Therefore, all or some event logs can share the same
> > message number.
> > 
> > In addition all logs are queried on any interrupt in order of the most
> > to least severe based on the status register.
> > 
> > Finally place all event configuration logic into cxl_event_config().
> > Previously the logic was a simple 'read all' on start up.  But
> > interrupts must be configured prior to any reads to ensure no events are
> > missed.  A single event configuration function results in a cleaner over
> > all implementation.
> > 
> > Cc: Bjorn Helgaas <helgaas@kernel.org>
> > Cc: Jonathan Cameron <Jonathan.Cameron@huawei.com>
> > Co-developed-by: Ira Weiny <ira.weiny@intel.com>
> > Signed-off-by: Ira Weiny <ira.weiny@intel.com>
> > Signed-off-by: Davidlohr Bueso <dave@stgolabs.net>
> 
> > 
> > ---
> > Changes from V5:
> > 	Dan
> > 		Addressed missed comments on V4
> > 		https://lore.kernel.org/all/6398dd6ed80fa_b05d1294fc@dwillia2-xfh.jf.intel.com.notmuch/
> 
> You also added pci_set_master() :)

<sigh> Yes I made the mistake of putting that note in another patch and then
when I fixed it up I dropped it from here.

> 
> Which means I can now give
> Reviewed-by: Jonathan Cameron <Jonathan.Cameron@huawei.com>

Thanks!

> 
> I only noticed because I couldn't remember why I'd not given a tag to v4.

Sorry I'm working on getting a better workflow.
Ira

> 
> Jonathan
>