Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Message-ID: <df5db53729c9a626a898edfc990337e86afc995f.camel@gmail.com>
Subject: Re: [PATCH net] net: lan966x: add missing fwnode_handle_put() for
 ports node
From:   Alexander H Duyck <alexander.duyck@gmail.com>
To:     =?ISO-8859-1?Q?Cl=E9ment_L=E9ger?= <clement.leger@bootlin.com>,
        Horatiu Vultur <horatiu.vultur@microchip.com>,
        UNGLinuxDriver@microchip.com,
        "David S. Miller" <davem@davemloft.net>,
        Eric Dumazet <edumazet@google.com>,
        Jakub Kicinski <kuba@kernel.org>,
        Paolo Abeni <pabeni@redhat.com>
Cc:     netdev@vger.kernel.org, linux-kernel@vger.kernel.org
Date:   Fri, 13 Jan 2023 14:39:04 -0800
In-Reply-To: <20230112161311.495124-1-clement.leger@bootlin.com>
References: <20230112161311.495124-1-clement.leger@bootlin.com>
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: quoted-printable
User-Agent: Evolution 3.44.4 (3.44.4-2.fc36) 
MIME-Version: 1.0
Precedence: bulk

On Thu, 2023-01-12 at 17:13 +0100, Cl=C3=A9ment L=C3=A9ger wrote:
> Since the "ethernet-ports" node is retrieved using
> device_get_named_child_node(), it should be release after using it. Add
> missing fwnode_handle_put() and move the code that retrieved the node
> from device-tree to avoid complicated handling in case of error.
>=20
> Signed-off-by: Cl=C3=A9ment L=C3=A9ger <clement.leger@bootlin.com>


You should probably add a fixes tag to this:
Fixes: db8bcaad5393 ("net: lan966x: add the basic lan966x driver")

Other than that the patch itself looks good to me.

Reviewed-by: Alexander Duyck <alexanderduyck@fb.com>