Received: by 2002:a05:6358:a55:b0:ec:fcf4:3ecf with SMTP id 21csp1668273rwb; Fri, 13 Jan 2023 16:01:25 -0800 (PST) X-Google-Smtp-Source: AMrXdXs+q6/WeemQsnqvn8yT0KVOSv6jftZevWRUGZXLQkMsYBATPBfhHSe/4qtVtaYzw7owteXv X-Received: by 2002:a17:906:3c0d:b0:84d:34f0:f766 with SMTP id h13-20020a1709063c0d00b0084d34f0f766mr25919557ejg.75.1673654484822; Fri, 13 Jan 2023 16:01:24 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1673654484; cv=none; d=google.com; s=arc-20160816; b=vS3uZJlBW4BfovMVGmJagOrkc7jvTdVgwMLtnk23VZpHmzFn5i7IQ55rLNyV9qk2Gd Id4jVSXN19AOM8Zk25Bl82pJILf1YQrE736obxRaUU6fpbYvAs4JJw4WJLzqUSXXWJkG e7okj412o0K0miQf8dFqMWkp+5FWxhbfkaC9ekYeNkweop4708Ix5yJtMYZ4BpRfaM9U R/1yAmtkEsu5LAZxrZ5dQfENFBUbPgnfZLoIsc22TOSUWSZGdFSWfkaE8AQdqBFoOXZZ Y8Yapa1tcuQvZAjfPl3FnIzFVvgzSyOV+vPAYU4y76/m6UQ3blhMM79iFzPoMWPjNzg6 MRnQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:mime-version :references:in-reply-to:message-id:date:subject:cc:to:from :dkim-signature; bh=NMiMCJTb5LFuwR4bml+l69hnYQL1G+akTSIgXjV1vXs=; b=Ys5mc2617cIBY2UhRttggevEImJ1edkhUlMPloZU6kgR+QegtymFvwJ5DI5zNYlwg0 iQ5Moq5NT12/8Ya9aDfxtKfG2saEI8Vmrk1G28rIrkF6cd2VlWm1dDYI1sjTW0DoRhEs fE+dd4zmpkqugqeNKl1kmUrYDDUCrTS4hXpidtXhVCMQI0DfZ5vhKfOyiaJqvYAAZScT OoT12FvXDEXS+aIJa91FD9Uy/Q/p4gExbfSHDmnWFc5djtxZARjHfiqpzWmKPZ0D+Fbw PFK/Wk/0can6ymANCNXvCpqffiokmAG26FsyuNm57EcZpgjHnrRoIDYnqKVHTdwTcabF teaA== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@chromium.org header.s=google header.b=X4KHjEhc; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=chromium.org Return-Path: Received: from out1.vger.email (out1.vger.email. [2620:137:e000::1:20]) by mx.google.com with ESMTP id sa5-20020a1709076d0500b0086b4343995bsi2820589ejc.629.2023.01.13.16.01.11; Fri, 13 Jan 2023 16:01:24 -0800 (PST) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20; Authentication-Results: mx.google.com; dkim=pass header.i=@chromium.org header.s=google header.b=X4KHjEhc; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=chromium.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S229563AbjAMXQA (ORCPT + 53 others); Fri, 13 Jan 2023 18:16:00 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:58030 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S231428AbjAMXP3 (ORCPT ); Fri, 13 Jan 2023 18:15:29 -0500 Received: from mail-pj1-x1035.google.com (mail-pj1-x1035.google.com [IPv6:2607:f8b0:4864:20::1035]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 39A9C7A921 for ; Fri, 13 Jan 2023 15:15:23 -0800 (PST) Received: by mail-pj1-x1035.google.com with SMTP id z9-20020a17090a468900b00226b6e7aeeaso25884180pjf.1 for ; Fri, 13 Jan 2023 15:15:23 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=chromium.org; s=google; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=NMiMCJTb5LFuwR4bml+l69hnYQL1G+akTSIgXjV1vXs=; b=X4KHjEhczDirMTjK/fziTxAevbXGGw7rq9kx81W2fTPIvGLoGCfwSt2nBrHlVe2W8G Q76Va6blny+IfEe2b39IPgaNPxMmK+0Vr4hzPMoiCnrLxsyIWeVp8LDSNcUPDE4xrgVR u4JyKKHzeF1QdYduZFXFEBBzXpOAzhL+bnVzU= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=NMiMCJTb5LFuwR4bml+l69hnYQL1G+akTSIgXjV1vXs=; b=rxua1tTBQJRJxqpHMSDc+AmyP2udGwnziPdu7xqTUhOzATyFaNcF2LmfMqaAf8Jk3P zuxFGeJo8a849lZ9IIMnOgXwwaTzQ6u2kBaczu5Ht7iER+725IoKRED1rjDutqAnkQVd lqZgtcT82JqNzr2qjwJ1PXjBB547XkKIsQUUzrEdJvLn8TkjF1taYfHhdTNMx1rSv+cb LQ9dzaeGUHgiAV5LxI72N/b2rmwvtzyY47EKlC5uauOOPkQoWriBgZsTHOF3GJdN0k7k vGEKDuNDTvaAEn41kQndKZDjRCc/b2EvUWtiwf+L46wTUS01NR+lESwy69rgKRWL4sL8 iHHg== X-Gm-Message-State: AFqh2kpSH4DgmuEIbmxbWDbw0SWZuhNetmigZbXKuQrEu4U9geUmmqFX 1QkYnPg/AZJJNK/tT2pr6AL2Sg== X-Received: by 2002:a17:90b:3d8e:b0:228:f3fd:a0e2 with SMTP id pq14-20020a17090b3d8e00b00228f3fda0e2mr9863452pjb.13.1673651722785; Fri, 13 Jan 2023 15:15:22 -0800 (PST) Received: from www.outflux.net (smtp.outflux.net. [198.145.64.163]) by smtp.gmail.com with ESMTPSA id h7-20020a17090a9c0700b00219cf5c3829sm12902587pjp.57.2023.01.13.15.15.21 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 13 Jan 2023 15:15:22 -0800 (PST) From: Kees Cook To: masahiroy@kernel.org, peterz@infradead.org, samitolvanen@google.com Cc: Kees Cook , linux-kernel@vger.kernel.org, llvm@lists.linux.dev, linux-kbuild@vger.kernel.org, nathan@kernel.org, ndesaulniers@google.com Subject: Re: [PATCH 0/1] Fix CFI hash randomization with KASAN Date: Fri, 13 Jan 2023 15:15:18 -0800 Message-Id: <167365171646.590452.12835527795605016769.b4-ty@chromium.org> X-Mailer: git-send-email 2.34.1 In-Reply-To: <20230112224948.1479453-1-samitolvanen@google.com> References: <20230112224948.1479453-1-samitolvanen@google.com> MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 8bit X-Spam-Status: No, score=-2.1 required=5.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,RCVD_IN_DNSWL_NONE, SPF_HELO_NONE,SPF_PASS autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Thu, 12 Jan 2023 22:49:47 +0000, Sami Tolvanen wrote: > Peter, Masahiro, > > I noticed that KASAN+CFI fails to boot on x86_64 without > cfi=norand. The randomization code is missing a couple of KASAN > constructors in object files that are not part of vmlinux.o. This > happens because we don't run objtool for the files, which means > the type hashes are not included in the .cfi_sites section. > > [...] Applied to for-linus/hardening, thanks! [1/1] kbuild: Fix CFI hash randomization with KASAN https://git.kernel.org/kees/c/a6c5a3491b3f -- Kees Cook