Received: by 2002:a05:6358:a55:b0:ec:fcf4:3ecf with SMTP id 21csp138557rwb; Fri, 13 Jan 2023 20:43:58 -0800 (PST) X-Google-Smtp-Source: AMrXdXtnkls7m+FAkCYA/c39pqqJsuA7l6G6hAWsxZ47h9W8yMWBEVxDpn4V1qtgHppkgMq25wx3 X-Received: by 2002:a17:906:a24a:b0:859:1d78:765 with SMTP id bi10-20020a170906a24a00b008591d780765mr5553830ejb.11.1673671438325; Fri, 13 Jan 2023 20:43:58 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1673671438; cv=none; d=google.com; s=arc-20160816; b=ih3IzgsF/tOMdayhnqPoBU2TGF+wGTNB07tCKhXn0pfbYhugoDFK0ceYEjBz12hdSJ LhppSkDcTdDFT1bMobqax26v1OkUnLyEEd47hQTIo3yQrNc4I3OFenBQjZYTs9rt70xQ KzOUujRfN0SJ/0cxyincuohGr0KjSBKijBxMiZTJt8+qIiiI5WxC5gPbGbYm7QNG6Tvl uXLaFwfAsbqxX5RPvvhUc9YXWTDaNc8wR26GaXCl+Cm1UYQY1tsO0Ljfz0yQw9LnyBIB dgo7sdkerUuC0Bf8AyMTzxkFUhtffVcbUPdR4soKLgo8H1Cl8okvIge6/gD1GJEXA4l7 qmdw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:mime-version :references:in-reply-to:message-id:subject:cc:to:from:date :dkim-signature; bh=2djDIvd5aMUPRSpuf1EyWFhgM0DcMtFcs56/Geywrok=; b=gEtaZ7MjQa8I+c/faEhdKTLXowdvkNCZlquQMlxtuzJ8Y6RqdFx/EL327YPkhCN9/q zN7jB5ERvKNYw/51KJGDHndhJIrJajCPLNlimqDZoQaBleuxFzSjkYa3O2uCOij+f+9Z PfATbJ8qB8iUV1Gs6oTaoUvru53lfmkAFkj4/GGPuvrtmEzCqAEB/2vyWql+9b17teRW v90H1/mSYPHsNqWEDXOuq9dhMk7UIqUtRXcUfbVytZhofX1iAu9SO60gu/LX4oPKQhwF WLox+5HZX3NHwQGmsCyFn9tB+oo6svXOXM5m6LveZWv6p8bU48pXHrRGNuYWUfAGd5l6 B64A== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@kernel.org header.s=k20201202 header.b=nCaX3WqX; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org Return-Path: Received: from out1.vger.email (out1.vger.email. [2620:137:e000::1:20]) by mx.google.com with ESMTP id xh10-20020a170906da8a00b007c0ea5a7ca4si23379360ejb.858.2023.01.13.20.43.45; Fri, 13 Jan 2023 20:43:58 -0800 (PST) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20; Authentication-Results: mx.google.com; dkim=pass header.i=@kernel.org header.s=k20201202 header.b=nCaX3WqX; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S229996AbjANEWo (ORCPT + 54 others); Fri, 13 Jan 2023 23:22:44 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:49046 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S231327AbjANEWP (ORCPT ); Fri, 13 Jan 2023 23:22:15 -0500 Received: from ams.source.kernel.org (ams.source.kernel.org [145.40.68.75]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id CB44C95; Fri, 13 Jan 2023 20:22:14 -0800 (PST) Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by ams.source.kernel.org (Postfix) with ESMTPS id 7546CB822C2; Sat, 14 Jan 2023 04:22:13 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id D57EBC433D2; Sat, 14 Jan 2023 04:22:10 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1673670132; bh=3hPwEascL6coLYgOqQdt4/tPGkfw2pv70pCZR8ByrIU=; h=Date:From:To:Cc:Subject:In-Reply-To:References:From; b=nCaX3WqXEyyvxS2pgfoobhBC3rq68OUDIt8u9GFhrPIB9wzT1yBsbtioAr7GCivZ/ T0XDI9Z37NCupbNwHQ6S1vHPI1LHjOOyJVzMGQayl1yyweWJu7jcHPE+LLyDwrFmkt 6twxwKZPl9HMgbKsaDOgYJuINYrvzKRl4Erlcy/VK4vjiG/cVfPhMkwYWKceDCAZ6G xAl8LdBmKGNN2s4BPGeLsowoNH57HiiDd6ZuvohD7djzGMZLW3TJZ+tPFW0To5lH17 iqEam6rI6iSHHMVxc/S6lxs/7HzJrfbC2AhYmrN4GXz9I2hfuU6VECUNrJV3NMd2RA B8MJR8EQZ2gRg== Date: Fri, 13 Jan 2023 20:22:09 -0800 From: Jakub Kicinski To: Vladimir Oltean Cc: netdev@vger.kernel.org, linux-kernel@vger.kernel.org, "David S. Miller" , Eric Dumazet , Paolo Abeni , Michal Kubecek , Claudiu Manoil , Vinicius Costa Gomes , Xiaoliang Yang , Kurt Kanzenbach , Rui Sousa , Ferenc Fejes , Pranavi Somisetty , Harini Katakam , Colin Foster , UNGLinuxDriver@microchip.com, Alexandre Belloni , Andrew Lunn , Florian Fainelli Subject: Re: [PATCH v2 net-next 04/12] net: ethtool: netlink: retrieve stats from multiple sources (eMAC, pMAC) Message-ID: <20230113202209.158ead21@kernel.org> In-Reply-To: <20230111161706.1465242-5-vladimir.oltean@nxp.com> References: <20230111161706.1465242-1-vladimir.oltean@nxp.com> <20230111161706.1465242-5-vladimir.oltean@nxp.com> MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit X-Spam-Status: No, score=-7.1 required=5.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,RCVD_IN_DNSWL_HI, SPF_HELO_NONE,SPF_PASS autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Wed, 11 Jan 2023 18:16:58 +0200 Vladimir Oltean wrote: > + int len = nla_total_size(sizeof(u32)); /* _STATS_SRC */ > unsigned int n_grps = 0, n_stats = 0; > - int len = 0; nit: don't hide the first field in init